Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH v2 3/7] drm/xe/tests: Convert xe_bo live tests
Date: Wed, 17 Jul 2024 21:51:51 +0200	[thread overview]
Message-ID: <20240717195155.442-4-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240717195155.442-1-michal.wajdeczko@intel.com>

Convert xe_bo live tests to parameterized style.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/xe/tests/xe_bo.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/tests/xe_bo.c b/drivers/gpu/drm/xe/tests/xe_bo.c
index 692e1b46b9cf..9620408f227f 100644
--- a/drivers/gpu/drm/xe/tests/xe_bo.c
+++ b/drivers/gpu/drm/xe/tests/xe_bo.c
@@ -6,6 +6,7 @@
 #include <kunit/test.h>
 #include <kunit/visibility.h>
 
+#include "tests/xe_kunit_helpers.h"
 #include "tests/xe_pci_test.h"
 #include "tests/xe_test.h"
 
@@ -158,7 +159,7 @@ static int ccs_test_run_device(struct xe_device *xe)
 	int id;
 
 	if (!xe_device_has_flat_ccs(xe)) {
-		kunit_info(test, "Skipping non-flat-ccs device.\n");
+		kunit_skip(test, "Skipping non-flat-ccs device.\n");
 		return 0;
 	}
 
@@ -178,7 +179,9 @@ static int ccs_test_run_device(struct xe_device *xe)
 
 static void xe_ccs_migrate_kunit(struct kunit *test)
 {
-	xe_call_for_each_device(ccs_test_run_device);
+	struct xe_device *xe = test->priv;
+
+	ccs_test_run_device(xe);
 }
 
 static int evict_test_run_tile(struct xe_device *xe, struct xe_tile *tile, struct kunit *test)
@@ -328,7 +331,7 @@ static int evict_test_run_device(struct xe_device *xe)
 	int id;
 
 	if (!IS_DGFX(xe)) {
-		kunit_info(test, "Skipping non-discrete device %s.\n",
+		kunit_skip(test, "Skipping non-discrete device %s.\n",
 			   dev_name(xe->drm.dev));
 		return 0;
 	}
@@ -345,12 +348,14 @@ static int evict_test_run_device(struct xe_device *xe)
 
 static void xe_bo_evict_kunit(struct kunit *test)
 {
-	xe_call_for_each_device(evict_test_run_device);
+	struct xe_device *xe = test->priv;
+
+	evict_test_run_device(xe);
 }
 
 static struct kunit_case xe_bo_tests[] = {
-	KUNIT_CASE(xe_ccs_migrate_kunit),
-	KUNIT_CASE(xe_bo_evict_kunit),
+	KUNIT_CASE_PARAM(xe_ccs_migrate_kunit, xe_pci_live_device_gen_param),
+	KUNIT_CASE_PARAM(xe_bo_evict_kunit, xe_pci_live_device_gen_param),
 	{}
 };
 
@@ -358,5 +363,6 @@ VISIBLE_IF_KUNIT
 struct kunit_suite xe_bo_test_suite = {
 	.name = "xe_bo",
 	.test_cases = xe_bo_tests,
+	.init = xe_kunit_helper_xe_device_live_test_init,
 };
 EXPORT_SYMBOL_IF_KUNIT(xe_bo_test_suite);
-- 
2.43.0


  parent reply	other threads:[~2024-07-17 19:52 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17 19:51 [PATCH v2 0/7] Convert live tests to parameterized style Michal Wajdeczko
2024-07-17 19:51 ` [PATCH v2 1/7] drm/xe: Introduce const cast helper Michal Wajdeczko
2024-07-17 20:07   ` Cavitt, Jonathan
2024-07-17 21:38     ` Michal Wajdeczko
2024-07-19 16:32   ` Lucas De Marchi
2024-07-19 16:55     ` Michal Wajdeczko
2024-07-19 17:06       ` Lucas De Marchi
2024-07-17 19:51 ` [PATCH v2 2/7] drm/xe/tests: Add helpers for use in live tests Michal Wajdeczko
2024-07-17 20:14   ` Cavitt, Jonathan
2024-07-19 16:37   ` Lucas De Marchi
2024-07-19 17:20     ` Michal Wajdeczko
2024-07-17 19:51 ` Michal Wajdeczko [this message]
2024-07-17 20:15   ` [PATCH v2 3/7] drm/xe/tests: Convert xe_bo " Cavitt, Jonathan
2024-07-17 19:51 ` [PATCH v2 4/7] drm/xe/tests: Convert xe_dma_buf " Michal Wajdeczko
2024-07-17 20:17   ` Cavitt, Jonathan
2024-07-17 21:54     ` Michal Wajdeczko
2024-07-17 19:51 ` [PATCH v2 5/7] drm/xe/tests: Convert xe_migrate " Michal Wajdeczko
2024-07-17 20:17   ` Cavitt, Jonathan
2024-07-17 19:51 ` [PATCH v2 6/7] drm/xe/tests: Convert xe_mocs " Michal Wajdeczko
2024-07-17 20:18   ` Cavitt, Jonathan
2024-07-19 16:40   ` Lucas De Marchi
2024-07-17 19:51 ` [PATCH v2 7/7] drm/xe/tests: Skip xe_mocs live tests on VF device Michal Wajdeczko
2024-07-17 20:19   ` Cavitt, Jonathan
2024-07-19 16:41   ` Lucas De Marchi
2024-07-17 19:58 ` ✓ CI.Patch_applied: success for Convert live tests to parameterized style (rev2) Patchwork
2024-07-17 19:59 ` ✓ CI.checkpatch: " Patchwork
2024-07-17 20:00 ` ✓ CI.KUnit: " Patchwork
2024-07-17 20:12 ` ✓ CI.Build: " Patchwork
2024-07-17 20:14 ` ✓ CI.Hooks: " Patchwork
2024-07-17 20:16 ` ✓ CI.checksparse: " Patchwork
2024-07-17 20:40 ` ✗ CI.BAT: failure " Patchwork
2024-07-17 21:34   ` Michal Wajdeczko
2024-07-18  1:53 ` ✗ CI.FULL: " Patchwork
2024-07-18  7:11   ` Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240717195155.442-4-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox