From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AF2DC3DA64 for ; Fri, 19 Jul 2024 20:29:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E22F110ECB2; Fri, 19 Jul 2024 20:29:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="H9tmKqZX"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7819610E16A for ; Fri, 19 Jul 2024 20:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721420959; x=1752956959; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TQxbifbPUrMs27/feskX89TfrxfZNinKPpC+db9f9qY=; b=H9tmKqZXm9KE6fxjW9bt4wnpF5JZzztIdwLAVdtULbcAUHrUJU0cWjqX G8UJ68ouopb52EA7oJfuQfOllweSXZKBthWuicnxEk7LHI+WI+KGcoi/a Wyyh5RE09sSqBm67NdURs8ZQhuiFJmaYNC1V9W7WC4rPmvarXLvRmrvB+ 2NLkJTBVqw3z8tO1WDJ3APsbCi3Qdv5sup5ujls8p2FI77ACqw8kZ0NWo PnuYdoRFUtQKD+5G8JSaDaykuTpkEKy4uv9S7AYEUQdGRGIL1jinNuJmk fWTZYgLBIdeJPuZfpt8UFfBmHXzFo5H42ZOIyeUJoZuiLSchudoQFwMZi w==; X-CSE-ConnectionGUID: UIclDvkdSjC63/k6/wnl8g== X-CSE-MsgGUID: DINOWIK1TA+nyz/YWchjIA== X-IronPort-AV: E=McAfee;i="6700,10204,11138"; a="18926121" X-IronPort-AV: E=Sophos;i="6.09,221,1716274800"; d="scan'208";a="18926121" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2024 13:29:19 -0700 X-CSE-ConnectionGUID: qkkUvEWwRhynJZChg/E3Tg== X-CSE-MsgGUID: kV8Yiq/zQASzNI0VO70jvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,221,1716274800"; d="scan'208";a="55412811" Received: from guc-pnp-dev-box-1.fm.intel.com ([10.1.27.7]) by fmviesa003.fm.intel.com with ESMTP; 19 Jul 2024 13:29:19 -0700 From: Zhanjun Dong To: intel-xe@lists.freedesktop.org Cc: Zhanjun Dong , Alan Previn , Michal Wajdeczko Subject: [PATCH v13 0/5] drm/xe/guc: Add GuC based register capture for error capture Date: Fri, 19 Jul 2024 13:29:12 -0700 Message-Id: <20240719202917.1590984-1-zhanjun.dong@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Port GuC based register capture for error capture from i915 to Xe. There are 3 parts inside: . Prepare for capture registers There is a bo create at guc ads init time, that is very early and engi ne map is not ready, make it hard to calculate the capture buffer size, new function created for worst case size caluation. Other than that, this part basically follows the i915 design. . Process capture notification message Basically follows i915 design . Sysfs command process. Xe switched to devcoredump, adopted command line process with captured node list. Signed-off-by: Zhanjun Dong Cc: Alan Previn Cc: Michal Wajdeczko Changes from prior revs: v13:- Move guc_mmio_reg structure define to guc_capture_abi.h Remove duplicated crash/debug/capture unit check Remove unnecessary guc_capture_data_extracted Update u32 align check in guc_capture_log_remove_bytes v12:- Rewrite guc log size init from runtime to compile time implementation. Change log buffer flush to file from structure bitfield to genmask. Change the capture log data copy from u32 copy to size copy There are 3 types of engine class refrenced in this series, hw engine class, GuC class and GuC capture class, update function parameter type to enum for easy to read. Update macro names to follow GuC interface specification. v11:- Fixed a bug of missing captured check on register snapshot pre-capture Fixed kernel-doc warnings v10:- Resync with updated job timed out follow Add pre-capture by read from hw engine if GuC capture data is not ready, the pre-captured data will be refereshed if GuC capture is ready at later time. Add xe_guc_capture_is_ready_for to check if GuC capture is ready for a job. Re-orgnize some header files to xe abi folder Reduce some meesage level from warn/info to debug Remove duplicated enum of GuC log type. v9:- Merged snapshot register list into capture register lists Optimized devcoredump timing to take snapshot after guc reset Add global and engine class registers into capture list Fixed bug of incorrect matching guc class id with guc capture class id v8:- Reorgnize the order of patches Change the capture size check from worst min size to worst size Replace the kernel alloc with drm managed alloc Replace the memcpy with xe_map_memcpy_from Free GuC capture outlist as part of xe_devcoredump_free v7:- Kconfig CONFIG_DRM_XE_CAPTURE_ERROR removed v6:- Change hardcoded register snapshot fill to follow mapping tables When capture is empty, take snapshot from engine v5:- Split dss helper code out as an standalone patch Remove old platform registers definition. Split register map table to 32 and 64bit each v4:- Move register map table to xe_hw_engine.c v3:- Remove condition compilation in code v2:- Split into multiple chunks Zhanjun Dong (5): drm/xe/guc: Prepare GuC register list and update ADS size for error capture drm/xe/guc: Add XE_LP steered register lists drm/xe/guc: Add capture size check in GuC log buffer drm/xe/guc: Extract GuC error capture lists drm/xe/guc: Plumb GuC-capture into dev coredump drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/abi/guc_actions_abi.h | 8 + drivers/gpu/drm/xe/abi/guc_capture_abi.h | 186 +++ drivers/gpu/drm/xe/abi/guc_log_abi.h | 72 + drivers/gpu/drm/xe/regs/xe_gt_regs.h | 2 + drivers/gpu/drm/xe/xe_devcoredump.c | 15 +- drivers/gpu/drm/xe/xe_devcoredump_types.h | 2 + drivers/gpu/drm/xe/xe_guc.c | 5 + drivers/gpu/drm/xe/xe_guc.h | 5 + drivers/gpu/drm/xe/xe_guc_ads.c | 151 +- drivers/gpu/drm/xe/xe_guc_ads_types.h | 2 + drivers/gpu/drm/xe/xe_guc_capture.c | 1630 +++++++++++++++++++++ drivers/gpu/drm/xe/xe_guc_capture.h | 68 + drivers/gpu/drm/xe/xe_guc_capture_types.h | 59 + drivers/gpu/drm/xe/xe_guc_ct.c | 2 + drivers/gpu/drm/xe/xe_guc_fwif.h | 26 +- drivers/gpu/drm/xe/xe_guc_log.c | 141 +- drivers/gpu/drm/xe/xe_guc_log.h | 12 +- drivers/gpu/drm/xe/xe_guc_log_types.h | 15 + drivers/gpu/drm/xe/xe_guc_submit.c | 86 +- drivers/gpu/drm/xe/xe_guc_submit.h | 2 + drivers/gpu/drm/xe/xe_guc_types.h | 2 + drivers/gpu/drm/xe/xe_hw_engine.c | 240 ++- drivers/gpu/drm/xe/xe_hw_engine.h | 2 + drivers/gpu/drm/xe/xe_hw_engine_types.h | 180 ++- drivers/gpu/drm/xe/xe_lrc.h | 1 + 26 files changed, 2712 insertions(+), 203 deletions(-) create mode 100644 drivers/gpu/drm/xe/abi/guc_capture_abi.h create mode 100644 drivers/gpu/drm/xe/abi/guc_log_abi.h create mode 100644 drivers/gpu/drm/xe/xe_guc_capture.c create mode 100644 drivers/gpu/drm/xe/xe_guc_capture.h create mode 100644 drivers/gpu/drm/xe/xe_guc_capture_types.h -- 2.34.1