From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Jonathan Cavitt <jonathan.cavitt@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH v3 3/7] drm/xe/tests: Convert xe_bo live tests
Date: Sat, 20 Jul 2024 16:25:24 +0200 [thread overview]
Message-ID: <20240720142528.530-4-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20240720142528.530-1-michal.wajdeczko@intel.com>
Convert xe_bo live tests to parameterized style.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
v2: simplify kunit_skip() messages
---
drivers/gpu/drm/xe/tests/xe_bo.c | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/tests/xe_bo.c b/drivers/gpu/drm/xe/tests/xe_bo.c
index e2e0ea24757a..1768483da1b7 100644
--- a/drivers/gpu/drm/xe/tests/xe_bo.c
+++ b/drivers/gpu/drm/xe/tests/xe_bo.c
@@ -6,6 +6,7 @@
#include <kunit/test.h>
#include <kunit/visibility.h>
+#include "tests/xe_kunit_helpers.h"
#include "tests/xe_pci_test.h"
#include "tests/xe_test.h"
@@ -158,13 +159,13 @@ static int ccs_test_run_device(struct xe_device *xe)
int id;
if (!xe_device_has_flat_ccs(xe)) {
- kunit_info(test, "Skipping non-flat-ccs device.\n");
+ kunit_skip(test, "non-flat-ccs device\n");
return 0;
}
/* For xe2+ dgfx, we don't handle ccs metadata */
if (GRAPHICS_VER(xe) >= 20 && IS_DGFX(xe)) {
- kunit_info(test, "Skipping on xe2+ dgfx device.\n");
+ kunit_skip(test, "xe2+ dgfx device\n");
return 0;
}
@@ -184,7 +185,9 @@ static int ccs_test_run_device(struct xe_device *xe)
static void xe_ccs_migrate_kunit(struct kunit *test)
{
- xe_call_for_each_device(ccs_test_run_device);
+ struct xe_device *xe = test->priv;
+
+ ccs_test_run_device(xe);
}
static int evict_test_run_tile(struct xe_device *xe, struct xe_tile *tile, struct kunit *test)
@@ -334,8 +337,7 @@ static int evict_test_run_device(struct xe_device *xe)
int id;
if (!IS_DGFX(xe)) {
- kunit_info(test, "Skipping non-discrete device %s.\n",
- dev_name(xe->drm.dev));
+ kunit_skip(test, "non-discrete device\n");
return 0;
}
@@ -351,12 +353,14 @@ static int evict_test_run_device(struct xe_device *xe)
static void xe_bo_evict_kunit(struct kunit *test)
{
- xe_call_for_each_device(evict_test_run_device);
+ struct xe_device *xe = test->priv;
+
+ evict_test_run_device(xe);
}
static struct kunit_case xe_bo_tests[] = {
- KUNIT_CASE(xe_ccs_migrate_kunit),
- KUNIT_CASE(xe_bo_evict_kunit),
+ KUNIT_CASE_PARAM(xe_ccs_migrate_kunit, xe_pci_live_device_gen_param),
+ KUNIT_CASE_PARAM(xe_bo_evict_kunit, xe_pci_live_device_gen_param),
{}
};
@@ -364,5 +368,6 @@ VISIBLE_IF_KUNIT
struct kunit_suite xe_bo_test_suite = {
.name = "xe_bo",
.test_cases = xe_bo_tests,
+ .init = xe_kunit_helper_xe_device_live_test_init,
};
EXPORT_SYMBOL_IF_KUNIT(xe_bo_test_suite);
--
2.43.0
next prev parent reply other threads:[~2024-07-20 14:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 14:25 [PATCH v3 0/7] Convert live tests to parameterized style Michal Wajdeczko
2024-07-20 14:25 ` [PATCH v3 1/7] drm/xe: Introduce const cast helper Michal Wajdeczko
2024-07-21 2:46 ` Lucas De Marchi
2024-07-20 14:25 ` [PATCH v3 2/7] drm/xe/tests: Add helpers for use in live tests Michal Wajdeczko
2024-07-20 14:25 ` Michal Wajdeczko [this message]
2024-07-20 14:25 ` [PATCH v3 4/7] drm/xe/tests: Convert xe_dma_buf " Michal Wajdeczko
2024-07-20 14:25 ` [PATCH v3 5/7] drm/xe/tests: Convert xe_migrate " Michal Wajdeczko
2024-07-20 14:25 ` [PATCH v3 6/7] drm/xe/tests: Convert xe_mocs " Michal Wajdeczko
2024-07-20 14:25 ` [PATCH v3 7/7] drm/xe/tests: Skip xe_mocs live tests on VF device Michal Wajdeczko
2024-07-20 14:31 ` ✓ CI.Patch_applied: success for Convert live tests to parameterized style (rev3) Patchwork
2024-07-20 14:31 ` ✓ CI.checkpatch: " Patchwork
2024-07-20 14:32 ` ✓ CI.KUnit: " Patchwork
2024-07-20 14:44 ` ✓ CI.Build: " Patchwork
2024-07-20 14:46 ` ✓ CI.Hooks: " Patchwork
2024-07-20 14:48 ` ✓ CI.checksparse: " Patchwork
2024-07-20 15:09 ` ✗ CI.BAT: failure " Patchwork
2024-07-22 9:58 ` Michal Wajdeczko
2024-07-20 16:13 ` ✗ CI.FULL: " Patchwork
2024-07-22 10:05 ` Michal Wajdeczko
2024-07-23 4:27 ` ✓ CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240720142528.530-4-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox