From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH] drm/xe: Assert G2H outstanding when releasing G2H
Date: Thu, 25 Jul 2024 16:18:01 -0700 [thread overview]
Message-ID: <20240725231801.1958038-1-matthew.brost@intel.com> (raw)
Ensure we are managing G2H credits correctly. Extra important now that
this is tied to PM.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_guc_ct.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 64afc90ad2c5..beeeb120d1fc 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -516,6 +516,7 @@ static void __g2h_release_space(struct xe_guc_ct *ct, u32 g2h_len)
lockdep_assert_held(&ct->fast_lock);
xe_gt_assert(ct_to_gt(ct), ct->ctbs.g2h.info.space + g2h_len <=
ct->ctbs.g2h.info.size - ct->ctbs.g2h.info.resv_space);
+ xe_gt_assert(ct_to_gt(ct), ct->g2h_outstanding);
ct->ctbs.g2h.info.space += g2h_len;
if (!--ct->g2h_outstanding)
--
2.34.1
next reply other threads:[~2024-07-25 23:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 23:18 Matthew Brost [this message]
2024-07-25 23:23 ` ✓ CI.Patch_applied: success for drm/xe: Assert G2H outstanding when releasing G2H Patchwork
2024-07-25 23:23 ` ✓ CI.checkpatch: " Patchwork
2024-07-25 23:24 ` ✓ CI.KUnit: " Patchwork
2024-07-25 23:36 ` ✓ CI.Build: " Patchwork
2024-07-25 23:39 ` ✓ CI.Hooks: " Patchwork
2024-07-25 23:40 ` ✓ CI.checksparse: " Patchwork
2024-07-26 0:03 ` ✓ CI.BAT: " Patchwork
2024-07-26 8:45 ` ✗ CI.FULL: failure " Patchwork
2024-07-26 12:36 ` [PATCH] " Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725231801.1958038-1-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox