Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH 00/11] Fix error paths in driver load
Date: Fri,  9 Aug 2024 18:55:33 -0700	[thread overview]
Message-ID: <20240810015544.3443258-1-matthew.brost@intel.com> (raw)

Combine a few series [1] [2] [3] plus some new patches to get driver
into working state.

The below test case passed on TGL:
for i in {1..19}; do echo "Run $i"; modprobe xe inject_driver_load_error=$i; rmmod xe; done

More error injection points should be added, likely 100s more. Posted to
likely hand off this work to a team member in a working state.

Matt

[1] https://patchwork.freedesktop.org/series/137113/
[2] https://patchwork.freedesktop.org/series/137112/
[3] https://patchwork.freedesktop.org/series/137111/

Daniele Ceraolo Spurio (3):
  drm/xe: use devm instead of drmm for managed bo
  drm/xe/uc: Use managed bo for HuC and GSC objects
  drm/xe/uc: Use devm to register cleanup that includes exec_queues

Matthew Brost (8):
  drm/xe: Fix tile fini sequence
  drm/xe: Add driver load error injection
  drm/xe: Move ggtt_fini to devm managed
  drm/xe: Set firmware state to loadable before registering guc_fini_hw
  drm/xe: Drop warn on xe_guc_pc_gucrc_disable in guc pc fini
  drm/xe: Move hw_engine_fini to devm managed
  drm/xe: Move HuC init before GuC init
  drm/xe: Update xe_sa to use xe_managed_bo_create_pin_map

 drivers/gpu/drm/xe/xe_bo.c           |  6 ++---
 drivers/gpu/drm/xe/xe_device.c       | 31 ++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_device.h       | 15 ++++++++++++
 drivers/gpu/drm/xe/xe_device_types.h |  4 ++++
 drivers/gpu/drm/xe/xe_ggtt.c         |  4 ++--
 drivers/gpu/drm/xe/xe_gsc.c          | 16 ++++---------
 drivers/gpu/drm/xe/xe_gsc_proxy.c    | 36 +++++-----------------------
 drivers/gpu/drm/xe/xe_gt.c           |  5 ++++
 drivers/gpu/drm/xe/xe_gt_sriov_pf.c  |  4 ++++
 drivers/gpu/drm/xe/xe_guc.c          | 12 ++++++++--
 drivers/gpu/drm/xe/xe_guc_ads.c      |  5 ++++
 drivers/gpu/drm/xe/xe_guc_ct.c       |  4 ++++
 drivers/gpu/drm/xe/xe_guc_log.c      |  5 ++++
 drivers/gpu/drm/xe/xe_guc_pc.c       |  2 +-
 drivers/gpu/drm/xe/xe_guc_submit.c   |  4 ++--
 drivers/gpu/drm/xe/xe_huc.c          | 19 ++++-----------
 drivers/gpu/drm/xe/xe_hw_engine.c    |  4 ++--
 drivers/gpu/drm/xe/xe_mmio.c         | 10 +++++++-
 drivers/gpu/drm/xe/xe_module.c       |  5 ++++
 drivers/gpu/drm/xe/xe_module.h       |  3 +++
 drivers/gpu/drm/xe/xe_pci.c          |  9 +++++++
 drivers/gpu/drm/xe/xe_pm.c           |  8 +++++++
 drivers/gpu/drm/xe/xe_sa.c           | 13 +++++-----
 drivers/gpu/drm/xe/xe_sa_types.h     |  1 +
 drivers/gpu/drm/xe/xe_sriov.c        |  8 ++++++-
 drivers/gpu/drm/xe/xe_tile.c         |  4 ++++
 drivers/gpu/drm/xe/xe_uc.c           | 12 ++++++----
 drivers/gpu/drm/xe/xe_wa.c           |  5 ++++
 drivers/gpu/drm/xe/xe_wopcm.c        |  4 ++++
 29 files changed, 178 insertions(+), 80 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-08-10  1:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-10  1:55 Matthew Brost [this message]
2024-08-10  1:55 ` [PATCH 01/11] drm/xe: use devm instead of drmm for managed bo Matthew Brost
2024-08-10  1:55 ` [PATCH 02/11] drm/xe/uc: Use managed bo for HuC and GSC objects Matthew Brost
2024-08-10  1:55 ` [PATCH 03/11] drm/xe/uc: Use devm to register cleanup that includes exec_queues Matthew Brost
2024-08-10  1:55 ` [PATCH 04/11] drm/xe: Fix tile fini sequence Matthew Brost
2024-08-10  1:55 ` [PATCH 05/11] drm/xe: Add driver load error injection Matthew Brost
2024-08-10  1:55 ` [PATCH 06/11] drm/xe: Move ggtt_fini to devm managed Matthew Brost
2024-08-10  1:55 ` [PATCH 07/11] drm/xe: Set firmware state to loadable before registering guc_fini_hw Matthew Brost
2024-08-10  1:55 ` [PATCH 08/11] drm/xe: Drop warn on xe_guc_pc_gucrc_disable in guc pc fini Matthew Brost
2024-08-10  1:55 ` [PATCH 09/11] drm/xe: Move hw_engine_fini to devm managed Matthew Brost
2024-08-10  1:55 ` [PATCH 10/11] drm/xe: Move HuC init before GuC init Matthew Brost
2024-08-10  1:55 ` [PATCH 11/11] drm/xe: Update xe_sa to use xe_managed_bo_create_pin_map Matthew Brost
2024-08-10  2:01 ` ✓ CI.Patch_applied: success for Fix error paths in driver load Patchwork
2024-08-10  2:01 ` ✗ CI.checkpatch: warning " Patchwork
2024-08-10  2:01 ` ✗ CI.KUnit: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240810015544.3443258-1-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox