From: Andrew Morton <akpm@linux-foundation.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
akinobu.mita@gmail.com, lucas.demarchi@intel.com,
rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com,
robdclark@gmail.com, quic_abhinavk@quicinc.com,
dmitry.baryshkov@linaro.org
Subject: Re: [PATCH 1/3] fault-inject: improve build for CONFIG_FAULT_INJECTION=n
Date: Wed, 14 Aug 2024 12:12:20 -0700 [thread overview]
Message-ID: <20240814121220.adcbbc0db20c6821a05da11e@linux-foundation.org> (raw)
In-Reply-To: <87cymbzj50.fsf@intel.com>
On Wed, 14 Aug 2024 09:57:31 +0300 Jani Nikula <jani.nikula@intel.com> wrote:
> > Removing a nested include exposes all those sites which were
> > erroneously depending upon that nested include. Here's what I have
> > found so far, there will be more.
>
> Right. I didn't hit them with the configs I tried... though I wonder why
> not, especially lib/fault-inject.c puzzles me.
>
> How do you want to proceed? Arguably uncovering and fixing those places
> is good, but that's kind of an unintended consequence here.
Is OK, it's a good change. I fixed everything which my usual build
testing covers. Other things will be reported and I'll fix those also.
If you have time to eyeball the 36 files which include fault-inject.h
then that would help things along.
prev parent reply other threads:[~2024-08-14 19:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 12:12 [PATCH 1/3] fault-inject: improve build for CONFIG_FAULT_INJECTION=n Jani Nikula
2024-08-13 12:12 ` [PATCH 2/3] drm/msm: clean up fault injection usage Jani Nikula
2024-08-13 12:30 ` Thomas Hellström
2024-08-13 12:54 ` Ghimiray, Himal Prasad
2024-08-14 23:38 ` Abhinav Kumar
2024-08-13 12:12 ` [PATCH 3/3] drm/xe: " Jani Nikula
2024-08-13 12:32 ` Thomas Hellström
2024-08-13 12:50 ` Ghimiray, Himal Prasad
2024-08-13 12:19 ` ✓ CI.Patch_applied: success for series starting with [1/3] fault-inject: improve build for CONFIG_FAULT_INJECTION=n Patchwork
2024-08-13 12:19 ` ✗ CI.checkpatch: warning " Patchwork
2024-08-13 12:20 ` ✓ CI.KUnit: success " Patchwork
2024-08-13 12:24 ` ✗ CI.Build: failure " Patchwork
2024-08-13 12:55 ` [PATCH 1/3] " Ghimiray, Himal Prasad
2024-08-14 2:24 ` Andrew Morton
2024-08-14 6:57 ` Jani Nikula
2024-08-14 19:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814121220.adcbbc0db20c6821a05da11e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akinobu.mita@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox