Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH] drm/xe: Use for_each_remote_tile rather than manual check
Date: Thu, 15 Aug 2024 21:02:08 -0700	[thread overview]
Message-ID: <20240816040208.62695-1-matthew.brost@intel.com> (raw)

Replace for_each_tile plus a check against primary tile with
for_each_remote_tile in tiles_fini. The latter macro does this for us.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_mmio.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
index f5bdb540e823..3fd462fda625 100644
--- a/drivers/gpu/drm/xe/xe_mmio.c
+++ b/drivers/gpu/drm/xe/xe_mmio.c
@@ -29,9 +29,8 @@ static void tiles_fini(void *arg)
 	struct xe_tile *tile;
 	int id;
 
-	for_each_tile(tile, xe, id)
-		if (tile != xe_device_get_root_tile(xe))
-			tile->mmio.regs = NULL;
+	for_each_remote_tile(tile, xe, id)
+		tile->mmio.regs = NULL;
 }
 
 /*
-- 
2.34.1


             reply	other threads:[~2024-08-16  4:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16  4:02 Matthew Brost [this message]
2024-08-16  5:06 ` [PATCH] drm/xe: Use for_each_remote_tile rather than manual check Lucas De Marchi
2024-08-16 16:33   ` Lucas De Marchi
2024-08-16  5:17 ` ✓ CI.Patch_applied: success for " Patchwork
2024-08-16  5:17 ` ✓ CI.checkpatch: " Patchwork
2024-08-16  5:24 ` ✓ CI.KUnit: " Patchwork
2024-08-16  5:36 ` ✓ CI.Build: " Patchwork
2024-08-16  5:39 ` ✓ CI.Hooks: " Patchwork
2024-08-16  5:40 ` ✓ CI.checksparse: " Patchwork
2024-08-16  6:28 ` ✓ CI.BAT: " Patchwork
2024-08-16 12:11 ` ✗ CI.FULL: failure " Patchwork
2024-08-16 16:09 ` [PATCH] " Ghimiray, Himal Prasad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240816040208.62695-1-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox