From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F12AC531DC for ; Fri, 16 Aug 2024 16:33:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE8E310E5A4; Fri, 16 Aug 2024 16:33:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="j20fgbmu"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id D056D10E803; Fri, 16 Aug 2024 16:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723825987; x=1755361987; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oZtexGhi4TnH2641/34zp9aOjrFej0bloZ/pNOMLwuc=; b=j20fgbmui9phfmkxq79sx1sYsDFLUsV+psNNEnQ34BkfKIvrqqC21/hf noGhcWANuoIa8mAHEh1BndtGAswO+ZT5jaK88X6uBZmADvuPrWsZpCAiz hJ3qQ3G2GiW8egT5uVZTyapN6KGPtTRe2PDmGaxL3FbAz5Kfc8/tONd0F cf9pBJWqh2oGoG8NRyI1ZGZ2G8IEWjOnBg7locbSNKrnMQoZpHSilI9c2 TMmUhDsWnF+bVp+RO21IgFg/PVV19ogfnvfL999hFrMgj7xW4/jouMlbS y7M+8L4GvS9mqVBnonsbzkSZoELMN9mQH5QKO/HFs047fnvxgRrE2yqxl w==; X-CSE-ConnectionGUID: WN0Z+MqIR8WeyPX7GgNjPQ== X-CSE-MsgGUID: WckfxtCLStqhN8TabGDUfA== X-IronPort-AV: E=McAfee;i="6700,10204,11166"; a="39582281" X-IronPort-AV: E=Sophos;i="6.10,152,1719903600"; d="scan'208";a="39582281" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2024 09:33:07 -0700 X-CSE-ConnectionGUID: 18Wy2WDETDOWRvFU/LjP8g== X-CSE-MsgGUID: g5WNZOI/Q3auuuF9Bus3ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,152,1719903600"; d="scan'208";a="60001779" Received: from lkp-server01.sh.intel.com (HELO 9a732dc145d3) ([10.239.97.150]) by orviesa006.jf.intel.com with ESMTP; 16 Aug 2024 09:33:05 -0700 Received: from kbuild by 9a732dc145d3 with local (Exim 4.96) (envelope-from ) id 1sezss-0006e8-0f; Fri, 16 Aug 2024 16:33:02 +0000 Date: Sat, 17 Aug 2024 00:32:19 +0800 From: kernel test robot To: Thomas =?iso-8859-1?Q?Hellstr=F6m?= , intel-xe@lists.freedesktop.org Cc: oe-kbuild-all@lists.linux.dev, Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Christian =?iso-8859-1?Q?K=F6nig?= , Somalapuram Amaranath , Matthew Brost , dri-devel@lists.freedesktop.org, Paulo Zanoni Subject: Re: [PATCH v8 3/6] drm/ttm: Use fault-injection to test error paths Message-ID: <202408170041.l5SO7IpQ-lkp@intel.com> References: <20240816133717.3102-4-thomas.hellstrom@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240816133717.3102-4-thomas.hellstrom@linux.intel.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on next-20240816] [also build test ERROR on v6.11-rc3] [cannot apply to drm-xe/drm-xe-next linus/master v6.11-rc3 v6.11-rc2 v6.11-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-ttm-Add-a-virtual-base-class-for-graphics-memory-backup/20240816-213947 base: next-20240816 patch link: https://lore.kernel.org/r/20240816133717.3102-4-thomas.hellstrom%40linux.intel.com patch subject: [PATCH v8 3/6] drm/ttm: Use fault-injection to test error paths config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20240817/202408170041.l5SO7IpQ-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240817/202408170041.l5SO7IpQ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202408170041.l5SO7IpQ-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/gpu/drm/ttm/ttm_pool.c: In function 'ttm_pool_restore_tt': >> drivers/gpu/drm/ttm/ttm_pool.c:456:29: error: implicit declaration of function 'should_fail'; did you mean 'schedule_tail'? [-Werror=implicit-function-declaration] 456 | should_fail(&backup_fault_inject, 1)) { | ^~~~~~~~~~~ | schedule_tail >> drivers/gpu/drm/ttm/ttm_pool.c:456:42: error: 'backup_fault_inject' undeclared (first use in this function) 456 | should_fail(&backup_fault_inject, 1)) { | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/ttm/ttm_pool.c:456:42: note: each undeclared identifier is reported only once for each function it appears in drivers/gpu/drm/ttm/ttm_pool.c: In function 'ttm_pool_backup_tt': drivers/gpu/drm/ttm/ttm_pool.c:908:64: error: 'backup_fault_inject' undeclared (first use in this function) 908 | if (IS_ENABLED(CONFIG_FAULT_INJECTION) && should_fail(&backup_fault_inject, 1)) | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +456 drivers/gpu/drm/ttm/ttm_pool.c 434 435 static int ttm_pool_restore_tt(struct ttm_pool_tt_restore *restore, 436 struct ttm_backup *backup, 437 struct ttm_operation_ctx *ctx) 438 { 439 static unsigned long __maybe_unused swappedin; 440 unsigned int i, nr = 1 << restore->order; 441 int ret = 0; 442 443 if (!ttm_pool_restore_valid(restore)) 444 return 0; 445 446 for (i = restore->restored_pages; i < nr; ++i) { 447 struct page *p = restore->old_pages[i]; 448 449 if (ttm_backup_page_ptr_is_handle(p)) { 450 unsigned long handle = ttm_backup_page_ptr_to_handle(p); 451 452 if (handle == 0) 453 continue; 454 455 if (IS_ENABLED(CONFIG_FAULT_INJECTION) && ctx->interruptible && > 456 should_fail(&backup_fault_inject, 1)) { 457 ret = -EINTR; 458 break; 459 } 460 461 ret = backup->ops->copy_backed_up_page 462 (backup, restore->first_page[i], 463 handle, ctx->interruptible); 464 if (ret) 465 break; 466 467 backup->ops->drop(backup, handle); 468 } else if (p) { 469 /* 470 * We could probably avoid splitting the old page 471 * using clever logic, but ATM we don't care. 472 */ 473 ttm_pool_split_for_swap(restore->pool, p); 474 copy_highpage(restore->first_page[i], p); 475 __free_pages(p, 0); 476 } 477 478 restore->restored_pages++; 479 restore->old_pages[i] = NULL; 480 cond_resched(); 481 } 482 483 return ret; 484 } 485 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki