From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E024C5321E for ; Sun, 18 Aug 2024 20:19:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 053C710E185; Sun, 18 Aug 2024 20:19:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mI5yFZ8n"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FA0D10E177; Sun, 18 Aug 2024 20:19:53 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4790C1BA; Sun, 18 Aug 2024 22:18:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1724012331; bh=XhKYTILEYLK5hnZgppdmA00tGDJpmsrwPWsR1GIB2Eo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mI5yFZ8nFKdsDUiEJZahI6u8wiKP2UIAgdEmzTJXIciTkRnaNfCUQOrd9UBoEE31i 981U6V0Y5Jb4BsZMlfaa3RRaLJPhqBNqAyH6no6rsoy+U4WMqOOTv/uiV4Ewp2rTgg br97kp4zVYJdpiPSQKTX+9oLwDH4eyduFcQXSmyM= Date: Sun, 18 Aug 2024 23:19:25 +0300 From: Laurent Pinchart To: Thomas Zimmermann Cc: daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com, javierm@redhat.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Tomi Valkeinen , Michal Simek Subject: Re: [PATCH 48/86] drm/xlnx: Run DRM default client setup Message-ID: <20240818201925.GI29465@pendragon.ideasonboard.com> References: <20240816125408.310253-1-tzimmermann@suse.de> <20240816125408.310253-49-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240816125408.310253-49-tzimmermann@suse.de> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hi Thomas, Thank you for the patch. On Fri, Aug 16, 2024 at 02:23:14PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Tomi Valkeinen > Cc: Michal Simek > --- > drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c > index bd1368df7870..f26b119322d5 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -402,6 +403,7 @@ static const struct drm_driver zynqmp_dpsub_drm_driver = { > DRIVER_ATOMIC, > > DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create), > + DRM_FBDEV_DMA_DRIVER_OPS, > > .fops = &zynqmp_dpsub_drm_fops, > > @@ -523,7 +525,7 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub) > goto err_poll_fini; > > /* Initialize fbdev generic emulation. */ > - drm_fbdev_dma_setup(drm, 24); > + drm_client_setup(drm, drm_format_info(DRM_FORMAT_RGB888)); I know this would be a hassle to change, but do the majority of the callers of drm_client_setup() have a drm_format_info * already, or do they need to call drm_format_info() on a 4CC ? In the latter case, would it be better to pass the 4CC to drm_client_setup() ? As far as this patch goes, Reviewed-by: Laurent Pinchart > > return 0; > -- Regards, Laurent Pinchart