Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: apoorva.singh@intel.com
To: intel-xe@lists.freedesktop.org
Cc: Apoorva Singh <apoorva.singh@intel.com>
Subject: [PATCH 1/1] drm/xe: Add NULL check before dereferencing pointer lrc->bo in xe_lrc_snapshot_capture()
Date: Tue, 20 Aug 2024 14:24:54 +0530	[thread overview]
Message-ID: <20240820085454.976636-2-apoorva.singh@intel.com> (raw)
In-Reply-To: <20240820085454.976636-1-apoorva.singh@intel.com>

From: Apoorva Singh <apoorva.singh@intel.com>

Add NULL check before deferencing of lrc->bo in
xe_lrc_snapshot_capture().

Free the dynamically allocated memory for snapshot
to avoid memory leak.

Signed-off-by: Apoorva Singh <apoorva.singh@intel.com>
---
 drivers/gpu/drm/xe/xe_lrc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
index 974a9cd8c379..8ab1af4b4057 100644
--- a/drivers/gpu/drm/xe/xe_lrc.c
+++ b/drivers/gpu/drm/xe/xe_lrc.c
@@ -1649,7 +1649,12 @@ struct xe_lrc_snapshot *xe_lrc_snapshot_capture(struct xe_lrc *lrc)
 	if (!snapshot)
 		return NULL;
 
-	if (lrc->bo && lrc->bo->vm)
+	if (!lrc->bo) {
+		kfree(snapshot);
+		return NULL;
+	}
+
+	if (lrc->bo->vm)
 		xe_vm_get(lrc->bo->vm);
 
 	snapshot->context_desc = xe_lrc_ggtt_addr(lrc);
-- 
2.34.1


  reply	other threads:[~2024-08-20  8:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20  8:54 [PATCH 0/1] drm/xe: Add NULL check before deferencing pointer apoorva.singh
2024-08-20  8:54 ` apoorva.singh [this message]
2024-08-20  9:38 ` ✓ CI.Patch_applied: success for drm/xe: Add NULL check before deferencing pointer (rev3) Patchwork
2024-08-20  9:38 ` ✓ CI.checkpatch: " Patchwork
2024-08-20  9:39 ` ✓ CI.KUnit: " Patchwork
2024-08-20  9:52 ` ✓ CI.Build: " Patchwork
2024-08-20  9:56 ` ✓ CI.Hooks: " Patchwork
2024-08-20  9:58 ` ✓ CI.checksparse: " Patchwork
2024-08-20 10:18 ` ✓ CI.BAT: " Patchwork
2024-08-20 15:11 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240820085454.976636-2-apoorva.singh@intel.com \
    --to=apoorva.singh@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox