Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, imre.deak@intel.com,
	arun.r.murthy@intel.com, rodrigo.vivi@intel.com,
	uma.shankar@intel.com, ville.syrala@intel.com
Subject: [PATCH v3 1/3] drm/xe: Suspend/resume user access only during system s/r
Date: Tue, 20 Aug 2024 20:14:06 +0300	[thread overview]
Message-ID: <20240820171408.192309-2-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20240820171408.192309-1-vinod.govindapillai@intel.com>

From: Imre Deak <imre.deak@intel.com>

Enable/Disable user access only during system suspend/resume.
This should not happen during runtime s/r

Signed-off-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/xe/display/xe_display.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 30dfdac9f6fa..ad7fc5137b42 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -323,7 +323,8 @@ void xe_display_pm_suspend(struct xe_device *xe, bool runtime)
 	intel_fbdev_set_suspend(&xe->drm, FBINFO_STATE_SUSPENDED, true);
 	if (has_display(xe)) {
 		drm_kms_helper_poll_disable(&xe->drm);
-		intel_display_driver_disable_user_access(xe);
+		if (!runtime)
+			intel_display_driver_disable_user_access(xe);
 	}
 
 	if (!runtime)
@@ -335,7 +336,7 @@ void xe_display_pm_suspend(struct xe_device *xe, bool runtime)
 
 	intel_hpd_cancel_work(xe);
 
-	if (has_display(xe))
+	if (!runtime && has_display(xe))
 		intel_display_driver_suspend_access(xe);
 
 	intel_encoder_suspend_all(&xe->display);
@@ -381,7 +382,7 @@ void xe_display_pm_resume(struct xe_device *xe, bool runtime)
 	intel_display_driver_init_hw(xe);
 	intel_hpd_init(xe);
 
-	if (has_display(xe))
+	if (!runtime && has_display(xe))
 		intel_display_driver_resume_access(xe);
 
 	/* MST sideband requires HPD interrupts enabled */
@@ -391,7 +392,8 @@ void xe_display_pm_resume(struct xe_device *xe, bool runtime)
 
 	if (has_display(xe)) {
 		drm_kms_helper_poll_enable(&xe->drm);
-		intel_display_driver_enable_user_access(xe);
+		if (!runtime)
+			intel_display_driver_enable_user_access(xe);
 	}
 	intel_hpd_poll_disable(xe);
 
-- 
2.34.1


  reply	other threads:[~2024-08-20 17:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20 17:14 [PATCH v3 0/3] handle HPD polling on display pm runtime s/r Vinod Govindapillai
2024-08-20 17:14 ` Vinod Govindapillai [this message]
2024-08-23  4:46   ` [PATCH v3 1/3] drm/xe: Suspend/resume user access only during system s/r Murthy, Arun R
2024-08-20 17:14 ` [PATCH v3 2/3] drm/xe: Handle polling only for system s/r in xe_display_pm_suspend/resume() Vinod Govindapillai
2024-08-23  5:30   ` Murthy, Arun R
2024-08-23  7:07     ` Govindapillai, Vinod
2024-08-23  8:43       ` Murthy, Arun R
2024-08-23  9:08         ` Govindapillai, Vinod
2024-08-23  9:15           ` Govindapillai, Vinod
2024-08-23  9:34           ` Murthy, Arun R
2024-08-23 12:51         ` Imre Deak
2024-08-20 17:14 ` [PATCH v3 3/3] drm/xe/display: handle HPD polling in display runtime suspend/resume Vinod Govindapillai
2024-08-23  5:30   ` Murthy, Arun R
2024-08-20 18:25 ` ✓ CI.Patch_applied: success for handle HPD polling on display pm runtime s/r Patchwork
2024-08-20 18:25 ` ✓ CI.checkpatch: " Patchwork
2024-08-20 18:26 ` ✓ CI.KUnit: " Patchwork
2024-08-20 18:38 ` ✓ CI.Build: " Patchwork
2024-08-20 18:40 ` ✓ CI.Hooks: " Patchwork
2024-08-20 18:41 ` ✓ CI.checksparse: " Patchwork
2024-08-20 19:02 ` ✓ CI.BAT: " Patchwork
2024-08-21  0:16 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240820171408.192309-2-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox