Re: [PATCH 04/10] drm/xe/step: define more steppings E-J

[Matt Roper <matthew.d.roper@intel.com>]

On Tue, Aug 20, 2024 at 10:00:37PM +0300, Jani Nikula wrote:
> These are primarily needed for compat reasons with display code in
> upcoming changes. There's no harm in having them.
> 
> While at it, add a comment about the requirement to match against GMD ID
> value spacing.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_step_types.h | 29 ++++++++++++++++++++++++++++-
>  1 file changed, 28 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_step_types.h b/drivers/gpu/drm/xe/xe_step_types.h
> index ccc9b4795e95..95b38d2d6c50 100644
> --- a/drivers/gpu/drm/xe/xe_step_types.h
> +++ b/drivers/gpu/drm/xe/xe_step_types.h
> @@ -17,6 +17,10 @@ struct xe_step_info {
>  
>  #define STEP_ENUM_VAL(name)  STEP_##name,
>  
> +/*
> + * Always define four minor steppings 0-3 for each stepping to match GMD ID
> + * spacing of values. See xe_step_gmdid_get().
> + */
>  #define STEP_NAME_LIST(func)		\
>  	func(A0)			\
>  	func(A1)			\
> @@ -34,7 +38,30 @@ struct xe_step_info {
>  	func(D1)			\
>  	func(D2)			\
>  	func(D3)			\
> -	func(E0)
> +	func(E0)			\
> +	func(E1)			\
> +	func(E2)			\
> +	func(E3)			\
> +	func(F0)			\
> +	func(F1)			\
> +	func(F2)			\
> +	func(F3)			\
> +	func(G0)			\
> +	func(G1)			\
> +	func(G2)			\
> +	func(G3)			\
> +	func(H0)			\
> +	func(H1)			\
> +	func(H2)			\
> +	func(H3)			\
> +	func(I0)			\
> +	func(I1)			\
> +	func(I2)			\
> +	func(I3)			\
> +	func(J0)			\
> +	func(J1)			\
> +	func(J2)			\
> +	func(J3)
>  
>  /*
>   * Symbolic steppings that do not match the hardware. These are valid both as gt
> -- 
> 2.39.2
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation