From: Ilia Levi <ilia.levi@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: ilia.levi@intel.com, michal.wajdeczko@intel.com,
niranjana.vishwanathapura@intel.com, koby.elbaz@intel.com,
yaron.avizrat@intel.com
Subject: [PATCH 5/5] drm/xe: separate memirq reset/postinstall from vf
Date: Thu, 22 Aug 2024 16:08:15 +0300 [thread overview]
Message-ID: <20240822130815.1355437-6-ilia.levi@intel.com> (raw)
In-Reply-To: <20240822130815.1355437-1-ilia.levi@intel.com>
Up until now only VF used Memory Based Interrupts (memirq).
Moving reset/postinstall flows out of VF to cater for other usages.
Signed-off-by: Ilia Levi <ilia.levi@intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 2 +-
drivers/gpu/drm/xe/xe_device.h | 6 ++++++
drivers/gpu/drm/xe/xe_irq.c | 36 +++++++++++++++++++---------------
3 files changed, 27 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index c4f8bfd08b09..a23fb0c81ca6 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -660,7 +660,7 @@ int xe_device_probe(struct xe_device *xe)
err = xe_ggtt_init_early(tile->mem.ggtt);
if (err)
return err;
- if (IS_SRIOV_VF(xe)) {
+ if (xe_device_needs_memirq(xe)) {
err = xe_memirq_init(&tile->memirq, false);
if (err)
return err;
diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
index f052c06a2d2f..4ba07617084c 100644
--- a/drivers/gpu/drm/xe/xe_device.h
+++ b/drivers/gpu/drm/xe/xe_device.h
@@ -9,6 +9,7 @@
#include <drm/drm_util.h>
#include "xe_device_types.h"
+#include "xe_sriov.h"
static inline struct xe_device *to_xe_device(const struct drm_device *dev)
{
@@ -154,6 +155,11 @@ static inline bool xe_device_has_memirq(struct xe_device *xe)
return GRAPHICS_VERx100(xe) >= 1250;
}
+static inline bool xe_device_needs_memirq(struct xe_device *xe)
+{
+ return IS_SRIOV_VF(xe) && xe_device_has_memirq(xe);
+}
+
u32 xe_device_ccs_bytes(struct xe_device *xe, u64 size);
void xe_device_snapshot_print(struct xe_device *xe, struct drm_printer *p);
diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index 18a5272d9bb0..a080d4869b16 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -559,17 +559,15 @@ static void vf_irq_reset(struct xe_device *xe)
xe_assert(xe, IS_SRIOV_VF(xe));
- if (GRAPHICS_VERx100(xe) < 1210)
- xelp_intr_disable(xe);
- else
+ if (GRAPHICS_VERx100(xe) >= 1210) {
xe_assert(xe, xe_device_has_memirq(xe));
-
- for_each_tile(tile, xe, id) {
- if (xe_device_has_memirq(xe))
- xe_memirq_reset(&tile->memirq);
- else
- gt_irq_reset(tile);
+ return;
}
+
+ xelp_intr_disable(xe);
+
+ for_each_tile(tile, xe, id)
+ gt_irq_reset(tile);
}
static void xe_irq_reset(struct xe_device *xe)
@@ -577,6 +575,11 @@ static void xe_irq_reset(struct xe_device *xe)
struct xe_tile *tile;
u8 id;
+ if (xe_device_needs_memirq(xe)) {
+ for_each_tile(tile, xe, id)
+ xe_memirq_reset(&tile->memirq);
+ }
+
if (IS_SRIOV_VF(xe))
return vf_irq_reset(xe);
@@ -604,13 +607,6 @@ static void xe_irq_reset(struct xe_device *xe)
static void vf_irq_postinstall(struct xe_device *xe)
{
- struct xe_tile *tile;
- unsigned int id;
-
- for_each_tile(tile, xe, id)
- if (xe_device_has_memirq(xe))
- xe_memirq_postinstall(&tile->memirq);
-
if (GRAPHICS_VERx100(xe) < 1210)
xelp_intr_enable(xe, true);
else
@@ -619,6 +615,14 @@ static void vf_irq_postinstall(struct xe_device *xe)
static void xe_irq_postinstall(struct xe_device *xe)
{
+ struct xe_tile *tile;
+ unsigned int id;
+
+ if (xe_device_needs_memirq(xe)) {
+ for_each_tile(tile, xe, id)
+ xe_memirq_postinstall(&tile->memirq);
+ }
+
if (IS_SRIOV_VF(xe))
return vf_irq_postinstall(xe);
--
2.43.2
next prev parent reply other threads:[~2024-08-22 13:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 13:08 [PATCH 0/5] memirq infra changes Ilia Levi
2024-08-22 13:08 ` [PATCH 1/5] drm/xe: move memirq out of vf Ilia Levi
2024-08-22 14:39 ` Cavitt, Jonathan
2024-08-26 11:59 ` Ilia Levi
2024-08-22 13:08 ` [PATCH 2/5] drm/xe: memirq infra changes for msix Ilia Levi
2024-08-22 15:05 ` Cavitt, Jonathan
2024-08-26 12:22 ` Ilia Levi
2024-08-26 14:40 ` Cavitt, Jonathan
2024-08-22 13:08 ` [PATCH 3/5] drm/xe: add memirq offsets for engine instance 0 to hw engine properties Ilia Levi
2024-08-22 15:42 ` Cavitt, Jonathan
2024-08-26 13:31 ` Ilia Levi
2024-08-26 15:06 ` Cavitt, Jonathan
2024-08-22 13:08 ` [PATCH 4/5] drm/xe: memirq handler changes Ilia Levi
2024-08-22 15:47 ` Cavitt, Jonathan
2024-08-22 13:08 ` Ilia Levi [this message]
2024-08-22 16:09 ` [PATCH 5/5] drm/xe: separate memirq reset/postinstall from vf Cavitt, Jonathan
2024-08-22 13:13 ` ✓ CI.Patch_applied: success for memirq infra changes Patchwork
2024-08-22 13:14 ` ✓ CI.checkpatch: " Patchwork
2024-08-22 13:15 ` ✓ CI.KUnit: " Patchwork
2024-08-22 13:31 ` ✓ CI.Build: " Patchwork
2024-08-22 13:35 ` ✓ CI.Hooks: " Patchwork
2024-08-22 13:37 ` ✓ CI.checksparse: " Patchwork
2024-08-22 13:58 ` ✓ CI.BAT: " Patchwork
2024-08-22 17:19 ` ✗ CI.FULL: failure " Patchwork
2024-08-28 7:56 ` ✗ CI.Patch_applied: failure for memirq infra changes (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822130815.1355437-6-ilia.levi@intel.com \
--to=ilia.levi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=koby.elbaz@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=niranjana.vishwanathapura@intel.com \
--cc=yaron.avizrat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox