From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C762C5321D for ; Fri, 23 Aug 2024 20:08:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0098010E820; Fri, 23 Aug 2024 20:08:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=ravnborg.org header.i=@ravnborg.org header.b="X7XP8gy/"; dkim=permerror (0-bit key) header.d=ravnborg.org header.i=@ravnborg.org header.b="y55+jh3Y"; dkim-atps=neutral X-Greylist: delayed 4502 seconds by postgrey-1.36 at gabe; Fri, 23 Aug 2024 20:08:02 UTC Received: from mailrelay3-1.pub.mailoutpod2-cph3.one.com (mailrelay3-1.pub.mailoutpod2-cph3.one.com [46.30.211.178]) by gabe.freedesktop.org (Postfix) with ESMTPS id ABA3210E34C for ; Fri, 23 Aug 2024 20:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Ing5y83DLTTn55EUMYXnCv9ZY7skLyZoKcixFqXqMdE=; b=X7XP8gy/Yr5lGcX7PR2qYFaVQ26E2VGlzwA4HBnaIWWhZhdVHcXkad68vJoyrylZJcaUIUsd2QgxL qEyR+NsYNqBVPGZFPaLHF8Re+/Xk0jYwI7CG2+/UW5E/XGKp1Vwaqi49nHdPgvIqeLabXfFXG+RpgV OARvVQMNFSMBRSLpSVoXhMxjZ0CtO8lAWLEl3CEfS0CY+/54HhQZ1iPhSHL3BQEEBaE28Q6Muq5jq0 nPZ5Tnr/EVHocYzcQr0k/YN42woRdYmxYaZUlsVcF+UFD6NSwf9ZtPCyK/YJuatTg8gUrJRqKlXZLM gU1WpcGzVsK1N9slC2//0oXluPL+4Nw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Ing5y83DLTTn55EUMYXnCv9ZY7skLyZoKcixFqXqMdE=; b=y55+jh3YqafrHodzYngAwX+sOueuibBwiDJR2M3qeAUXxIbeQjgBxITU4jyQoPR/TVelc0jULhlMb kiBh3hHBw== X-HalOne-ID: c52ed93c-6180-11ef-b761-dd3f8b2e2fd4 Received: from ravnborg.org (2-105-16-150-cable.dk.customer.tdc.net [2.105.16.150]) by mailrelay3.pub.mailoutpod2-cph3.one.com (Halon) with ESMTPSA id c52ed93c-6180-11ef-b761-dd3f8b2e2fd4; Fri, 23 Aug 2024 18:51:57 +0000 (UTC) Date: Fri, 23 Aug 2024 20:51:56 +0200 From: Sam Ravnborg To: Thomas Zimmermann Cc: daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com, javierm@redhat.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Subject: Re: [PATCH v2 11/86] drm/atmel-hdlcd: Run DRM default client setup Message-ID: <20240823185156.GA367392@ravnborg.org> References: <20240821130348.73038-1-tzimmermann@suse.de> <20240821130348.73038-12-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240821130348.73038-12-tzimmermann@suse.de> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, Aug 21, 2024 at 02:59:08PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup_with_fourcc() to run the kernel's default client > setup for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > v2: > - use drm_client_setup_with_fourcc() > > Signed-off-by: Thomas Zimmermann > Cc: Sam Ravnborg > Cc: Boris Brezillon > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Claudiu Beznea Hi Thomas. > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > index 9ce429f889ca..ca5bde8ac300 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -18,8 +18,10 @@ > > #include > #include > +#include > #include > #include > +#include > #include > #include > #include > @@ -865,7 +867,7 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev) > if (ret) > goto err_unload; > > - drm_fbdev_dma_setup(ddev, 24); > + drm_client_setup_with_fourcc(ddev, DRM_FORMAT_RGB888); > > return 0; I looks like a patch is missing to add DRM_FBDEV_DMA_DRIVER_OPS to struct drm_driver? Sam