Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: Intel-Xe@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>,
	Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH v6 1/9] drm/xe/guc: Remove spurious line feed in debug print
Date: Thu, 29 Aug 2024 23:23:02 -0700	[thread overview]
Message-ID: <20240830062310.3450387-2-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20240830062310.3450387-1-John.C.Harrison@Intel.com>

From: John Harrison <John.C.Harrison@Intel.com>

Including line feeds at the start of a debug print messes up the
output when sent to dmesg. The break appears between all the useful
prefix information and the actual string being printed. In this case,
each block of data has a very clear start line and an extra delimeter
is really not necessary. So don't do it.

v2: Fix typo in commit message (review feedback from Michal W.)

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index f24dd5223926..83046a5fbac9 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -1523,7 +1523,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot,
 		drm_puts(p, "H2G CTB (all sizes in DW):\n");
 		guc_ctb_snapshot_print(&snapshot->h2g, p);
 
-		drm_puts(p, "\nG2H CTB (all sizes in DW):\n");
+		drm_puts(p, "G2H CTB (all sizes in DW):\n");
 		guc_ctb_snapshot_print(&snapshot->g2h, p);
 
 		drm_printf(p, "\tg2h outstanding: %d\n",
-- 
2.46.0


  reply	other threads:[~2024-08-30  6:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  6:23 [PATCH v6 0/9] drm/xe/guc: Improve GuC log dumping and add to devcoredump John.C.Harrison
2024-08-30  6:23 ` John.C.Harrison [this message]
2024-08-30  6:23 ` [PATCH v6 2/9] drm/xe: Add ASCII85 dump helper function John.C.Harrison
2024-08-30 17:29   ` John Harrison
2024-08-30 17:31     ` John Harrison
2024-08-30 21:56   ` Matthew Brost
2024-08-30 23:33     ` John Harrison
2024-08-31  1:18       ` John Harrison
2024-08-30  6:23 ` [PATCH v6 3/9] drm/xe/guc: Copy GuC log prior to dumping John.C.Harrison
2024-08-30  6:23 ` [PATCH v6 4/9] drm/xe/guc: Use a two stage dump for GuC logs and add more info John.C.Harrison
2024-08-30  6:23 ` [PATCH v6 5/9] drm/print: Introduce drm_line_printer John.C.Harrison
2024-08-30  6:23 ` [PATCH v6 6/9] drm/xe/guc: Dead CT helper John.C.Harrison
2024-08-30  6:23 ` [PATCH v6 7/9] drm/xe/guc: Dump entire CTB on errors John.C.Harrison
2024-08-30  6:23 ` [PATCH v6 8/9] drm/xe/guc: Add GuC log to devcoredump captures John.C.Harrison
2024-08-30  6:23 ` [PATCH v6 9/9] drm/xe/guc: Add a helper function for dumping GuC log to dmesg John.C.Harrison
2024-08-30  6:59 ` ✓ CI.Patch_applied: success for drm/xe/guc: Improve GuC log dumping and add to devcoredump Patchwork
2024-08-30  6:59 ` ✗ CI.checkpatch: warning " Patchwork
2024-08-30  7:00 ` ✓ CI.KUnit: success " Patchwork
2024-08-30  7:16 ` ✓ CI.Build: " Patchwork
2024-08-30  7:23 ` ✓ CI.Hooks: " Patchwork
2024-08-30  7:25 ` ✗ CI.checksparse: warning " Patchwork
2024-08-30 19:10 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830062310.3450387-2-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=Intel-Xe@Lists.FreeDesktop.Org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox