From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com,
javierm@redhat.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
nouveau@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: [PATCH v3 04/81] drm: Add client-agnostic setup helper
Date: Fri, 30 Aug 2024 10:39:48 +0200 [thread overview]
Message-ID: <20240830084456.77630-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20240830084456.77630-1-tzimmermann@suse.de>
DRM may support multiple in-kernel clients that run as soon as a DRM
driver has been registered. To select the client(s) in a single place,
introduce drm_client_setup().
Drivers that call the new helper automatically instantiate the kernel's
configured default clients. Only fbdev emulation is currently supported.
Later versions can add support for DRM-based logging, a boot logo or even
a console.
Some drivers handle the color mode for clients internally. Provide the
helper drm_client_setup_with_color_mode() for them.
v3:
- fix build error
v2:
- add drm_client_setup_with_fourcc() (Laurent)
- push default-format handling into actual clients
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/drm_client_setup.c | 69 ++++++++++++++++++++++++++++++
include/drm/drm_client_setup.h | 15 +++++++
3 files changed, 85 insertions(+)
create mode 100644 drivers/gpu/drm/drm_client_setup.c
create mode 100644 include/drm/drm_client_setup.h
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 0beb55d028a8..e7fc77d1d573 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -129,6 +129,7 @@ drm_kms_helper-y := \
drm_atomic_helper.o \
drm_atomic_state_helper.o \
drm_bridge_connector.o \
+ drm_client_setup.o \
drm_crtc_helper.o \
drm_damage_helper.o \
drm_encoder_slave.o \
diff --git a/drivers/gpu/drm/drm_client_setup.c b/drivers/gpu/drm/drm_client_setup.c
new file mode 100644
index 000000000000..5373a892f097
--- /dev/null
+++ b/drivers/gpu/drm/drm_client_setup.c
@@ -0,0 +1,69 @@
+// SPDX-License-Identifier: MIT
+
+#include <drm/drm_client_setup.h>
+#include <drm/drm_device.h>
+#include <drm/drm_fbdev_client.h>
+#include <drm/drm_fourcc.h>
+#include <drm/drm_print.h>
+
+/**
+ * drm_client_setup() - Setup in-kernel DRM clients
+ * @dev: DRM device
+ * @format: Preferred pixel format for the device. Use NULL, unless
+ * there is clearly a driver-preferred format.
+ *
+ * This function sets up the in-kernel DRM clients. Restore, hotplug
+ * events and teardown are all taken care of.
+ *
+ * Drivers should call drm_client_setup() after registering the new
+ * DRM device with drm_dev_register(). This function is safe to call
+ * even when there are no connectors present. Setup will be retried
+ * on the next hotplug event.
+ *
+ * The clients are destroyed by drm_dev_unregister().
+ */
+void drm_client_setup(struct drm_device *dev, const struct drm_format_info *format)
+{
+ int ret;
+
+ ret = drm_fbdev_client_setup(dev, format);
+ if (ret)
+ drm_warn(dev, "Failed to set up DRM client; error %d\n", ret);
+}
+EXPORT_SYMBOL(drm_client_setup);
+
+/**
+ * drm_client_setup_with_fourcc() - Setup in-kernel DRM clients for color mode
+ * @dev: DRM device
+ * @fourcc: Preferred pixel format as 4CC code for the device
+ *
+ * This function sets up the in-kernel DRM clients. It is equivalent
+ * to drm_client_setup(), but expects a 4CC code as second argument.
+ *
+ * Do not use this function in new drivers. Prefer drm_client_setup() with a
+ * format of NULL.
+ */
+void drm_client_setup_with_fourcc(struct drm_device *dev, u32 fourcc)
+{
+ drm_client_setup(dev, drm_format_info(fourcc));
+}
+EXPORT_SYMBOL(drm_client_setup_with_fourcc);
+
+/**
+ * drm_client_setup_with_color_mode() - Setup in-kernel DRM clients for color mode
+ * @dev: DRM device
+ * @color_mode: Preferred color mode for the device
+ *
+ * This function sets up the in-kernel DRM clients. It is equivalent
+ * to drm_client_setup(), but expects a color mode as second argument.
+ *
+ * Do not use this function in new drivers. Prefer drm_client_setup() with a
+ * format of NULL.
+ */
+void drm_client_setup_with_color_mode(struct drm_device *dev, unsigned int color_mode)
+{
+ u32 fourcc = drm_driver_color_mode_format(dev, color_mode);
+
+ drm_client_setup_with_fourcc(dev, fourcc);
+}
+EXPORT_SYMBOL(drm_client_setup_with_color_mode);
diff --git a/include/drm/drm_client_setup.h b/include/drm/drm_client_setup.h
new file mode 100644
index 000000000000..6c0396b4f815
--- /dev/null
+++ b/include/drm/drm_client_setup.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: MIT */
+
+#ifndef DRM_CLIENT_SETUP_H
+#define DRM_CLIENT_SETUP_H
+
+#include <linux/types.h>
+
+struct drm_device;
+struct drm_format_info;
+
+void drm_client_setup(struct drm_device *dev, const struct drm_format_info *format);
+void drm_client_setup_with_fourcc(struct drm_device *dev, u32 fourcc);
+void drm_client_setup_with_color_mode(struct drm_device *dev, unsigned int color_mode);
+
+#endif
--
2.46.0
next prev parent reply other threads:[~2024-08-30 8:45 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 8:39 [PATCH v3 00/81] drm: Provide client setup helper and convert drivers Thomas Zimmermann
2024-08-30 8:39 ` [PATCH v3 01/81] drm/fbdev-helper: Move color-mode lookup into 4CC format helper Thomas Zimmermann
2024-08-30 8:39 ` [PATCH v3 02/81] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info Thomas Zimmermann
2024-09-03 10:18 ` Javier Martinez Canillas
2024-09-03 10:54 ` Thomas Zimmermann
2024-09-03 11:18 ` Javier Martinez Canillas
2024-08-30 8:39 ` [PATCH v3 03/81] drm/fbdev: Add memory-agnostic fbdev client Thomas Zimmermann
2024-09-03 10:42 ` Javier Martinez Canillas
2024-08-30 8:39 ` Thomas Zimmermann [this message]
2024-08-30 9:45 ` [PATCH v3 04/81] drm: Add client-agnostic setup helper Geert Uytterhoeven
2024-08-30 10:30 ` Thomas Zimmermann
2024-08-30 8:39 ` [PATCH v3 05/81] drm/fbdev-dma: Support struct drm_driver.fbdev_probe Thomas Zimmermann
2024-09-03 11:08 ` Javier Martinez Canillas
2024-09-03 11:47 ` Thomas Zimmermann
2024-08-30 8:39 ` [PATCH v3 06/81] drm/arcgpu: Run DRM default client setup Thomas Zimmermann
2024-09-03 11:13 ` Javier Martinez Canillas
2024-08-30 8:39 ` [PATCH v3 07/81] drm/arm/komeda: " Thomas Zimmermann
2024-08-30 8:39 ` [PATCH v3 08/81] drm/arm/hdlcd: " Thomas Zimmermann
2024-08-30 8:39 ` [PATCH v3 09/81] drm/arm/malidp: " Thomas Zimmermann
2024-08-30 8:39 ` [PATCH v3 10/81] drm/aspeed: " Thomas Zimmermann
2024-09-03 11:14 ` Javier Martinez Canillas
2024-08-30 8:39 ` [PATCH v3 11/81] drm/atmel-hdlcd: " Thomas Zimmermann
2024-08-30 21:18 ` Sam Ravnborg
2024-08-30 8:39 ` [PATCH v3 12/81] drm/fsl-dcu: " Thomas Zimmermann
2024-09-03 11:14 ` Javier Martinez Canillas
2024-08-30 8:39 ` [PATCH v3 13/81] drm/hisilicon/kirin: " Thomas Zimmermann
2024-08-30 8:39 ` [PATCH v3 14/81] drm/hx8357d: " Thomas Zimmermann
2024-09-03 11:20 ` Javier Martinez Canillas
2024-08-30 8:39 ` [PATCH v3 15/81] drm/ili9163: " Thomas Zimmermann
2024-09-03 11:21 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 16/81] drm/ili9225: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 17/81] drm/ili9341: " Thomas Zimmermann
2024-09-03 11:23 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 18/81] drm/ili9486: " Thomas Zimmermann
2024-09-03 11:24 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 19/81] drm/imx/dcss: " Thomas Zimmermann
2024-09-03 11:24 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 20/81] drm/imx/ipuv3: " Thomas Zimmermann
2024-09-03 11:25 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 21/81] drm/imx/lcdc: " Thomas Zimmermann
2024-09-03 11:25 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 22/81] drm/ingenic: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 23/81] drm/kmb: " Thomas Zimmermann
2024-09-03 11:26 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 24/81] drm/logicvc: " Thomas Zimmermann
2024-09-03 11:27 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 25/81] drm/mcde: " Thomas Zimmermann
2024-09-03 11:27 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 26/81] drm/mediatek: " Thomas Zimmermann
2024-09-02 16:31 ` Matthias Brugger
2024-08-30 8:40 ` [PATCH v3 27/81] drm/meson: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 28/81] drm/mi0283qt: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 29/81] drm/mxsfb/lcdif: " Thomas Zimmermann
2024-09-03 11:28 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 30/81] drm/mxsfb: " Thomas Zimmermann
2024-09-03 11:29 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 31/81] drm/panel/ili9341: " Thomas Zimmermann
2024-08-30 21:27 ` Jessica Zhang
2024-08-30 8:40 ` [PATCH v3 32/81] drm/panel-mipi-dbi: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 33/81] drm/pl111: " Thomas Zimmermann
2024-09-03 11:30 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 34/81] drm/renesas/rcar-du: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 35/81] drm/renesas/rz-du: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 36/81] drm/renesas/shmobile: " Thomas Zimmermann
2024-08-30 9:32 ` Geert Uytterhoeven
2024-08-30 8:40 ` [PATCH v3 37/81] drm/repaper: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 38/81] drm/rockchip: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 39/81] drm/sti: " Thomas Zimmermann
2024-09-03 11:30 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 40/81] drm/stm: " Thomas Zimmermann
2024-08-30 9:22 ` Geert Uytterhoeven
2024-08-30 9:31 ` Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 41/81] drm/sun4i: " Thomas Zimmermann
2024-09-03 11:31 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 42/81] drm/tidss: " Thomas Zimmermann
2024-09-03 11:31 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 43/81] drm/tilcdc: " Thomas Zimmermann
2024-09-03 11:32 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 44/81] drm/st7586: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 45/81] drm/st7735r: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 46/81] drm/tve200: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 47/81] drm/vc4: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 48/81] drm/xlnx: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 49/81] drm/fbdev-dma: Remove obsolete setup function Thomas Zimmermann
2024-09-03 11:35 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 50/81] drm/fbdev-shmem: Support struct drm_driver.fbdev_probe Thomas Zimmermann
2024-09-03 11:39 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 51/81] drm/ast: Run DRM default client setup Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 52/81] drm/cirrus: " Thomas Zimmermann
2024-09-03 12:00 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 53/81] drm/gm12u320: " Thomas Zimmermann
2024-09-03 12:01 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 54/81] drm/gud: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 55/81] drm/hyperv_drm: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 56/81] drm/mgag200: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 57/81] drm/ofdrm: Use " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 58/81] drm/simpledrm: Run " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 59/81] drm/solomon: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 60/81] drm/udl: " Thomas Zimmermann
2024-09-03 12:01 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 61/81] drm/virtgpu: " Thomas Zimmermann
2024-09-03 12:02 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 62/81] drm/vkms: " Thomas Zimmermann
2024-09-03 12:02 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 63/81] drm/fbdev-shmem: Remove obsolete setup function Thomas Zimmermann
2024-09-03 12:04 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 64/81] drm/fbdev-ttm: Support struct drm_driver.fbdev_probe Thomas Zimmermann
2024-09-03 12:05 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 65/81] drm/amdgpu: Run DRM default client setup Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 66/81] drm/bochs: " Thomas Zimmermann
2024-09-03 12:06 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 67/81] drm/hisilicon/hibmc: " Thomas Zimmermann
2024-09-03 12:06 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 68/81] drm/loongson: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 69/81] drm/nouveau: " Thomas Zimmermann
2024-08-30 8:40 ` [PATCH v3 70/81] drm/qxl: " Thomas Zimmermann
2024-09-03 12:06 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 71/81] drm/vboxvideo: " Thomas Zimmermann
2024-09-03 12:07 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 72/81] drm/vmwgfx: " Thomas Zimmermann
2024-09-03 12:07 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 73/81] drm/fbdev-ttm: Remove obsolete setup function Thomas Zimmermann
2024-09-03 12:08 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 74/81] drm/armada: Run DRM default client setup Thomas Zimmermann
2024-09-03 12:11 ` Javier Martinez Canillas
2024-08-30 8:40 ` [PATCH v3 75/81] drm/exynos-drm: " Thomas Zimmermann
2024-09-03 12:13 ` Javier Martinez Canillas
2024-08-30 8:41 ` [PATCH v3 76/81] drm/gma500: " Thomas Zimmermann
2024-09-03 12:15 ` Javier Martinez Canillas
2024-08-30 8:41 ` [PATCH v3 77/81] drm/msm: " Thomas Zimmermann
2024-09-03 12:16 ` Javier Martinez Canillas
2024-09-03 13:08 ` Dmitry Baryshkov
2024-08-30 8:41 ` [PATCH v3 78/81] drm/radeon: " Thomas Zimmermann
2024-08-30 8:41 ` [PATCH v3 79/81] drm/tegra: " Thomas Zimmermann
2024-09-03 12:18 ` Javier Martinez Canillas
2024-08-30 8:41 ` [PATCH v3 80/81] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev Thomas Zimmermann
2024-09-03 12:21 ` Javier Martinez Canillas
2024-08-30 8:41 ` [PATCH v3 81/81] drm/omapdrm: Run DRM default client setup Thomas Zimmermann
2024-09-03 12:22 ` Javier Martinez Canillas
2024-08-30 8:58 ` ✗ CI.Patch_applied: failure for drm: Provide client setup helper and convert drivers (rev3) Patchwork
2024-08-30 10:33 ` Thomas Zimmermann
2024-09-01 19:28 ` [PATCH v3 43/81] drm/tilcdc: Run DRM default client setup jyri.sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830084456.77630-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jfalempe@redhat.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox