From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Kees Cook" <kees@kernel.org>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Riana Tauro <riana.tauro@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
DRM XE List <intel-xe@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the kspp tree
Date: Mon, 9 Sep 2024 19:59:39 +1000 [thread overview]
Message-ID: <20240909195939.067c1c13@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1960 bytes --]
Hi all,
After merging the kspp tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/gpu/drm/xe/xe_gt_idle.c:56:27: error: redefinition of 'str_up_down'
56 | static inline const char *str_up_down(bool v)
| ^~~~~~~~~~~
In file included from include/linux/string_helpers.h:7,
from drivers/gpu/drm/xe/xe_assert.h:9,
from drivers/gpu/drm/xe/xe_force_wake.h:9,
from drivers/gpu/drm/xe/xe_gt_idle.c:8:
include/linux/string_choices.h:62:27: note: previous definition of 'str_up_down' with type 'const char *(bool)' {aka 'const char *(_Bool)'}
62 | static inline const char *str_up_down(bool v)
| ^~~~~~~~~~~
Caused by commit
a98ae7f045b2 ("lib/string_choices: Add str_up_down() helper")
interacting with commit
0914c1e45d3a ("drm/xe/xe_gt_idle: add debugfs entry for powergating info")
from the drm-xe tree.
I have applied the following patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 9 Sep 2024 19:40:17 +1000
Subject: [PATCH] fix up for "lib/string_choices: Add str_up_down() helper"
interacting wit commit "drm/xe/xe_gt_idle: add debugfs entry for
powergating info" from the drm-xe tree.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/gpu/drm/xe/xe_gt_idle.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c
index 85a35ed153a3..0f98c1539c64 100644
--- a/drivers/gpu/drm/xe/xe_gt_idle.c
+++ b/drivers/gpu/drm/xe/xe_gt_idle.c
@@ -53,11 +53,6 @@ pc_to_xe(struct xe_guc_pc *pc)
return gt_to_xe(gt);
}
-static inline const char *str_up_down(bool v)
-{
- return v ? "up" : "down";
-}
-
static const char *gt_idle_state_to_string(enum xe_gt_idle_state state)
{
switch (state) {
--
2.45.2
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2024-09-09 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 9:59 Stephen Rothwell [this message]
2024-09-09 10:05 ` ✓ CI.Patch_applied: success for linux-next: build failure after merge of the kspp tree Patchwork
2024-09-09 10:05 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-09 10:05 ` ✗ CI.KUnit: failure " Patchwork
2024-09-18 23:27 ` Stephen Rothwell
2024-09-20 3:43 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909195939.067c1c13@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=intel-xe@lists.freedesktop.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox