From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D9C9CF58C1 for ; Fri, 20 Sep 2024 03:21:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F1F1710E78C; Fri, 20 Sep 2024 03:21:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="jcYbK2W4"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCA7F10E785 for ; Fri, 20 Sep 2024 03:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726802470; x=1758338470; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HZeQs53wm6ed54JkpA6N1W85jW5iKCuP6XPXOUbb8nw=; b=jcYbK2W4VQe95MOEW1KQ1W9XQr6cfGhqnpuv9pjWD8FEPIs4+6eQt3Tr cIjcFm8mNAzhrcwSiV95WjOryGm6MqcEPqRTOfIFt8E7u8hkJdTlHUl+z Hiowrv5oU8q12YfTtoz/JAEeQ4cbIMbREnGpbBIZE0OTAmgw8mYoCnoTp 8m9OO9vDxDQ6y5rbWhmEwFJnFwmZtj/C1k5Rdra6/nHrlmBuyTBgLXqhb 6kIwEACjfLti/eYhCgmLC24CQR5MB5Gen6dw6ulfZdzcgNMHVLWec1XTe D3FkzLmuUFlvILbOZD9LQZpyx5LM19AWKn/qwYv9vGxdc974GhBcwDIqn g==; X-CSE-ConnectionGUID: WTnKzCQtQRGMM99j1/0xZA== X-CSE-MsgGUID: +cYjHPmVTyS0ZC8degqTog== X-IronPort-AV: E=McAfee;i="6700,10204,11200"; a="25983958" X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="25983958" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2024 20:21:09 -0700 X-CSE-ConnectionGUID: GnJ1MrmST6GvhxFK0P2jqA== X-CSE-MsgGUID: L6Cx13t4Sc2T5Qsr6uafKQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="74504439" Received: from relo-linux-5.jf.intel.com ([10.165.21.152]) by fmviesa005.fm.intel.com with ESMTP; 19 Sep 2024 20:21:09 -0700 From: John.C.Harrison@Intel.com To: Intel-Xe@Lists.FreeDesktop.Org Cc: John Harrison , Michal Wajdeczko , Julia Filipchuk Subject: [PATCH v8 01/11] drm/xe/guc: Remove spurious line feed in debug print Date: Thu, 19 Sep 2024 20:20:58 -0700 Message-ID: <20240920032108.629796-2-John.C.Harrison@Intel.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240920032108.629796-1-John.C.Harrison@Intel.com> References: <20240920032108.629796-1-John.C.Harrison@Intel.com> MIME-Version: 1.0 Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" From: John Harrison Including line feeds at the start of a debug print messes up the output when sent to dmesg. The break appears between all the useful prefix information and the actual string being printed. In this case, each block of data has a very clear start line and an extra delimeter is really not necessary. So don't do it. v2: Fix typo in commit message (review feedback from Michal W.) Signed-off-by: John Harrison Reviewed-by: Michal Wajdeczko Reviewed-by: Julia Filipchuk --- drivers/gpu/drm/xe/xe_guc_ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c index 4b95f75b1546..a63fe0a9077a 100644 --- a/drivers/gpu/drm/xe/xe_guc_ct.c +++ b/drivers/gpu/drm/xe/xe_guc_ct.c @@ -1523,7 +1523,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot, drm_puts(p, "H2G CTB (all sizes in DW):\n"); guc_ctb_snapshot_print(&snapshot->h2g, p); - drm_puts(p, "\nG2H CTB (all sizes in DW):\n"); + drm_puts(p, "G2H CTB (all sizes in DW):\n"); guc_ctb_snapshot_print(&snapshot->g2h, p); drm_printf(p, "\tg2h outstanding: %d\n", -- 2.46.0