From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v2 09/13] drm/i915/dsb: Introduce intel_dsb_wait_vblank_delay()
Date: Mon, 30 Sep 2024 20:04:11 +0300 [thread overview]
Message-ID: <20240930170415.23841-10-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240930170415.23841-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Add intel_dsb_wait_vblank_delay() which instructs the DSB
to wait for duration between the undelayed and delayed vblanks.
We'll need this as the DSB can only directly wait for the
undelayed vblank, but we'll need to wait until the delayed
vblank has elapsed as well.
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 11 +++++++++++
drivers/gpu/drm/i915/display/intel_dsb.h | 2 ++
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index fe9a1772769d..b7b44399adaa 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -637,6 +637,17 @@ void intel_dsb_chain(struct intel_atomic_state *state,
wait_for_vblank ? DSB_WAIT_FOR_VBLANK : 0);
}
+void intel_dsb_wait_vblank_delay(struct intel_atomic_state *state,
+ struct intel_dsb *dsb)
+{
+ struct intel_crtc *crtc = dsb->crtc;
+ const struct intel_crtc_state *crtc_state = pre_commit_crtc_state(state, crtc);
+ int usecs = intel_scanlines_to_usecs(&crtc_state->hw.adjusted_mode,
+ dsb_vblank_delay(crtc_state)) + 1;
+
+ intel_dsb_wait_usec(dsb, usecs);
+}
+
static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
int hw_dewake_scanline)
{
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
index 115f51c75a1e..33e0fc2ab380 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.h
+++ b/drivers/gpu/drm/i915/display/intel_dsb.h
@@ -42,6 +42,8 @@ void intel_dsb_nonpost_end(struct intel_dsb *dsb);
void intel_dsb_interrupt(struct intel_dsb *dsb);
void intel_dsb_wait_usec(struct intel_dsb *dsb, int count);
void intel_dsb_wait_vblanks(struct intel_dsb *dsb, int count);
+void intel_dsb_wait_vblank_delay(struct intel_atomic_state *state,
+ struct intel_dsb *dsb);
void intel_dsb_wait_scanline_in(struct intel_atomic_state *state,
struct intel_dsb *dsb,
int lower, int upper);
--
2.45.2
next prev parent reply other threads:[~2024-09-30 17:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 17:04 [PATCH v2 00/13] drm/i915: Use DSB for plane/color management commits Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 01/13] drm/i915/dsb: Avoid reads of the DSB buffer for indexed register writes Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 02/13] drm/i915: Prepare clear color before wait_for_dependencies() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 03/13] drm/i915/dsb: Generate the DSB buffer in commit_tail() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 04/13] drm/i915/dsb: Enable programmable DSB interrupt Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 05/13] drm/i915/dsb: Introduce intel_dsb_vblank_evade() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 06/13] drm/i915/dsb: Introduce intel_dsb_wait_usec() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 07/13] drm/i915/dsb: Introduce intel_dsb_wait_vblanks() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 08/13] drm/i915: Introduce intel_scanlines_to_usecs() Ville Syrjala
2024-09-30 17:04 ` Ville Syrjala [this message]
2024-09-30 17:04 ` [PATCH v2 10/13] drm/i915: Extract intel_crtc_prepare_vblank_event() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 11/13] drm/i915: Plumb 'dsb' all way to the plane hooks Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 12/13] drm/i915: Plumb 'dsb' all way to the color commit hooks Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 13/13] drm/i915/dsb: Use DSB for plane/color management updates Ville Syrjala
2024-09-30 23:18 ` ✓ CI.Patch_applied: success for drm/i915: Use DSB for plane/color management commits Patchwork
2024-09-30 23:19 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-30 23:20 ` ✓ CI.KUnit: success " Patchwork
2024-09-30 23:31 ` ✓ CI.Build: " Patchwork
2024-09-30 23:34 ` ✓ CI.Hooks: " Patchwork
2024-09-30 23:35 ` ✗ CI.checksparse: warning " Patchwork
2024-09-30 23:58 ` ✓ CI.BAT: success " Patchwork
2024-10-01 9:45 ` ✗ CI.FULL: failure " Patchwork
2024-10-03 21:52 ` [PATCH v2 00/13] " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930170415.23841-10-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox