From: John.C.Harrison@Intel.com
To: Intel-Xe@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
Julia Filipchuk <julia.filipchuk@intel.com>
Subject: [PATCH v9 01/11] drm/xe/guc: Remove spurious line feed in debug print
Date: Wed, 2 Oct 2024 17:46:01 -0700 [thread overview]
Message-ID: <20241003004611.2323493-2-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20241003004611.2323493-1-John.C.Harrison@Intel.com>
From: John Harrison <John.C.Harrison@Intel.com>
Including line feeds at the start of a debug print messes up the
output when sent to dmesg. The break appears between all the useful
prefix information and the actual string being printed. In this case,
each block of data has a very clear start line and an extra delimeter
is really not necessary. So don't do it.
v2: Fix typo in commit message (review feedback from Michal W.)
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>
---
drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 4b95f75b1546..a63fe0a9077a 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -1523,7 +1523,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot,
drm_puts(p, "H2G CTB (all sizes in DW):\n");
guc_ctb_snapshot_print(&snapshot->h2g, p);
- drm_puts(p, "\nG2H CTB (all sizes in DW):\n");
+ drm_puts(p, "G2H CTB (all sizes in DW):\n");
guc_ctb_snapshot_print(&snapshot->g2h, p);
drm_printf(p, "\tg2h outstanding: %d\n",
--
2.46.0
next prev parent reply other threads:[~2024-10-03 0:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 0:46 [PATCH v9 00/11] drm/xe/guc: Improve GuC log dumping and add to devcoredump John.C.Harrison
2024-10-03 0:46 ` John.C.Harrison [this message]
2024-10-03 0:46 ` [PATCH v9 02/11] drm/xe/devcoredump: Use drm_puts and already cached local variables John.C.Harrison
2024-10-03 0:46 ` [PATCH v9 03/11] drm/xe/devcoredump: Improve section headings and add tile info John.C.Harrison
2024-12-12 18:17 ` Souza, Jose
2024-12-12 18:59 ` John Harrison
2024-12-12 19:31 ` Souza, Jose
2024-12-12 20:06 ` John Harrison
2024-12-12 20:30 ` Souza, Jose
2024-12-12 20:38 ` John Harrison
2024-10-03 0:46 ` [PATCH v9 04/11] drm/xe/devcoredump: Add ASCII85 dump helper function John.C.Harrison
2024-12-12 17:41 ` Souza, Jose
2024-12-12 18:45 ` Lucas De Marchi
2024-12-12 19:14 ` John Harrison
2024-12-12 20:52 ` Lucas De Marchi
2024-12-12 21:04 ` John Harrison
2024-12-13 0:32 ` Lucas De Marchi
2024-12-13 16:36 ` John Harrison
2024-12-13 17:20 ` Lucas De Marchi
2024-12-13 17:34 ` John Harrison
2024-12-13 14:18 ` Rodrigo Vivi
2024-12-13 16:42 ` John Harrison
2024-10-03 0:46 ` [PATCH v9 05/11] drm/xe/guc: Copy GuC log prior to dumping John.C.Harrison
2024-10-03 0:46 ` [PATCH v9 06/11] drm/xe/guc: Use a two stage dump for GuC logs and add more info John.C.Harrison
2024-10-08 21:18 ` [v9, " Kees Bakker
2024-10-03 0:46 ` [PATCH v9 07/11] drm/print: Introduce drm_line_printer John.C.Harrison
2024-10-04 13:57 ` Maarten Lankhorst
2024-10-03 0:46 ` [PATCH v9 08/11] drm/xe/guc: Dead CT helper John.C.Harrison
2024-10-03 0:46 ` [PATCH v9 09/11] drm/xe/guc: Dump entire CTB on errors John.C.Harrison
2024-10-03 0:46 ` [PATCH v9 10/11] drm/xe/guc: Add GuC log to devcoredump captures John.C.Harrison
2024-10-03 0:46 ` [PATCH v9 11/11] drm/xe/guc: Add a helper function for dumping GuC log to dmesg John.C.Harrison
2024-10-03 1:15 ` ✓ CI.Patch_applied: success for drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev6) Patchwork
2024-10-03 1:15 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-03 1:17 ` ✓ CI.KUnit: success " Patchwork
2024-10-03 1:28 ` ✓ CI.Build: " Patchwork
2024-10-03 1:30 ` ✓ CI.Hooks: " Patchwork
2024-10-03 1:32 ` ✗ CI.checksparse: warning " Patchwork
2024-10-03 1:49 ` ✓ CI.BAT: success " Patchwork
2024-10-03 2:40 ` ✗ CI.FULL: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-10-02 21:14 [PATCH v9 00/11] drm/xe/guc: Improve GuC log dumping and add to devcoredump John.C.Harrison
2024-10-02 21:14 ` [PATCH v9 01/11] drm/xe/guc: Remove spurious line feed in debug print John.C.Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003004611.2323493-2-John.C.Harrison@Intel.com \
--to=john.c.harrison@intel.com \
--cc=Intel-Xe@Lists.FreeDesktop.Org \
--cc=julia.filipchuk@intel.com \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox