From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tvrtko Ursulin <tursulin@ursulin.net>
Subject: Re: [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.
Date: Fri, 4 Oct 2024 08:49:51 +0200 [thread overview]
Message-ID: <20241004064951.XLw7TFbS@linutronix.de> (raw)
In-Reply-To: <Zv17oKlIImyfg_KI@intel.com>
On 2024-10-02 19:58:08 [+0300], Ville Syrjälä wrote:
> > These patches were not picked. Did I forget something or was this just
> > overseen?
>
> This looks quite poorly justified. Eg. you seem to be now
> leaving interrupts enabled (and even preemption enabled I
> guess) when we're racing against the raster beam. On first
> blush that seems like a recipe for failure.
I can't really parse this. I may leave interrupts enabled in vblanc code
(the first two patches).
> First step would be to set CONFIG_DRM_I915_DEBUG_VBLANK_EVADE=y,
> run a bunch of tests that stress the display stuff (eg.
> kms_atomic_transitions and other stuff from igt, and also
> some real workloads) and probably throw in a bunch of
> other load/perturbance at the system to make life hard.
> After the system has been sufficiently hammered one can
> compare sys/kernel/debug/dri/0/crtc-*/i915_update_info
> against a baseline. Bonus points for doing it on a potato.
So you have a specific test for me to run?
Sebastian
next prev parent reply other threads:[~2024-10-04 6:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 12:57 [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 1/8] drm/i915: Use preempt_disable/enable_rt() where recommended Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 2/8] drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 4/8] drm/i915: Disable tracing points " Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 5/8] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 6/8] drm/i915: Drop the irqs_disabled() check Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 7/8] drm/i915/guc: Consider also RCU depth in busy loop Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 8/8] Revert "drm/i915: Depend on !PREEMPT_RT." Sebastian Andrzej Siewior
2024-06-28 13:11 ` ✓ CI.Patch_applied: success for drm/i915: PREEMPT_RT related fixups. (rev5) Patchwork
2024-06-28 13:11 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-28 13:12 ` ✓ CI.KUnit: success " Patchwork
2024-06-28 13:24 ` ✓ CI.Build: " Patchwork
2024-06-28 13:26 ` ✓ CI.Hooks: " Patchwork
2024-06-28 13:28 ` ✗ CI.checksparse: warning " Patchwork
2024-06-28 13:51 ` ✓ CI.BAT: success " Patchwork
2024-10-02 16:25 ` [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups Sebastian Andrzej Siewior
2024-10-02 16:58 ` Ville Syrjälä
2024-10-04 6:49 ` Sebastian Andrzej Siewior [this message]
2024-10-04 8:31 ` Ville Syrjälä
2024-10-04 8:45 ` Sebastian Andrzej Siewior
2024-10-04 9:07 ` Ville Syrjälä
2024-10-04 10:44 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004064951.XLw7TFbS@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tglx@linutronix.de \
--cc=tursulin@ursulin.net \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox