From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH v4 2/6] drm/xe: Add xe_ggtt_might_lock
Date: Wed, 9 Oct 2024 14:51:10 +0200 [thread overview]
Message-ID: <20241009125114.412624-3-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20241009125114.412624-1-maarten.lankhorst@linux.intel.com>
Another requirement of hiding more of struct xe_ggtt.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_bo.c | 2 +-
drivers/gpu/drm/xe/xe_ggtt.c | 7 +++++++
drivers/gpu/drm/xe/xe_ggtt.h | 7 +++++++
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 5e8f60a8d4316..9c4df3986d582 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -2359,7 +2359,7 @@ void xe_bo_put(struct xe_bo *bo)
might_lock(&bo->client->bos_lock);
#endif
if (bo->ggtt_node && bo->ggtt_node->ggtt)
- might_lock(&bo->ggtt_node->ggtt->lock);
+ xe_ggtt_might_lock(bo->ggtt_node->ggtt);
drm_gem_object_put(&bo->ttm.base);
}
}
diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
index 655eb6b7474e1..16be6f53b75b2 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.c
+++ b/drivers/gpu/drm/xe/xe_ggtt.c
@@ -176,6 +176,13 @@ static void ggtt_fini(void *arg)
ggtt->scratch = NULL;
}
+#ifdef CONFIG_LOCKDEP
+void xe_ggtt_might_lock(struct xe_ggtt *ggtt)
+{
+ might_lock(&ggtt->lock);
+}
+#endif
+
static void primelockdep(struct xe_ggtt *ggtt)
{
if (!IS_ENABLED(CONFIG_LOCKDEP))
diff --git a/drivers/gpu/drm/xe/xe_ggtt.h b/drivers/gpu/drm/xe/xe_ggtt.h
index bdf6d0733e2ca..62c8ce636939a 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.h
+++ b/drivers/gpu/drm/xe/xe_ggtt.h
@@ -38,4 +38,11 @@ u64 xe_ggtt_print_holes(struct xe_ggtt *ggtt, u64 alignment, struct drm_printer
void xe_ggtt_assign(const struct xe_ggtt_node *node, u16 vfid);
#endif
+#ifndef CONFIG_LOCKDEP
+static inline void xe_ggtt_might_lock(struct xe_ggtt *ggtt)
+{ }
+#else
+void xe_ggtt_might_lock(struct xe_ggtt *ggtt);
+#endif
+
#endif
--
2.45.2
next prev parent reply other threads:[~2024-10-09 12:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 12:51 [PATCH v4 0/6] drm/xe: Make struct xe_ggtt private Maarten Lankhorst
2024-10-09 12:51 ` [PATCH v4 1/6] drm/xe: Use xe_ggtt_map_bo_unlocked for resume Maarten Lankhorst
2024-10-11 12:06 ` Lucas De Marchi
2024-10-09 12:51 ` Maarten Lankhorst [this message]
2024-10-09 12:51 ` [PATCH v4 3/6] drm/xe: Add xe_ggtt_alloc Maarten Lankhorst
2024-10-11 12:13 ` Lucas De Marchi
2024-10-11 13:31 ` Michal Wajdeczko
2024-10-09 12:51 ` [PATCH v4 4/6] drm/xe: Convert xe_fb_pin to use a callback for insertion into GGTT Maarten Lankhorst
2024-10-09 12:51 ` [PATCH v4 5/6] drm/xe/display: Dont poke into GGTT internals to fill a DPT Maarten Lankhorst
2024-10-11 16:20 ` Lucas De Marchi
2024-10-09 12:51 ` [PATCH v4 6/6] drm/xe: Move struct xe_ggtt to xe_ggtt.c Maarten Lankhorst
2024-10-09 14:52 ` ✓ CI.Patch_applied: success for drm/xe: Make struct xe_ggtt private Patchwork
2024-10-09 14:53 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-09 14:54 ` ✓ CI.KUnit: success " Patchwork
2024-10-09 15:06 ` ✓ CI.Build: " Patchwork
2024-10-09 15:08 ` ✓ CI.Hooks: " Patchwork
2024-10-09 15:27 ` ✓ CI.BAT: " Patchwork
2024-10-10 0:23 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009125114.412624-3-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox