Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 2/4] drm/i915/dp: Disable unnecessary HPD polling for eDP
Date: Wed,  9 Oct 2024 22:43:56 +0300	[thread overview]
Message-ID: <20241009194358.1321200-3-imre.deak@intel.com> (raw)
In-Reply-To: <20241009194358.1321200-1-imre.deak@intel.com>

A registered eDP connector is considered to be always connected, so it's
unnecessary to poll it for a connect/disconnect event. Polling it
involves AUX accesses toggling the panel power, which in turn can
generate a spurious short HPD pulse and possibly a new poll cycle via
the short HPD handler runtime resuming the device. Avoid this by
disabling the polling for eDP connectors.

This avoids IGT tests timing out while waiting for the device to runtime
suspend, the timeout caused by the above runtime resume->poll->suspend->
resume cycle keeping the device in the resumed state.

Testcase: igt/kms_pm_rpm/unverisal-planes
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 3eff35dd59b8a..6b27fabd61c37 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -6476,7 +6476,8 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
 	if (!HAS_GMCH(dev_priv) && DISPLAY_VER(dev_priv) < 12)
 		connector->interlace_allowed = true;
 
-	intel_connector->polled = DRM_CONNECTOR_POLL_HPD;
+	if (type != DRM_MODE_CONNECTOR_eDP)
+		intel_connector->polled = DRM_CONNECTOR_POLL_HPD;
 	intel_connector->base.polled = intel_connector->polled;
 
 	intel_connector_attach_encoder(intel_connector, intel_encoder);
-- 
2.44.2


  parent reply	other threads:[~2024-10-09 19:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 19:43 [PATCH v2 0/4] drm/xe: Fix HPD interrupt enabling during runtime resume Imre Deak
2024-10-09 19:43 ` [PATCH v2 1/4] drm/i915/dp: Assume panel power is off if runtime suspended Imre Deak
2024-10-09 20:35   ` Cavitt, Jonathan
2024-10-09 21:26     ` Imre Deak
2024-10-09 21:59       ` Cavitt, Jonathan
2024-10-10  9:08         ` [PATCH v2 1/4] drm/i915/dp: Assume panel power is off if runtime suspended'' Imre Deak
2024-10-09 19:43 ` Imre Deak [this message]
2024-10-09 20:38   ` [PATCH v2 2/4] drm/i915/dp: Disable unnecessary HPD polling for eDP Cavitt, Jonathan
2024-10-09 19:43 ` [PATCH v2 3/4] drm/xe/display: Separate the d3cold and non-d3cold runtime PM handling Imre Deak
2024-10-09 19:43 ` [PATCH v2 4/4] drm/xe/display: Add missing HPD interrupt enabling during non-d3cold RPM resume Imre Deak
2024-10-09 21:47 ` ✓ CI.Patch_applied: success for drm/xe: Fix HPD interrupt enabling during runtime resume Patchwork
2024-10-09 21:47 ` ✓ CI.checkpatch: " Patchwork
2024-10-09 21:48 ` ✓ CI.KUnit: " Patchwork
2024-10-09 22:00 ` ✓ CI.Build: " Patchwork
2024-10-09 22:02 ` ✓ CI.Hooks: " Patchwork
2024-10-09 22:04 ` ✗ CI.checksparse: warning " Patchwork
2024-10-09 22:28 ` ✓ CI.BAT: success " Patchwork
2024-10-10 11:47 ` ✗ CI.FULL: failure " Patchwork
2024-10-11 11:26   ` Imre Deak
2024-10-11 14:47     ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241009194358.1321200-3-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox