Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>,
	Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH 1/2] drm/xe/ufence: Prefetch ufence addr to catch bogus address
Date: Fri, 11 Oct 2024 13:57:14 +0200	[thread overview]
Message-ID: <20241011115715.3486872-1-nirmoy.das@intel.com> (raw)

access_ok() only checks for addr overflow so also try to read the addr
to catch invalid addr sent from userspace.

Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1630
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_sync.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c
index bb3c2a830362..6a2e4dd41d56 100644
--- a/drivers/gpu/drm/xe/xe_sync.c
+++ b/drivers/gpu/drm/xe/xe_sync.c
@@ -54,8 +54,9 @@ static struct xe_user_fence *user_fence_create(struct xe_device *xe, u64 addr,
 {
 	struct xe_user_fence *ufence;
 	u64 __user *ptr = u64_to_user_ptr(addr);
+	u64 __maybe_unused prefetch_val;
 
-	if (!access_ok(ptr, sizeof(*ptr)))
+	if (get_user(prefetch_val, ptr))
 		return ERR_PTR(-EFAULT);
 
 	ufence = kmalloc(sizeof(*ufence), GFP_KERNEL);
-- 
2.46.0


             reply	other threads:[~2024-10-11 12:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 11:57 Nirmoy Das [this message]
2024-10-11 11:57 ` [PATCH 2/2] drm/xe/ufence: Warn if mmget_not_zero() fails Nirmoy Das
2024-10-14  9:27   ` Francois Dugast
2024-10-14 10:58     ` Maarten Lankhorst
2024-10-14 11:37       ` Francois Dugast
2024-10-11 13:16 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/ufence: Prefetch ufence addr to catch bogus address Patchwork
2024-10-11 13:17 ` ✓ CI.checkpatch: " Patchwork
2024-10-11 13:18 ` ✓ CI.KUnit: " Patchwork
2024-10-11 13:34 ` ✓ CI.Build: " Patchwork
2024-10-11 13:37 ` ✓ CI.Hooks: " Patchwork
2024-10-11 13:39 ` ✓ CI.checksparse: " Patchwork
2024-10-11 14:07 ` ✗ CI.BAT: failure " Patchwork
2024-10-11 16:01 ` ✗ CI.FULL: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-10-15  9:05 [PATCH 0/2] Improve ufence addr validation and error handling Nirmoy Das
2024-10-15  9:05 ` [PATCH 1/2] drm/xe/ufence: Prefetch ufence addr to catch bogus address Nirmoy Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011115715.3486872-1-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox