From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
Badal Nilawar <badal.nilawar@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH v9 01/26] drm/xe: Add member initialized_domains to xe_force_wake()
Date: Mon, 14 Oct 2024 13:25:36 +0530 [thread overview]
Message-ID: <20241014075601.2324382-2-himal.prasad.ghimiray@intel.com> (raw)
In-Reply-To: <20241014075601.2324382-1-himal.prasad.ghimiray@intel.com>
This field serves as a bitmask representing all initialized forcewake
domains on the GT.
v2
- Move awake_domains datatype change out of this patch (Michal)
- Rename domain_init to init_domain (Michal)
- optimize alignment (Michal)
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/xe/xe_force_wake.c | 30 ++++++++++++++----------
drivers/gpu/drm/xe/xe_force_wake_types.h | 2 ++
2 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_force_wake.c b/drivers/gpu/drm/xe/xe_force_wake.c
index a64c14757c84..ac0419da7173 100644
--- a/drivers/gpu/drm/xe/xe_force_wake.c
+++ b/drivers/gpu/drm/xe/xe_force_wake.c
@@ -21,15 +21,25 @@ static const char *str_wake_sleep(bool wake)
return wake ? "wake" : "sleep";
}
-static void domain_init(struct xe_force_wake_domain *domain,
+static void mark_domain_initialized(struct xe_force_wake *fw,
+ enum xe_force_wake_domain_id id)
+{
+ fw->initialized_domains |= BIT(id);
+}
+
+static void init_domain(struct xe_force_wake *fw,
enum xe_force_wake_domain_id id,
struct xe_reg reg, struct xe_reg ack)
{
+ struct xe_force_wake_domain *domain = &fw->domains[id];
+
domain->id = id;
domain->reg_ctl = reg;
domain->reg_ack = ack;
domain->val = FORCEWAKE_MT(FORCEWAKE_KERNEL);
domain->mask = FORCEWAKE_MT_MASK(FORCEWAKE_KERNEL);
+
+ mark_domain_initialized(fw, id);
}
void xe_force_wake_init_gt(struct xe_gt *gt, struct xe_force_wake *fw)
@@ -43,13 +53,11 @@ void xe_force_wake_init_gt(struct xe_gt *gt, struct xe_force_wake *fw)
xe_gt_assert(gt, GRAPHICS_VER(gt_to_xe(gt)) >= 11);
if (xe->info.graphics_verx100 >= 1270) {
- domain_init(&fw->domains[XE_FW_DOMAIN_ID_GT],
- XE_FW_DOMAIN_ID_GT,
+ init_domain(fw, XE_FW_DOMAIN_ID_GT,
FORCEWAKE_GT,
FORCEWAKE_ACK_GT_MTL);
} else {
- domain_init(&fw->domains[XE_FW_DOMAIN_ID_GT],
- XE_FW_DOMAIN_ID_GT,
+ init_domain(fw, XE_FW_DOMAIN_ID_GT,
FORCEWAKE_GT,
FORCEWAKE_ACK_GT);
}
@@ -63,8 +71,7 @@ void xe_force_wake_init_engines(struct xe_gt *gt, struct xe_force_wake *fw)
xe_gt_assert(gt, GRAPHICS_VER(gt_to_xe(gt)) >= 11);
if (!xe_gt_is_media_type(gt))
- domain_init(&fw->domains[XE_FW_DOMAIN_ID_RENDER],
- XE_FW_DOMAIN_ID_RENDER,
+ init_domain(fw, XE_FW_DOMAIN_ID_RENDER,
FORCEWAKE_RENDER,
FORCEWAKE_ACK_RENDER);
@@ -72,8 +79,7 @@ void xe_force_wake_init_engines(struct xe_gt *gt, struct xe_force_wake *fw)
if (!(gt->info.engine_mask & BIT(i)))
continue;
- domain_init(&fw->domains[XE_FW_DOMAIN_ID_MEDIA_VDBOX0 + j],
- XE_FW_DOMAIN_ID_MEDIA_VDBOX0 + j,
+ init_domain(fw, XE_FW_DOMAIN_ID_MEDIA_VDBOX0 + j,
FORCEWAKE_MEDIA_VDBOX(j),
FORCEWAKE_ACK_MEDIA_VDBOX(j));
}
@@ -82,15 +88,13 @@ void xe_force_wake_init_engines(struct xe_gt *gt, struct xe_force_wake *fw)
if (!(gt->info.engine_mask & BIT(i)))
continue;
- domain_init(&fw->domains[XE_FW_DOMAIN_ID_MEDIA_VEBOX0 + j],
- XE_FW_DOMAIN_ID_MEDIA_VEBOX0 + j,
+ init_domain(fw, XE_FW_DOMAIN_ID_MEDIA_VEBOX0 + j,
FORCEWAKE_MEDIA_VEBOX(j),
FORCEWAKE_ACK_MEDIA_VEBOX(j));
}
if (gt->info.engine_mask & BIT(XE_HW_ENGINE_GSCCS0))
- domain_init(&fw->domains[XE_FW_DOMAIN_ID_GSC],
- XE_FW_DOMAIN_ID_GSC,
+ init_domain(fw, XE_FW_DOMAIN_ID_GSC,
FORCEWAKE_GSC,
FORCEWAKE_ACK_GSC);
}
diff --git a/drivers/gpu/drm/xe/xe_force_wake_types.h b/drivers/gpu/drm/xe/xe_force_wake_types.h
index ed0edc2cdf9f..494240777d03 100644
--- a/drivers/gpu/drm/xe/xe_force_wake_types.h
+++ b/drivers/gpu/drm/xe/xe_force_wake_types.h
@@ -79,6 +79,8 @@ struct xe_force_wake {
spinlock_t lock;
/** @awake_domains: mask of all domains awake */
enum xe_force_wake_domains awake_domains;
+ /** @initialized_domains: mask of all initialized domains */
+ unsigned int initialized_domains;
/** @domains: force wake domains */
struct xe_force_wake_domain domains[XE_FW_DOMAIN_ID_COUNT];
};
--
2.34.1
next prev parent reply other threads:[~2024-10-14 7:37 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 7:55 [PATCH v9 00/26] Fix xe_force_wake_get() failure handling Himal Prasad Ghimiray
2024-10-14 7:44 ` ✓ CI.Patch_applied: success for Fix xe_force_wake_get() failure handling (rev10) Patchwork
2024-10-14 7:44 ` ✓ CI.checkpatch: " Patchwork
2024-10-14 7:46 ` ✓ CI.KUnit: " Patchwork
2024-10-14 7:55 ` Himal Prasad Ghimiray [this message]
2024-10-14 7:55 ` [PATCH v9 02/26] drm/xe/forcewake: Change awake_domain datatype Himal Prasad Ghimiray
2024-10-14 7:55 ` [PATCH v9 03/26] drm/xe/forcewake: Add a helper xe_force_wake_ref_has_domain() Himal Prasad Ghimiray
2024-10-14 7:55 ` [PATCH v9 04/26] drm/xe: Error handling in xe_force_wake_get() Himal Prasad Ghimiray
2024-10-14 8:32 ` Nirmoy Das
2024-10-14 7:55 ` [PATCH v9 05/26] drm/xe: Modify xe_force_wake_put to handle _get returned mask Himal Prasad Ghimiray
2024-10-14 8:52 ` Nirmoy Das
2024-10-14 7:55 ` [PATCH v9 06/26] drm/xe/device: Update handling of xe_force_wake_get return Himal Prasad Ghimiray
2024-10-15 13:28 ` Nirmoy Das
2024-10-15 14:35 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 07/26] drm/xe/hdcp: " Himal Prasad Ghimiray
2024-10-15 13:29 ` Nirmoy Das
2024-10-14 7:55 ` [PATCH v9 08/26] drm/xe/gsc: " Himal Prasad Ghimiray
2024-10-15 13:57 ` Nirmoy Das
2024-10-14 7:55 ` [PATCH v9 09/26] drm/xe/gt: " Himal Prasad Ghimiray
2024-10-15 14:24 ` Nirmoy Das
2024-10-15 14:44 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 10/26] drm/xe/xe_gt_idle: " Himal Prasad Ghimiray
2024-10-15 14:25 ` Nirmoy Das
2024-10-14 7:55 ` [PATCH v9 11/26] drm/xe/devcoredump: " Himal Prasad Ghimiray
2024-10-15 14:26 ` Nirmoy Das
2024-10-15 16:06 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 12/26] drm/xe/tests/mocs: Update xe_force_wake_get() return handling Himal Prasad Ghimiray
2024-10-15 14:47 ` Nirmoy Das
2024-10-15 16:08 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 13/26] drm/xe/mocs: Update handling of xe_force_wake_get return Himal Prasad Ghimiray
2024-10-15 15:09 ` Nirmoy Das
2024-10-15 17:59 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 14/26] drm/xe/xe_drm_client: " Himal Prasad Ghimiray
2024-10-15 15:17 ` Nirmoy Das
2024-10-15 18:00 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 15/26] drm/xe/xe_gt_debugfs: " Himal Prasad Ghimiray
2024-10-15 15:18 ` Nirmoy Das
2024-10-15 18:09 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 16/26] drm/xe/guc: " Himal Prasad Ghimiray
2024-10-15 15:20 ` Nirmoy Das
2024-10-15 18:32 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 17/26] drm/xe/huc: " Himal Prasad Ghimiray
2024-10-15 15:21 ` Nirmoy Das
2024-10-15 18:20 ` Nilawar, Badal
2024-10-15 18:42 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 18/26] drm/xe/oa: Handle force_wake_get failure in xe_oa_stream_init() Himal Prasad Ghimiray
2024-10-15 15:21 ` Nirmoy Das
2024-10-16 12:34 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 19/26] drm/xe/pat: Update handling of xe_force_wake_get return Himal Prasad Ghimiray
2024-10-15 15:28 ` Nirmoy Das
2024-10-16 12:35 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 20/26] drm/xe/gt_tlb_invalidation_ggtt: " Himal Prasad Ghimiray
2024-10-15 15:29 ` Nirmoy Das
2024-10-16 12:36 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 21/26] drm/xe/xe_reg_sr: " Himal Prasad Ghimiray
2024-10-15 15:30 ` Nirmoy Das
2024-10-16 12:38 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 22/26] drm/xe/query: " Himal Prasad Ghimiray
2024-10-15 15:31 ` Nirmoy Das
2024-10-16 12:40 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 23/26] drm/xe/vram: " Himal Prasad Ghimiray
2024-10-15 15:34 ` Nirmoy Das
2024-10-16 12:41 ` Nilawar, Badal
2024-10-14 7:55 ` [PATCH v9 24/26] drm/xe: forcewake debugfs open fails on xe_forcewake_get failure Himal Prasad Ghimiray
2024-10-15 16:02 ` Nilawar, Badal
2024-10-14 7:56 ` [PATCH v9 25/26] drm/xe: Ensure __must_check for xe_force_wake_get() return Himal Prasad Ghimiray
2024-10-14 8:57 ` Nirmoy Das
2024-10-14 7:56 ` [PATCH v9 26/26] drm/xe: Change return type to void for xe_force_wake_put Himal Prasad Ghimiray
2024-10-14 9:00 ` Nirmoy Das
2024-10-14 7:57 ` ✓ CI.Build: success for Fix xe_force_wake_get() failure handling (rev10) Patchwork
2024-10-14 7:59 ` ✓ CI.Hooks: " Patchwork
2024-10-14 8:01 ` ✓ CI.checksparse: " Patchwork
2024-10-14 8:27 ` ✓ CI.BAT: " Patchwork
2024-10-14 9:25 ` ✗ CI.FULL: failure " Patchwork
2024-10-17 5:40 ` ✓ CI.Patch_applied: success for Fix xe_force_wake_get() failure handling (rev11) Patchwork
2024-10-17 5:40 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-17 5:42 ` ✓ CI.KUnit: success " Patchwork
2024-10-17 5:53 ` ✓ CI.Build: " Patchwork
2024-10-17 5:55 ` ✓ CI.Hooks: " Patchwork
2024-10-17 5:57 ` ✓ CI.checksparse: " Patchwork
2024-10-17 6:20 ` ✓ CI.BAT: " Patchwork
2024-10-17 15:42 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014075601.2324382-2-himal.prasad.ghimiray@intel.com \
--to=himal.prasad.ghimiray@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox