Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: uma.shankar@intel.com, vandita.kulkarni@intel.com,
	Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH 4/4] drm/i915/xe3lpd: Prune modes for YUV420
Date: Tue, 15 Oct 2024 11:40:11 +0530	[thread overview]
Message-ID: <20241015061011.2087826-5-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20241015061011.2087826-1-suraj.kandpal@intel.com>

We only support resolution up to 4k for single pipe when using
YUV420 format so we prune these modes and restrict the plane size
at src.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c            | 6 ++++++
 drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 ++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 6cdc968522df..1823b509cbfb 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1374,6 +1374,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
 {
 	struct intel_connector *connector = to_intel_connector(_connector);
 	struct intel_dp *intel_dp = intel_attached_dp(connector);
+	enum intel_output_format sink_format;
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	const struct drm_display_mode *fixed_mode;
 	int target_clock = mode->clock;
@@ -1408,6 +1409,11 @@ intel_dp_mode_valid(struct drm_connector *_connector,
 						     mode->hdisplay, target_clock);
 	max_dotclk *= num_joined_pipes;
 
+	sink_format = intel_dp_sink_format(connector, mode);
+	if (sink_format == INTEL_OUTPUT_FORMAT_YCBCR420 &&
+	    mode->hdisplay > 4096)
+		return MODE_NO_420;
+
 	if (target_clock > max_dotclk)
 		return MODE_CLOCK_HIGH;
 
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 4dec9e693218..5b1f6069e5da 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -435,7 +435,10 @@ static int xe3_plane_max_width(const struct drm_framebuffer *fb,
 			       int color_plane,
 			       unsigned int rotation)
 {
-	return 6144;
+	if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
+		return 4096;
+	else
+		return 6144;
 }
 
 static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
-- 
2.47.0


  parent reply	other threads:[~2024-10-15  6:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15  6:10 [PATCH 0/4] Add 6k resolution support for a single CRTC Suraj Kandpal
2024-10-15  6:10 ` [PATCH 1/4] drm/i915/xe3lpd: Increase resolution for plane to support 6k Suraj Kandpal
2024-10-23 21:41   ` Matt Roper
2024-10-24  2:45     ` Kandpal, Suraj
2024-10-15  6:10 ` [PATCH 2/4] drm/i915/xe3lpd: Increase max_h max_v for PSR Suraj Kandpal
2024-10-15  6:10 ` [PATCH 3/4] drm/i914/xe3lpd: Increase bigjoiner limitations Suraj Kandpal
2024-10-15  6:10 ` Suraj Kandpal [this message]
2024-10-15  6:17 ` ✓ CI.Patch_applied: success for Add 6k resolution support for a single CRTC Patchwork
2024-10-15  6:17 ` ✓ CI.checkpatch: " Patchwork
2024-10-15  6:18 ` ✓ CI.KUnit: " Patchwork
2024-10-15  6:30 ` ✓ CI.Build: " Patchwork
2024-10-15  6:32 ` ✓ CI.Hooks: " Patchwork
2024-10-15  6:33 ` ✗ CI.checksparse: warning " Patchwork
2024-10-15 18:33 ` ✗ CI.FULL: failure " Patchwork
2024-10-16  5:05 ` ✓ CI.BAT: success " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-10-24  3:55 [PATCH 0/4] " Suraj Kandpal
2024-10-24  3:55 ` [PATCH 4/4] drm/i915/xe3lpd: Prune modes for YUV420 Suraj Kandpal
2024-10-24 12:20   ` Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241015061011.2087826-5-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    --cc=vandita.kulkarni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox