Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
	Jia Yao <jia.yao@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	Nirmoy Das <nirmoy.das@intel.com>,
	Jonathan Cavitt <jonathan.cavitt@intel.com>,
	Zongyao Bai <zongyao.bai@intel.com>
Subject: [PATCH v4] drm/xe: Enlarge the invalidation timeout from 150 to 500
Date: Tue, 15 Oct 2024 16:12:07 +0000	[thread overview]
Message-ID: <20241015161207.1373401-1-shuicheng.lin@intel.com> (raw)

There are error messages like below that are occurring during stress testing:
"[   31.004009] xe 0000:03:00.0: [drm] ERROR GT0: Global invalidation timeout"
Previously it was hitting this 3 with 1000 executions of warm reboot.
After raising it to 500, 1000 warm reboot executions passed and it didn't
fail.

Due to the way xe_mmio_wait32() is implemented, the timeout is able to expire
early when the register matches the expected value due to the wait increments
starting small. So, the larger timeout value should have no effect during
normal use cases.

v2 (Jonathan):
  - rework the commit message
v3 (Lucas):
  - add conclusive message for the fail rate and test case
v4:
  - add suggested-by

Suggested-by: Jia Yao <jia.yao@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Tested-by: Zongyao Bai <zongyao.bai@intel.com>
---
 drivers/gpu/drm/xe/xe_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 962751c966d1..22b572f0612c 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -925,7 +925,7 @@ void xe_device_l2_flush(struct xe_device *xe)
 	spin_lock(&gt->global_invl_lock);
 	xe_mmio_write32(&gt->mmio, XE2_GLOBAL_INVAL, 0x1);
 
-	if (xe_mmio_wait32(&gt->mmio, XE2_GLOBAL_INVAL, 0x1, 0x0, 150, NULL, true))
+	if (xe_mmio_wait32(&gt->mmio, XE2_GLOBAL_INVAL, 0x1, 0x0, 500, NULL, true))
 		xe_gt_err_once(gt, "Global invalidation timeout\n");
 	spin_unlock(&gt->global_invl_lock);
 
-- 
2.25.1


             reply	other threads:[~2024-10-15 16:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 16:12 Shuicheng Lin [this message]
2024-10-15 17:02 ` ✓ CI.Patch_applied: success for drm/xe: Enlarge the invalidation timeout from 150 to 500 (rev4) Patchwork
2024-10-15 17:03 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-15 17:04 ` ✓ CI.KUnit: success " Patchwork
2024-10-15 17:16 ` ✓ CI.Build: " Patchwork
2024-10-15 17:18 ` ✓ CI.Hooks: " Patchwork
2024-10-15 17:19 ` ✓ CI.checksparse: " Patchwork
2024-10-15 17:44 ` ✓ CI.BAT: " Patchwork
2024-10-16  2:29 ` ✗ CI.FULL: failure " Patchwork
2024-10-16  9:25 ` [PATCH v4] drm/xe: Enlarge the invalidation timeout from 150 to 500 Nirmoy Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241015161207.1373401-1-shuicheng.lin@intel.com \
    --to=shuicheng.lin@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jia.yao@intel.com \
    --cc=jonathan.cavitt@intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.auld@intel.com \
    --cc=nirmoy.das@intel.com \
    --cc=zongyao.bai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox