Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Badal Nilawar <badal.nilawar@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: anshuman.gupta@intel.com, john.c.harrison@intel.com,
	rodrigo.vivi@intel.com, matthew.brost@intel.com,
	himal.prasad.ghimiray@intel.com
Subject: [PATCH v2 1/2] drm/xe/guc/ct: Increase wait timeout for g2h response
Date: Wed, 16 Oct 2024 17:22:55 +0530	[thread overview]
Message-ID: <20241016115256.349791-2-badal.nilawar@intel.com> (raw)
In-Reply-To: <20241016115256.349791-1-badal.nilawar@intel.com>

Occasionally, the G2H worker starts running after a delay of more than
a second even after being queued and activated by the Linux workqueue
subsystem.
To prevent G2H timeout errors, the wait timeout is being increased.

v2: Add comment to describe this change with TODO (Matt B/John H)

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1620
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2902
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_ct.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index c7673f56d413..3096baa4c9f4 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -1016,7 +1016,17 @@ static int guc_ct_send_recv(struct xe_guc_ct *ct, const u32 *action, u32 len,
 		return ret;
 	}
 
-	ret = wait_event_timeout(ct->g2h_fence_wq, g2h_fence.done, HZ);
+	/*
+	 * Occasionally it is seen that the G2H worker starts running after a delay of more than
+	 * a second even after being queued and activated by the Linux workqueue subsystem. This
+	 * leads to G2H timeout error. This is seen especially while running xe_pm and gt reset
+	 * flow which uses xe_guc_ct_send_recv(). To prevent G2H timeout errors, the wait timeout
+	 * is being increased.
+	 *
+	 * TODO: Reduce the timeout Once workqueue scheduling delay issue root caused and fixed.
+	 */
+
+	ret = wait_event_timeout(ct->g2h_fence_wq, g2h_fence.done, HZ * 3);
 
 	/*
 	 * Ensure we serialize with completion side to prevent UAF with fence going out of scope on
-- 
2.34.1


  reply	other threads:[~2024-10-16 11:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16 11:52 [PATCH v2 0/2] Workaround to handle G2H timeout Badal Nilawar
2024-10-16 11:52 ` Badal Nilawar [this message]
2024-10-16 11:52 ` [PATCH v2 2/2] drm/xe/guc/ct: Flush g2h worker in case of g2h response timeout Badal Nilawar
2024-10-16 18:51   ` John Harrison
2024-10-16 18:55     ` John Harrison
2024-10-17  8:36       ` Nilawar, Badal
2024-10-17  8:34     ` Nilawar, Badal
2024-10-16 13:20 ` ✓ CI.Patch_applied: success for Workaround to handle G2H timeout Patchwork
2024-10-16 13:20 ` ✓ CI.checkpatch: " Patchwork
2024-10-16 13:22 ` ✓ CI.KUnit: " Patchwork
2024-10-16 13:33 ` ✓ CI.Build: " Patchwork
2024-10-16 13:35 ` ✓ CI.Hooks: " Patchwork
2024-10-16 13:37 ` ✓ CI.checksparse: " Patchwork
2024-10-16 14:01 ` ✓ CI.BAT: " Patchwork
2024-10-17  5:28 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241016115256.349791-2-badal.nilawar@intel.com \
    --to=badal.nilawar@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=john.c.harrison@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox