From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA9F6D21274 for ; Thu, 17 Oct 2024 10:24:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6AE9010E1D6; Thu, 17 Oct 2024 10:24:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JACcthrm"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7CA0C10E1D6 for ; Thu, 17 Oct 2024 10:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729160676; x=1760696676; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=SOXFtxp3E4emiM6TQ+7nn1cb29gdk7R5RRj2UjeGo0s=; b=JACcthrmZEQ9BVNn6eK8fhOiaRc1H6VQo6Vnt2RzXTZakXS9d1MZK8t0 j518BUyA/aLyxjLPVSHfsGXC68gsDjCIfGG3AM/Yla4tMepPbapneuGlW AlkTjcRSNEIeYHb221IQdQAi68ZY9+9+bVvz9SCDLCgSNhNesAdrAFIde NuFoQELwZQ4a0npPHBp6oSEhxbXJKJXdGScjS9Wpjdr5usU7+cdSghMyT 2tFQdvIo0prN0CnG/hU9fm9gMGRX1VtWbpHI/MuJQcb+ED95bldt3xT9A YQaE4nfU2K7I/o5gf2TCVdGV4tA4My41p+/8Gq+fAQKA5ZMhV8smCqCqJ Q==; X-CSE-ConnectionGUID: OC+lizB1QIO4WZpZeSfhkQ== X-CSE-MsgGUID: u+xw+xePRNSaZ+17TyufoQ== X-IronPort-AV: E=McAfee;i="6700,10204,11227"; a="28110268" X-IronPort-AV: E=Sophos;i="6.11,210,1725346800"; d="scan'208";a="28110268" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2024 03:24:35 -0700 X-CSE-ConnectionGUID: ccfGwN9uR52AAQRLYy1jWQ== X-CSE-MsgGUID: 8V91xVcqQX653dqIfUuWIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,210,1725346800"; d="scan'208";a="83061436" Received: from nirmoyda-desk.igk.intel.com ([10.102.138.190]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2024 03:24:34 -0700 From: Nirmoy Das To: intel-xe@lists.freedesktop.org Cc: Nirmoy Das , Matthew Auld Subject: [PATCH v2] drm/xe/ufence: Kick ufence immediately when possible Date: Thu, 17 Oct 2024 11:42:37 +0200 Message-ID: <20241017094237.279327-1-nirmoy.das@intel.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Organization: Intel Deutschland GmbH, Registered Address: Am Campeon 10, 85579 Neubiberg, Germany, Commercial Register: Amtsgericht Muenchen HRB 186928 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" If the backing fence is signaled then signal ufence soon with system_wq. This should reduce load from the xe ordered_wq and also won't block signaling a ufence which doesn't require any serialization. v2: fix system_wq typo Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1630 Cc: Matthew Auld gc: Matthew Brost Signed-off-by: Nirmoy Das --- drivers/gpu/drm/xe/xe_sync.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c index c6cf227ead40..1a7907293088 100644 --- a/drivers/gpu/drm/xe/xe_sync.c +++ b/drivers/gpu/drm/xe/xe_sync.c @@ -89,10 +89,14 @@ static void user_fence_worker(struct work_struct *w) user_fence_put(ufence); } -static void kick_ufence(struct xe_user_fence *ufence, struct dma_fence *fence) +static void kick_ufence(struct xe_user_fence *ufence, struct dma_fence *fence, + bool signaled) { INIT_WORK(&ufence->worker, user_fence_worker); - queue_work(ufence->xe->ordered_wq, &ufence->worker); + if (signaled) + queue_work(system_wq, &ufence->worker); + else + queue_work(ufence->xe->ordered_wq, &ufence->worker); dma_fence_put(fence); } @@ -100,7 +104,7 @@ static void user_fence_cb(struct dma_fence *fence, struct dma_fence_cb *cb) { struct xe_user_fence *ufence = container_of(cb, struct xe_user_fence, cb); - kick_ufence(ufence, fence); + kick_ufence(ufence, fence, false); } int xe_sync_entry_parse(struct xe_device *xe, struct xe_file *xef, @@ -236,7 +240,7 @@ void xe_sync_entry_signal(struct xe_sync_entry *sync, struct dma_fence *fence) err = dma_fence_add_callback(fence, &sync->ufence->cb, user_fence_cb); if (err == -ENOENT) { - kick_ufence(sync->ufence, fence); + kick_ufence(sync->ufence, fence, true); } else if (err) { XE_WARN_ON("failed to add user fence"); user_fence_put(sync->ufence); -- 2.46.0