From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29DCCD3C526 for ; Thu, 17 Oct 2024 17:06:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEEB310E88F; Thu, 17 Oct 2024 17:06:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="O+oFGDfH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id B66C310E88F for ; Thu, 17 Oct 2024 17:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729184813; x=1760720813; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Bgky6O5S8BPWuqpVWvYI95IaD5namK1MCB0NpzSDohY=; b=O+oFGDfHvCP/5SRy189DWZPUBLQ6O8v6X7EvzPIGY6CMqBuD9MJdFz50 kAT0RBA/t+2WLpQtOiQVsd28A7Cvypv1bZf2U6wsqYgrD/Mspg2pVgbCq 9s5Q50vR9aII9ZVBVL8C/OBZ1L22TQSTNEWpaWybjI4puEGIF7+cL+wTk a/QgDzaVpgc2yWYAl/RAce2mBIyAdyq+kZaiCMYEkUJtDkgyXbFlkPPQf 8pgK3qrb83ZdnImoovCzL1WsOuhdvE4+50geno87wJ1xVlQ56rJeNhs9F oS+1SMRIGArij63ZgFlGzcuviIoWDg5ziWQnzAMheTjjdAiaiwf2RVmGI g==; X-CSE-ConnectionGUID: wZlYzQwjReuSVMs8Yc0nAA== X-CSE-MsgGUID: NZj0ylHfSHO+QGaQp+GjjQ== X-IronPort-AV: E=McAfee;i="6700,10204,11228"; a="31551896" X-IronPort-AV: E=Sophos;i="6.11,211,1725346800"; d="scan'208";a="31551896" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2024 10:06:53 -0700 X-CSE-ConnectionGUID: 64u9Goa2RpWrPW3lIHqL9w== X-CSE-MsgGUID: u3wMfPjKSkGHA9f4D+NXHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,211,1725346800"; d="scan'208";a="101919710" Received: from osgc-linux-buildserver.sh.intel.com ([10.112.232.61]) by fmviesa002.fm.intel.com with ESMTP; 17 Oct 2024 10:06:48 -0700 From: Shuicheng Lin To: intel-xe@lists.freedesktop.org Cc: Shuicheng Lin , Alex Zuo , Matthew Brost , Michal Wajdeczko , Himal Prasad Ghimiray , Matt Roper , Rodrigo Vivi Subject: [PATCH v3] drm/xe: Handle unreliable MMIO reads during forcewake Date: Thu, 17 Oct 2024 16:30:38 +0000 Message-Id: <20241017163038.1554591-1-shuicheng.lin@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241017034026.1525693-1-shuicheng.lin@intel.com> References: <20241017034026.1525693-1-shuicheng.lin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" In some cases, when the driver attempts to read an MMIO register, the hardware may return 0xFFFFFFFF. The current force wake path code treats this as a valid response, as it only checks the BIT. However, 0xFFFFFFFF should be considered an invalid value, indicating a potential issue. To address this, we should add a log entry to highlight this condition and return failure. The force wake failure log level is changed from notice to err to match the failure return value. v2 (Matt Brost): - set ret value (-EIO) to kick the error to upper layers v3 (Rodrigo): - add commit message for the log level promotion from notice to err Suggested-by: Alex Zuo Signed-off-by: Shuicheng Lin Cc: Matthew Brost Cc: Michal Wajdeczko Cc: Himal Prasad Ghimiray Cc: Matt Roper Cc: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_force_wake.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_force_wake.c b/drivers/gpu/drm/xe/xe_force_wake.c index a64c14757c84..08621717b14b 100644 --- a/drivers/gpu/drm/xe/xe_force_wake.c +++ b/drivers/gpu/drm/xe/xe_force_wake.c @@ -115,9 +115,15 @@ static int __domain_wait(struct xe_gt *gt, struct xe_force_wake_domain *domain, XE_FORCE_WAKE_ACK_TIMEOUT_MS * USEC_PER_MSEC, &value, true); if (ret) - xe_gt_notice(gt, "Force wake domain %d failed to ack %s (%pe) reg[%#x] = %#x\n", - domain->id, str_wake_sleep(wake), ERR_PTR(ret), - domain->reg_ack.addr, value); + xe_gt_err(gt, "Force wake domain %d failed to ack %s (%pe) reg[%#x] = %#x\n", + domain->id, str_wake_sleep(wake), ERR_PTR(ret), + domain->reg_ack.addr, value); + if (value == ~0) { + xe_gt_err(gt, + "Force wake domain %d: %s. MMIO unreliable (forcewake register returns 0xFFFFFFFF)!\n", + domain->id, str_wake_sleep(wake)); + ret = -EIO; + } return ret; } -- 2.25.1