Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI v2 1/4] drm/xe: Remove double pageflip
Date: Fri, 18 Oct 2024 19:06:28 +0200	[thread overview]
Message-ID: <20241018170631.6598-2-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20241018170631.6598-1-maarten.lankhorst@linux.intel.com>

This is already handled below by fixup_initial_plane_config.

Fixes: a8153627520a ("drm/i915: Try to relocate the BIOS fb to the start of ggtt")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/xe/display/xe_plane_initial.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index 8c113463a3d55..668f544a7ac80 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -194,8 +194,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 		to_intel_plane(crtc->base.primary);
 	struct intel_plane_state *plane_state =
 		to_intel_plane_state(plane->base.state);
-	struct intel_crtc_state *crtc_state =
-		to_intel_crtc_state(crtc->base.state);
 	struct drm_framebuffer *fb;
 	struct i915_vma *vma;
 
@@ -241,14 +239,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 	atomic_or(plane->frontbuffer_bit, &to_intel_frontbuffer(fb)->bits);
 
 	plane_config->vma = vma;
-
-	/*
-	 * Flip to the newly created mapping ASAP, so we can re-use the
-	 * first part of GGTT for WOPCM, prevent flickering, and prevent
-	 * the lookup of sysmem scratch pages.
-	 */
-	plane->check_plane(crtc_state, plane_state);
-	plane->async_flip(NULL, plane, crtc_state, plane_state, true);
 	return;
 
 nofb:
-- 
2.45.2


  reply	other threads:[~2024-10-18 17:06 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 17:06 [CI v2 0/4] (CI) drm/xe: Fix initial framebuffer handover Maarten Lankhorst
2024-10-18 17:06 ` Maarten Lankhorst [this message]
2024-10-18 17:12   ` [CI v2 1/4] drm/xe: Remove double pageflip Lucas De Marchi
2024-10-18 17:06 ` [CI v2 2/4] drm/i915/display: Use async flip when available for initial plane config Maarten Lankhorst
2024-10-18 17:14   ` Lucas De Marchi
2024-10-18 17:06 ` [CI v2 3/4] drm/xe: Move suballocator init to after display init Maarten Lankhorst
2024-10-18 17:30   ` Lucas De Marchi
2024-10-18 17:06 ` [CI v2 4/4] drm/xe: Initialise display before GT and tile init Maarten Lankhorst
2024-10-18 17:40   ` Lucas De Marchi
2024-10-18 20:05   ` [CI v2.2] " Maarten Lankhorst
2024-10-21 10:38     ` [CI v2.3] " Maarten Lankhorst
2024-10-24 13:46       ` [PATCH] " Maarten Lankhorst
2024-10-24 15:15       ` Maarten Lankhorst
2024-10-25 10:14         ` Maarten Lankhorst
2024-10-25 13:04           ` Maarten Lankhorst
2024-10-18 18:08 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover Patchwork
2024-10-18 18:08 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-18 18:10 ` ✓ CI.KUnit: success " Patchwork
2024-10-18 18:21 ` ✓ CI.Build: " Patchwork
2024-10-18 18:23 ` ✓ CI.Hooks: " Patchwork
2024-10-18 18:25 ` ✗ CI.checksparse: warning " Patchwork
2024-10-18 18:45 ` ✗ CI.BAT: failure " Patchwork
2024-10-18 21:25 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev2) Patchwork
2024-10-18 21:25 ` ✓ CI.checkpatch: " Patchwork
2024-10-18 21:27 ` ✓ CI.KUnit: " Patchwork
2024-10-18 21:38 ` ✓ CI.Build: " Patchwork
2024-10-18 21:40 ` ✓ CI.Hooks: " Patchwork
2024-10-18 21:42 ` ✗ CI.checksparse: warning " Patchwork
2024-10-18 22:04 ` ✗ CI.BAT: failure " Patchwork
2024-10-19 11:17 ` ✗ CI.FULL: failure for (CI) drm/xe: Fix initial framebuffer handover Patchwork
2024-10-19 14:41 ` ✗ CI.FULL: failure for (CI) drm/xe: Fix initial framebuffer handover. (rev2) Patchwork
2024-10-21 10:50 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev3) Patchwork
2024-10-21 10:50 ` ✓ CI.checkpatch: " Patchwork
2024-10-21 10:52 ` ✓ CI.KUnit: " Patchwork
2024-10-21 11:03 ` ✓ CI.Build: " Patchwork
2024-10-21 11:06 ` ✓ CI.Hooks: " Patchwork
2024-10-21 11:07 ` ✗ CI.checksparse: warning " Patchwork
2024-10-21 11:36 ` ✓ CI.BAT: success " Patchwork
2024-10-21 15:59 ` ✗ CI.FULL: failure " Patchwork
2024-10-25  1:30 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev5) Patchwork
2024-10-25  1:30 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-25  1:31 ` ✗ CI.KUnit: failure " Patchwork
2024-10-25 11:29 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev6) Patchwork
2024-10-25 11:29 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-25 11:30 ` ✓ CI.KUnit: success " Patchwork
2024-10-25 11:42 ` ✓ CI.Build: " Patchwork
2024-10-25 11:44 ` ✓ CI.Hooks: " Patchwork
2024-10-25 11:46 ` ✗ CI.checksparse: warning " Patchwork
2024-10-25 12:14 ` ✗ CI.BAT: failure " Patchwork
2024-10-25 13:11 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev7) Patchwork
2024-10-25 13:11 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-25 13:13 ` ✓ CI.KUnit: success " Patchwork
2024-10-25 13:24 ` ✓ CI.Build: " Patchwork
2024-10-25 13:27 ` ✓ CI.Hooks: " Patchwork
2024-10-25 13:28 ` ✗ CI.checksparse: warning " Patchwork
2024-10-25 13:54 ` ✗ CI.BAT: failure " Patchwork
2024-10-26 23:39 ` ✗ CI.FULL: failure for (CI) drm/xe: Fix initial framebuffer handover. (rev6) Patchwork
2024-10-27  1:46 ` ✗ CI.FULL: failure for (CI) drm/xe: Fix initial framebuffer handover. (rev7) Patchwork
2024-10-29 11:40 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018170631.6598-2-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox