Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Zhanjun Dong <zhanjun.dong@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Zhanjun Dong <zhanjun.dong@intel.com>
Subject: [PATCH v1 1/1] drm/xe/guc: Prevent GuC register capture running on VF
Date: Fri, 18 Oct 2024 15:43:25 -0700	[thread overview]
Message-ID: <20241018224325.130754-2-zhanjun.dong@intel.com> (raw)
In-Reply-To: <20241018224325.130754-1-zhanjun.dong@intel.com>

GuC based register capture is not supported by VF, thus prevent it
running on VF.

Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_capture.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_capture.c b/drivers/gpu/drm/xe/xe_guc_capture.c
index 41262bda20ed..5c0d9efaaab4 100644
--- a/drivers/gpu/drm/xe/xe_guc_capture.c
+++ b/drivers/gpu/drm/xe/xe_guc_capture.c
@@ -1590,6 +1590,9 @@ xe_engine_manual_capture(struct xe_hw_engine *hwe, struct xe_hw_engine_snapshot
 	u16 guc_id = 0;
 	u32 lrca = 0;
 
+	if (IS_SRIOV_VF(xe))
+		return;
+
 	new = guc_capture_get_prealloc_node(guc);
 	if (!new)
 		return;
@@ -1756,7 +1759,7 @@ void xe_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot, struct drm
 	devcoredump = &xe->devcoredump;
 	devcore_snapshot = &devcoredump->snapshot;
 
-	if (!devcore_snapshot->matched_node)
+	if (IS_SRIOV_VF(xe) || !devcore_snapshot->matched_node)
 		return;
 
 	xe_gt_assert(gt, snapshot->source <= XE_ENGINE_CAPTURE_SOURCE_GUC);
@@ -1820,7 +1823,7 @@ xe_guc_capture_get_matching_and_lock(struct xe_sched_job *job)
 		return NULL;
 
 	xe = gt_to_xe(q->gt);
-	if (xe->wedged.mode >= 2 || !xe_device_uc_enabled(xe))
+	if (xe->wedged.mode >= 2 || !xe_device_uc_enabled(xe) || IS_SRIOV_VF(xe))
 		return NULL;
 
 	ss = &xe->devcoredump.snapshot;
@@ -1876,6 +1879,9 @@ xe_engine_snapshot_capture_for_job(struct xe_sched_job *job)
 	enum xe_hw_engine_id id;
 	u32 adj_logical_mask = q->logical_mask;
 
+	if (IS_SRIOV_VF(xe))
+		return;
+
 	for_each_hw_engine(hwe, q->gt, id) {
 		if (hwe->class != q->hwe->class ||
 		    !(BIT(hwe->logical_instance) & adj_logical_mask)) {
@@ -1922,6 +1928,9 @@ void xe_guc_capture_put_matched_nodes(struct xe_guc *guc)
 	struct xe_devcoredump *devcoredump = &xe->devcoredump;
 	struct __guc_capture_parsed_output *n = devcoredump->snapshot.matched_node;
 
+	if (IS_SRIOV_VF(xe))
+		return;
+
 	if (n) {
 		guc_capture_remove_stale_matches_from_list(guc->capture, n);
 		guc_capture_free_outlist_node(guc->capture, n);
-- 
2.34.1


  reply	other threads:[~2024-10-18 22:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 22:43 [PATCH v1 0/1] drm/xe/guc: Prevent GuC register capture running on VF Zhanjun Dong
2024-10-18 22:43 ` Zhanjun Dong [this message]
2024-10-21 18:27   ` [PATCH v1 1/1] " Teres Alexis, Alan Previn
2024-10-21 19:43   ` Michal Wajdeczko
2024-10-22  0:03     ` Dong, Zhanjun
2024-10-18 23:30 ` ✓ CI.Patch_applied: success for drm/xe/guc: Prevent GuC register capture running on VF (rev2) Patchwork
2024-10-18 23:31 ` ✓ CI.checkpatch: " Patchwork
2024-10-18 23:32 ` ✓ CI.KUnit: " Patchwork
2024-10-18 23:50 ` ✓ CI.Build: " Patchwork
2024-10-18 23:53 ` ✓ CI.Hooks: " Patchwork
2024-10-18 23:54 ` ✓ CI.checksparse: " Patchwork
2024-10-19  0:30 ` ✓ CI.BAT: " Patchwork
2024-10-19 18:07 ` ✗ CI.FULL: failure " Patchwork
2024-10-21 19:14   ` Dong, Zhanjun
  -- strict thread matches above, loose matches on Subject: below --
2024-10-18 22:43 [PATCH v1 0/1] drm/xe/guc: Prevent GuC register capture running on VF Zhanjun Dong
2024-10-18 22:43 ` [PATCH v1 1/1] " Zhanjun Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018224325.130754-2-zhanjun.dong@intel.com \
    --to=zhanjun.dong@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox