Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: mika.kuoppala@intel.com, matthew.auld@intel.com,
	thomas.hellstrom@linux.intel.com
Subject: [PATCH v4 1/9] drm/xe: Add xe_bo_vm_access
Date: Mon, 21 Oct 2024 13:15:01 -0700	[thread overview]
Message-ID: <20241021201509.1668074-2-matthew.brost@intel.com> (raw)
In-Reply-To: <20241021201509.1668074-1-matthew.brost@intel.com>

Add xe_bo_vm_access which is wrapper around ttm_bo_vm_access which takes
rpm refs for device access.

Suggested-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_bo.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 5b232f2951b1..0261a8b29351 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -1236,11 +1236,26 @@ static vm_fault_t xe_gem_fault(struct vm_fault *vmf)
 	return ret;
 }
 
+static int xe_bo_vm_access(struct vm_area_struct *vma, unsigned long addr,
+			   void *buf, int len, int write)
+{
+	struct ttm_buffer_object *ttm_bo = vma->vm_private_data;
+	struct xe_bo *bo = ttm_to_xe_bo(ttm_bo);
+	struct xe_device *xe = xe_bo_device(bo);
+	int ret;
+
+	xe_pm_runtime_get(xe);
+	ret = ttm_bo_vm_access(vma, addr, buf, len, write);
+	xe_pm_runtime_put(xe);
+
+	return ret;
+}
+
 static const struct vm_operations_struct xe_gem_vm_ops = {
 	.fault = xe_gem_fault,
 	.open = ttm_bo_vm_open,
 	.close = ttm_bo_vm_close,
-	.access = ttm_bo_vm_access
+	.access = xe_bo_vm_access,
 };
 
 static const struct drm_gem_object_funcs xe_gem_object_funcs = {
-- 
2.34.1


  reply	other threads:[~2024-10-21 20:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 20:15 [PATCH v4 0/9] Fix non-contiguous VRAM BO access in Xe Matthew Brost
2024-10-21 20:15 ` Matthew Brost [this message]
2024-10-21 20:15 ` [PATCH v4 2/9] drm/ttm: Add ttm_bo_access Matthew Brost
2024-10-21 20:15 ` [PATCH v4 3/9] drm/xe: Add xe_ttm_access_memory Matthew Brost
2024-10-21 20:15 ` [PATCH v4 4/9] drm/xe: Take PM ref in delayed snapshot capture worker Matthew Brost
2024-10-21 20:15 ` [PATCH v4 5/9] drm/xe: Update xe_ttm_access_memory to use GPU for non-visible access Matthew Brost
2024-10-21 20:15 ` [PATCH v4 6/9] drm/xe/display: Update intel_bo_read_from_page to use ttm_bo_access Matthew Brost
2024-10-21 20:15 ` [PATCH v4 7/9] drm/xe: Use ttm_bo_access in xe_vm_snapshot_capture_delayed Matthew Brost
2024-10-21 20:15 ` [PATCH v4 8/9] drm/xe: Set XE_BO_FLAG_PINNED in migrate selftest BOs Matthew Brost
2024-10-21 20:15 ` [PATCH v4 9/9] drm/xe: Only allow contiguous BOs to use xe_bo_vmap Matthew Brost
2024-10-21 20:19 ` ✓ CI.Patch_applied: success for Fix non-contiguous VRAM BO access in Xe (rev4) Patchwork
2024-10-21 20:19 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-21 20:21 ` ✓ CI.KUnit: success " Patchwork
2024-10-21 20:32 ` ✓ CI.Build: " Patchwork
2024-10-21 20:34 ` ✗ CI.Hooks: failure " Patchwork
2024-10-21 20:36 ` ✗ CI.checksparse: warning " Patchwork
2024-10-21 20:54 ` ✓ CI.BAT: success " Patchwork
2024-10-22  2:17 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241021201509.1668074-2-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=mika.kuoppala@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox