Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: paulo.r.zanoni@intel.com
Subject: [PATCH 1/1] drm/xe: Don't short circuit TDR on jobs not started
Date: Tue, 22 Oct 2024 16:27:56 -0700	[thread overview]
Message-ID: <20241022232756.1769013-2-matthew.brost@intel.com> (raw)
In-Reply-To: <20241022232756.1769013-1-matthew.brost@intel.com>

Short circuiting TDR on jobs not started is an optimization which is not
required. On LNL we are facing an issue where jobs do not get scheduled
by the GuC for an unknown reason. Removing this optimization allows jobs
to get scheduled after TDR fire once which is a big improvement. Remove
this optimization for now while root causing job scheduling issue on
LNL.

Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 0b81972ff651..25ab675e9c7d 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1052,10 +1052,6 @@ guc_exec_queue_timedout_job(struct drm_sched_job *drm_job)
 		exec_queue_killed_or_banned_or_wedged(q) ||
 		exec_queue_destroyed(q);
 
-	/* Job hasn't started, can't be timed out */
-	if (!skip_timeout_check && !xe_sched_job_started(job))
-		goto rearm;
-
 	/*
 	 * If devcoredump not captured and GuC capture for the job is not ready
 	 * do manual capture first and decide later if we need to use it
-- 
2.34.1


  reply	other threads:[~2024-10-22 23:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 23:27 [PATCH 0/1] Don't short circuit TDR on jobs not started Matthew Brost
2024-10-22 23:27 ` Matthew Brost [this message]
2024-10-23 16:47   ` [PATCH 1/1] drm/xe: " Zanoni, Paulo R
2024-10-23 17:41     ` Matthew Brost
2024-10-25 19:32       ` Zanoni, Paulo R
2024-10-25 19:59         ` Matthew Brost
2024-10-25 23:21           ` John Harrison
2024-10-22 23:32 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-22 23:32 ` ✓ CI.checkpatch: " Patchwork
2024-10-22 23:33 ` ✓ CI.KUnit: " Patchwork
2024-10-22 23:45 ` ✓ CI.Build: " Patchwork
2024-10-22 23:47 ` ✓ CI.Hooks: " Patchwork
2024-10-22 23:49 ` ✓ CI.checksparse: " Patchwork
2024-10-23  0:09 ` ✓ CI.BAT: " Patchwork
2024-10-23  5:28 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241022232756.1769013-2-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox