Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, matthew.d.roper@intel.com,
	daniele.ceraolospurio@intel.com,
	Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH] drm/xe/hdcp: Fix gsc structure check in fw check status
Date: Fri, 25 Oct 2024 21:38:35 +0530	[thread overview]
Message-ID: <20241025160834.8785-1-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20241022072920.102033-1-suraj.kandpal@intel.com>

Fix the condition for gsc structure validity in
gsc_cs_status_check(). It needs to be an OR and not an AND
condition

Fixes: b4224f6bae38 ("drm/xe/hdcp: Check GSC structure validity")
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
index 6d34b55d72bb..7c02323e9531 100644
--- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
+++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
@@ -44,7 +44,7 @@ bool intel_hdcp_gsc_check_status(struct intel_display *display)
 	bool ret = true;
 	unsigned int fw_ref;
 
-	if (!gsc && !xe_uc_fw_is_enabled(&gsc->fw)) {
+	if (!gsc || !xe_uc_fw_is_enabled(&gsc->fw)) {
 		drm_dbg_kms(&xe->drm,
 			    "GSC Components not ready for HDCP2.x\n");
 		return false;
-- 
2.34.1


  parent reply	other threads:[~2024-10-25 16:09 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22  5:56 [PATCH] drm/xe/hdcp: Add check to remove hdcp2 compatibilty Suraj Kandpal
2024-10-22  6:02 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-22  6:02 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-22  6:03 ` ✓ CI.KUnit: success " Patchwork
2024-10-22  6:03 ` [PATCH] " Nautiyal, Ankit K
2024-10-22  6:08 ` ✗ CI.Build: failure for " Patchwork
2024-10-22  6:09 ` [PATCH] " Ghimiray, Himal Prasad
2024-10-22  6:26 ` Nilawar, Badal
2024-10-22  7:44   ` Jani Nikula
2024-10-22  8:26     ` Nilawar, Badal
2024-10-22  6:38 ` ✓ CI.Patch_applied: success for drm/xe/hdcp: Add check to remove hdcp2 compatibilty (rev2) Patchwork
2024-10-22  6:38 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-22  6:39 ` ✓ CI.KUnit: success " Patchwork
2024-10-22  6:44 ` ✗ CI.Build: failure " Patchwork
2024-10-22  7:29 ` [PATCH] drm/xe/hdcp: Add check to remove hdcp2 compatibility Suraj Kandpal
2024-10-22  7:46   ` Jani Nikula
2024-10-22  8:53     ` Kandpal, Suraj
2024-10-24  7:58       ` Jani Nikula
2024-10-22  8:22   ` Ghimiray, Himal Prasad
2024-10-23 19:45   ` Matt Roper
2024-10-24  2:42     ` Kandpal, Suraj
2024-10-24 15:33   ` Daniele Ceraolo Spurio
2024-10-25  1:21     ` Kandpal, Suraj
2024-10-25 15:04       ` Daniele Ceraolo Spurio
2024-10-25 15:59         ` Kandpal, Suraj
2024-10-25 16:08   ` Suraj Kandpal [this message]
2024-10-25 16:12     ` [PATCH] drm/xe/hdcp: Fix gsc structure check in fw check status Matt Roper
2024-10-28 12:03     ` Jani Nikula
2024-10-22  7:34 ` ✓ CI.Patch_applied: success for drm/xe/hdcp: Add check to remove hdcp2 compatibilty (rev3) Patchwork
2024-10-22  7:34 ` ✓ CI.checkpatch: " Patchwork
2024-10-22  7:35 ` ✓ CI.KUnit: " Patchwork
2024-10-22  7:47 ` ✓ CI.Build: " Patchwork
2024-10-22  7:49 ` ✓ CI.Hooks: " Patchwork
2024-10-22  7:51 ` ✗ CI.checksparse: warning " Patchwork
2024-10-22  8:16 ` ✓ CI.BAT: success " Patchwork
2024-10-22 11:12 ` ✗ CI.FULL: failure " Patchwork
2024-10-22 22:04 ` [PATCH] drm/xe/hdcp: Add check to remove hdcp2 compatibilty kernel test robot
2024-10-25 16:22 ` ✓ CI.Patch_applied: success for drm/xe/hdcp: Add check to remove hdcp2 compatibilty (rev4) Patchwork
2024-10-25 16:22 ` ✓ CI.checkpatch: " Patchwork
2024-10-25 16:23 ` ✓ CI.KUnit: " Patchwork
2024-10-25 16:35 ` ✓ CI.Build: " Patchwork
2024-10-25 16:37 ` ✓ CI.Hooks: " Patchwork
2024-10-25 16:39 ` ✓ CI.checksparse: " Patchwork
2024-10-25 17:02 ` ✓ CI.BAT: " Patchwork
2024-10-27  5:41 ` ✗ CI.FULL: failure " Patchwork
2024-10-28  4:19 ` ✓ CI.Patch_applied: success for drm/xe/hdcp: Add check to remove hdcp2 compatibilty (rev5) Patchwork
2024-10-28  4:19 ` ✓ CI.checkpatch: " Patchwork
2024-10-28  4:20 ` ✓ CI.KUnit: " Patchwork
2024-10-28  4:32 ` ✓ CI.Build: " Patchwork
2024-10-28  4:34 ` ✓ CI.Hooks: " Patchwork
2024-10-28  4:36 ` ✓ CI.checksparse: " Patchwork
2024-10-28  4:59 ` ✓ CI.BAT: " Patchwork
2024-10-28  5:53 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025160834.8785-1-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox