From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3FA9E6B245 for ; Fri, 1 Nov 2024 11:47:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9778710E9B7; Fri, 1 Nov 2024 11:47:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MV2hDc+M"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id EBC6810E9B8; Fri, 1 Nov 2024 11:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730461676; x=1761997676; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=X8S0eKO7OEtk7uEtze88lcEDfJiOg0jgEvrEfL3DSlw=; b=MV2hDc+M5zeqihaYuC89a1h5CxyugfRmJo1vAT0jOqhomSH/Pk3fHnep Bt4VQXK3tTZpa4gPD4aDKZ7xtLqMhsWGhKO50jNjn77vqiUTqC1mHkg5a ugUs1sWwd/vXeUj6sh+QpXoX/4AaSdFsfzs1sJgTdVOkYZMxi67O4dD26 gUlYb8/QlDBCHStuH3gQtTz6OZvShXd2OUz5nRWImRiKCVuJmyWjAKBOR v8k2YCrtt1UMon+bHgjmcP+mfh1mRs1LqeA49iJcyK8yTDgOdD+r7tiys hoJ0H4yQC0TNuERPFS+AAmSeVGonS697jnBq4EHYn+6vGKEC2pqWO6k+7 A==; X-CSE-ConnectionGUID: AAqS/qFESxKyoK7i76wYbQ== X-CSE-MsgGUID: AcCeTGQDS3y6onoiJeMdtw== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="41324558" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="41324558" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2024 04:47:55 -0700 X-CSE-ConnectionGUID: 59GjTT1xTN2SzKDIjFD+3g== X-CSE-MsgGUID: TrgEMChUT5S95L+20ptetA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,249,1725346800"; d="scan'208";a="82626598" Received: from carterle-desk.ger.corp.intel.com (HELO fedora..) ([10.245.246.239]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2024 04:47:53 -0700 From: =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= To: intel-xe@lists.freedesktop.org Cc: =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Matthew Brost , Somalapuram Amaranath , =?UTF-8?q?Christian=20K=C3=B6nig?= , Paulo Zanoni , Simona Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH v12 8/8] drm/xe: Increase the XE_PL_TT watermark Date: Fri, 1 Nov 2024 12:47:19 +0100 Message-ID: <20241101114719.3225-9-thomas.hellstrom@linux.intel.com> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241101114719.3225-1-thomas.hellstrom@linux.intel.com> References: <20241101114719.3225-1-thomas.hellstrom@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The XE_PL_TT watermark was set to 50% of system memory. The idea behind that was unclear since the net effect is that TT memory will be evicted to TTM_PL_SYSTEM memory if that watermark is exceeded, requiring PPGTT rebinds and dma remapping. But there is no similar watermark for TTM_PL_1SYSTEM memory. The TTM functionality that tries to swap out system memory to shmem objects if a 50% limit of total system memory is reached is orthogonal to this, and with the shrinker added, it's no longer in effect. Replace the 50% TTM_PL_TT limit with a 100% limit, in effect allowing all graphics memory to be bound to the device unless it has been swapped out by the shrinker. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Brost --- drivers/gpu/drm/xe/xe_ttm_sys_mgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c index 9844a8edbfe1..d38b91872da3 100644 --- a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c +++ b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c @@ -108,9 +108,8 @@ int xe_ttm_sys_mgr_init(struct xe_device *xe) u64 gtt_size; si_meminfo(&si); + /* Potentially restrict amount of TT memory here. */ gtt_size = (u64)si.totalram * si.mem_unit; - /* TTM limits allocation of all TTM devices by 50% of system memory */ - gtt_size /= 2; man->use_tt = true; man->func = &xe_ttm_sys_mgr_func; -- 2.46.2