From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6EF0D1CA13 for ; Tue, 5 Nov 2024 00:38:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7476E10E157; Tue, 5 Nov 2024 00:38:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SkU+pmzh"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 768F610E157 for ; Tue, 5 Nov 2024 00:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730767085; x=1762303085; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=8+ZdvZRNjdoNnZ7vcfpl0e8ZHfEOgiefQpM8uFNLHeI=; b=SkU+pmzhUGuHCWn2LRbxYUjmywnzwuhGyyINaIYSVjvj6WDxOR+zKmxD axqdcG5QbcD0LrFyc2vPBzTe+VT30BMoDrmIlmgrP+2qRq4z/2pB+bieD rjCAinY+ZwKeU5jR01FcqAMWRXPIGbr3K+mt1XsOFNrBour2vFWOz9Os/ EQANF4bZ184BjpIzP9u4/CyqQaE3J7+2r8IHRlFAgGpaz3KnNxsEmlPIv d9ys3D7Dm/sA4FFawfSsgRparyzmyR6D9rtE87niBY41RkmjQrIkf/DZ2 R/FFHzqyGONnNxi6eKHpd633rpn1aDsRLogRNE8/3EJSk2ibG98AG3ghK w==; X-CSE-ConnectionGUID: U5DpbVlKTF69j66bUoRGRQ== X-CSE-MsgGUID: ZMUHTbFlRA2BSPvandYOCQ== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="34181158" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="34181158" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2024 16:38:04 -0800 X-CSE-ConnectionGUID: 0si/sGBVSAG1SFcoEC7yxw== X-CSE-MsgGUID: o71L+BG4StSq+Clp1VTz6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,258,1725346800"; d="scan'208";a="83756449" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2024 16:38:04 -0800 From: Matthew Brost To: intel-xe@lists.freedesktop.org Subject: [PATCH 2/2] drm/xe: Drop VM dma-resv lock on xe_sync_in_fence_get failure in exec IOCTL Date: Mon, 4 Nov 2024 16:38:31 -0800 Message-Id: <20241105003832.4021758-3-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241105003832.4021758-1-matthew.brost@intel.com> References: <20241105003832.4021758-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Upon failure all locks need to be dropped before returning to the user. Fixes: 58480c1c912f ("drm/xe: Skip VMAs pin when requesting signal to the last XE_EXEC") Cc: stable Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/xe_exec.c b/drivers/gpu/drm/xe/xe_exec.c index 6de12f91b865..756b492f13b0 100644 --- a/drivers/gpu/drm/xe/xe_exec.c +++ b/drivers/gpu/drm/xe/xe_exec.c @@ -224,6 +224,7 @@ int xe_exec_ioctl(struct drm_device *dev, void *data, struct drm_file *file) fence = xe_sync_in_fence_get(syncs, num_syncs, q, vm); if (IS_ERR(fence)) { err = PTR_ERR(fence); + xe_vm_unlock(vm); goto err_unlock_list; } for (i = 0; i < num_syncs; i++) -- 2.34.1