From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, Clint Taylor <clinton.a.taylor@intel.com>,
Imre Deak <imre.deak@intel.com>
Subject: [PATCH] drm/i915/dp: demote source OUI read/write failure logging to debug
Date: Wed, 6 Nov 2024 18:23:25 +0200 [thread overview]
Message-ID: <20241106162325.4065078-1-jani.nikula@intel.com> (raw)
Commit 1f12d63a14d7 ("drm/i915/dp: Write the source OUI for non-eDP
sinks as well") started writing source OUI for non-eDP sinks as well,
increasing the possibilities of hitting read/write failures either due
to the sink behaviour or hotplug or whatever.
Even before that, commit 3fb0501f0c07 ("drm/i915/display/dp: Reduce log
level for SOURCE OUI write failures") already reduced write failures to
info level when source OUI was just for eDP.
Further reduce the log level to just debug. Switch to struct intel_dp
while at it.
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3372
Cc: Clint Taylor <clinton.a.taylor@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 5b918363df16..95c71e425fbe 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3432,7 +3432,7 @@ void intel_dp_sink_disable_decompression(struct intel_atomic_state *state,
static void
intel_dp_init_source_oui(struct intel_dp *intel_dp)
{
- struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+ struct intel_display *display = to_intel_display(intel_dp);
u8 oui[] = { 0x00, 0xaa, 0x01 };
u8 buf[3] = {};
@@ -3446,7 +3446,7 @@ intel_dp_init_source_oui(struct intel_dp *intel_dp)
* already set to what we want, so as to avoid clearing any state by accident
*/
if (drm_dp_dpcd_read(&intel_dp->aux, DP_SOURCE_OUI, buf, sizeof(buf)) < 0)
- drm_err(&i915->drm, "Failed to read source OUI\n");
+ drm_dbg_kms(display->drm, "Failed to read source OUI\n");
if (memcmp(oui, buf, sizeof(oui)) == 0) {
/* Assume the OUI was written now. */
@@ -3455,7 +3455,7 @@ intel_dp_init_source_oui(struct intel_dp *intel_dp)
}
if (drm_dp_dpcd_write(&intel_dp->aux, DP_SOURCE_OUI, oui, sizeof(oui)) < 0) {
- drm_info(&i915->drm, "Failed to write source OUI\n");
+ drm_dbg_kms(display->drm, "Failed to write source OUI\n");
WRITE_ONCE(intel_dp->oui_valid, false);
}
--
2.39.5
next reply other threads:[~2024-11-06 16:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 16:23 Jani Nikula [this message]
2024-11-06 16:51 ` ✓ CI.Patch_applied: success for drm/i915/dp: demote source OUI read/write failure logging to debug Patchwork
2024-11-06 16:51 ` ✓ CI.checkpatch: " Patchwork
2024-11-06 16:52 ` ✓ CI.KUnit: " Patchwork
2024-11-06 17:04 ` ✓ CI.Build: " Patchwork
2024-11-06 17:06 ` ✓ CI.Hooks: " Patchwork
2024-11-06 17:08 ` ✗ CI.checksparse: warning " Patchwork
2024-11-06 17:24 ` [PATCH] " Matt Roper
2024-11-11 8:58 ` Jani Nikula
2024-11-06 17:34 ` ✗ CI.BAT: failure for " Patchwork
2024-11-08 9:10 ` Jani Nikula
2024-11-08 10:39 ` Illipilli, TejasreeX
2024-11-08 12:15 ` Jani Nikula
2024-11-07 22:21 ` ✗ CI.FULL: " Patchwork
2024-11-08 12:19 ` ✓ CI.Patch_applied: success for drm/i915/dp: demote source OUI read/write failure logging to debug (rev2) Patchwork
2024-11-08 12:19 ` ✓ CI.checkpatch: " Patchwork
2024-11-08 12:20 ` ✓ CI.KUnit: " Patchwork
2024-11-08 12:32 ` ✓ CI.Build: " Patchwork
2024-11-08 12:34 ` ✓ CI.Hooks: " Patchwork
2024-11-08 12:36 ` ✗ CI.checksparse: warning " Patchwork
2024-11-08 13:00 ` ✓ CI.BAT: success " Patchwork
2024-11-09 16:38 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106162325.4065078-1-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=clinton.a.taylor@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox