From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH] drm/i914/watermark: Modify latency programmed into PKG_C_LATENCY
Date: Thu, 7 Nov 2024 17:02:40 +0530 [thread overview]
Message-ID: <20241107113240.887316-1-suraj.kandpal@intel.com> (raw)
Increase the latency programmed into PKG_C_LATENCY latency to be
a multiple of line time which is written into WM_LINETIME.
WA: 22020299601
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/display/skl_watermark.c | 26 ++++++++++++++------
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index d3bbf335c749..856b20a683fd 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -2848,9 +2848,11 @@ static int skl_wm_add_affected_planes(struct intel_atomic_state *state,
* Program PKG_C_LATENCY Added Wake Time = 0
*/
static void
-skl_program_dpkgc_latency(struct drm_i915_private *i915, bool enable_dpkgc)
+skl_program_dpkgc_latency(struct drm_i915_private *i915,
+ bool enable_dpkgc,
+ u32 max_linetime)
{
- u32 max_latency = 0;
+ u32 adjusted_latency = 0;
u32 clear = 0, val = 0;
u32 added_wake_time = 0;
@@ -2858,18 +2860,23 @@ skl_program_dpkgc_latency(struct drm_i915_private *i915, bool enable_dpkgc)
return;
if (enable_dpkgc) {
- max_latency = skl_watermark_max_latency(i915, 1);
- if (max_latency == 0)
- max_latency = LNL_PKG_C_LATENCY_MASK;
+ adjusted_latency = skl_watermark_max_latency(i915, 1);
+ if (adjusted_latency == 0)
+ adjusted_latency = LNL_PKG_C_LATENCY_MASK;
+
+ /* Wa_22020299601 */
+ if (IS_DISPLAY_VERx100(i915, 2000, 3000))
+ adjusted_latency = max_linetime *
+ DIV_ROUND_UP(adjusted_latency, max_linetime);
added_wake_time = DSB_EXE_TIME +
i915->display.sagv.block_time_us;
} else {
- max_latency = LNL_PKG_C_LATENCY_MASK;
+ adjusted_latency = LNL_PKG_C_LATENCY_MASK;
added_wake_time = 0;
}
clear |= LNL_ADDED_WAKE_TIME_MASK | LNL_PKG_C_LATENCY_MASK;
- val |= REG_FIELD_PREP(LNL_PKG_C_LATENCY_MASK, max_latency);
+ val |= REG_FIELD_PREP(LNL_PKG_C_LATENCY_MASK, adjusted_latency);
val |= REG_FIELD_PREP(LNL_ADDED_WAKE_TIME_MASK, added_wake_time);
intel_uncore_rmw(&i915->uncore, LNL_PKG_C_LATENCY, clear, val);
@@ -2882,6 +2889,7 @@ skl_compute_wm(struct intel_atomic_state *state)
struct intel_crtc_state __maybe_unused *new_crtc_state;
int ret, i;
bool enable_dpkgc = false;
+ u32 max_linetime;
for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
ret = skl_build_pipe_wm(state, crtc);
@@ -2911,9 +2919,11 @@ skl_compute_wm(struct intel_atomic_state *state)
new_crtc_state->vrr.vmin == new_crtc_state->vrr.flipline) ||
!new_crtc_state->vrr.enable)
enable_dpkgc = true;
+
+ max_linetime = max(new_crtc_state->linetime, max_linetime);
}
- skl_program_dpkgc_latency(to_i915(state->base.dev), enable_dpkgc);
+ skl_program_dpkgc_latency(to_i915(state->base.dev), enable_dpkgc, max_linetime);
skl_print_wm_changes(state);
--
2.34.1
next reply other threads:[~2024-11-07 11:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 11:32 Suraj Kandpal [this message]
2024-11-07 12:08 ` ✓ CI.Patch_applied: success for drm/i914/watermark: Modify latency programmed into PKG_C_LATENCY Patchwork
2024-11-07 12:09 ` ✓ CI.checkpatch: " Patchwork
2024-11-07 12:10 ` ✓ CI.KUnit: " Patchwork
2024-11-07 12:21 ` ✓ CI.Build: " Patchwork
2024-11-07 12:24 ` ✓ CI.Hooks: " Patchwork
2024-11-07 12:25 ` ✗ CI.checksparse: warning " Patchwork
2024-11-07 12:52 ` ✗ CI.BAT: failure " Patchwork
2024-11-08 6:50 ` [PATCH] " Pottumuttu, Sai Teja
2024-11-11 3:19 ` Kandpal, Suraj
2024-11-11 4:43 ` Pottumuttu, Sai Teja
2024-11-08 19:07 ` ✗ CI.FULL: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107113240.887316-1-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox