Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: Intel-Xe@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>
Subject: [RFC 2/5] drm/xe: Trigger a devcoredump capture on a GT reset
Date: Fri,  8 Nov 2024 17:59:31 -0800	[thread overview]
Message-ID: <20241109015934.2203462-3-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20241109015934.2203462-1-John.C.Harrison@Intel.com>

From: John Harrison <John.C.Harrison@Intel.com>

The GT reset code does not have access to a scheduler job, and is
usually called from some error condition disconnected from the job
submisson flow. Hence it did not generate a devcoredump. However,
devcoredumps can now be triggered without a job, so do so.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 drivers/gpu/drm/xe/xe_gt.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index d6744be01a68..2fa1d0f07850 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -19,6 +19,7 @@
 #include "xe_bb.h"
 #include "xe_bo.h"
 #include "xe_device.h"
+#include "xe_devcoredump.h"
 #include "xe_exec_queue.h"
 #include "xe_execlist.h"
 #include "xe_force_wake.h"
@@ -846,6 +847,9 @@ void xe_gt_reset_async(struct xe_gt *gt)
 
 	xe_gt_info(gt, "reset queued\n");
 	queue_work(gt->ordered_wq, &gt->reset.worker);
+
+	/* Capture system state for the user to include in a bug report */
+	xe_devcoredump_for_gt(gt);
 }
 
 void xe_gt_suspend_prepare(struct xe_gt *gt)
-- 
2.47.0


  parent reply	other threads:[~2024-11-09  1:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-09  1:59 [RFC 0/5] drm/xe: Support capture and dump of devcoredump for general debug John.C.Harrison
2024-11-09  1:59 ` [RFC 1/5] drm/xe/devcoredump: Support coredumps without jobs John.C.Harrison
2024-11-09  1:59 ` John.C.Harrison [this message]
2024-11-09  1:59 ` [RFC 3/5] drm/xe: Disconnect coredump structure from xe_device structure John.C.Harrison
2024-11-09  1:59 ` [RFC 4/5] drm/xe: Make coredump printing to in-memory cache optional John.C.Harrison
2024-11-09  1:59 ` [RFC 5/5] drm/xe: Support devcoredump capture from dead CT handler John.C.Harrison
2024-11-09  2:05 ` ✓ CI.Patch_applied: success for drm/xe: Support capture and dump of devcoredump for general debug Patchwork
2024-11-09  2:05 ` ✗ CI.checkpatch: warning " Patchwork
2024-11-09  2:06 ` ✓ CI.KUnit: success " Patchwork
2024-11-09  2:18 ` ✓ CI.Build: " Patchwork
2024-11-09  2:20 ` ✓ CI.Hooks: " Patchwork
2024-11-09  2:22 ` ✓ CI.checksparse: " Patchwork
2024-11-09  2:39 ` ✓ CI.BAT: " Patchwork
2024-11-10  3:58 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241109015934.2203462-3-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=Intel-Xe@Lists.FreeDesktop.Org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox