Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Matt Roper <matthew.d.roper@intel.com>
Subject: [PATCH 1/2] drm/xe: Always setup GT MMIO adjustment data
Date: Thu, 14 Nov 2024 18:59:54 +0100	[thread overview]
Message-ID: <20241114175955.2299-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20241114175955.2299-1-michal.wajdeczko@intel.com>

While we believed that xe_gt_mmio_init() will be called just once
per GT, this might not be a case due to some tweaks that need to
performed by the VF driver during early probe.  To avoid leaving
any stale data in case of the re-run, reset the GT MMIO adjustment
data for the non-media GT case.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/xe/xe_gt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index d6744be01a68..d45d2cecc4dc 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -643,6 +643,9 @@ void xe_gt_mmio_init(struct xe_gt *gt)
 	if (gt->info.type == XE_GT_TYPE_MEDIA) {
 		gt->mmio.adj_offset = MEDIA_GT_GSI_OFFSET;
 		gt->mmio.adj_limit = MEDIA_GT_GSI_LENGTH;
+	} else {
+		gt->mmio.adj_offset = 0;
+		gt->mmio.adj_limit = 0;
 	}
 
 	if (IS_SRIOV_VF(gt_to_xe(gt)))
-- 
2.43.0


  reply	other threads:[~2024-11-14 18:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14 17:59 [PATCH 0/2] VF: Fix early read of GDMID Michal Wajdeczko
2024-11-14 17:59 ` Michal Wajdeczko [this message]
2024-11-14 19:23   ` [PATCH 1/2] drm/xe: Always setup GT MMIO adjustment data Lucas De Marchi
2024-11-14 19:36     ` Michal Wajdeczko
2024-11-19 20:33       ` Lucas De Marchi
2024-12-03 20:37         ` Matt Roper
2024-12-09 14:44           ` Lucas De Marchi
2025-01-14 16:32             ` Lucas De Marchi
2024-11-14 17:59 ` [PATCH 2/2] drm/xe/vf: Perform early GT MMIO initialization to read GMDID Michal Wajdeczko
2024-12-02 18:38   ` Piotr Piórkowski
2025-01-14 21:13   ` [PATCH v2 " Michal Wajdeczko
2024-11-14 19:41 ` ✓ CI.Patch_applied: success for VF: Fix early read of GDMID Patchwork
2024-11-14 19:41 ` ✓ CI.checkpatch: " Patchwork
2024-11-14 19:42 ` ✓ CI.KUnit: " Patchwork
2024-11-14 19:54 ` ✓ CI.Build: " Patchwork
2024-11-14 19:56 ` ✓ CI.Hooks: " Patchwork
2024-11-14 19:58 ` ✓ CI.checksparse: " Patchwork
2024-11-14 20:23 ` ✓ CI.BAT: " Patchwork
2024-11-15 15:07 ` ✗ CI.FULL: failure " Patchwork
2025-01-14 20:40   ` Michal Wajdeczko
2025-01-15  0:48 ` ✓ CI.Patch_applied: success for VF: Fix early read of GDMID (rev2) Patchwork
2025-01-15  0:48 ` ✓ CI.checkpatch: " Patchwork
2025-01-15  0:49 ` ✓ CI.KUnit: " Patchwork
2025-01-15  1:08 ` ✓ CI.Build: " Patchwork
2025-01-15  1:10 ` ✓ CI.Hooks: " Patchwork
2025-01-15  1:11 ` ✓ CI.checksparse: " Patchwork
2025-01-15  1:38 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-15 11:07 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-18 20:57   ` Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241114175955.2299-2-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox