From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F51DD68BDD for ; Sat, 16 Nov 2024 01:28:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5828410E3D6; Sat, 16 Nov 2024 01:28:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mExJWpE/"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id D22AC10E18D for ; Sat, 16 Nov 2024 01:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731720483; x=1763256483; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=woNb8j4uOyjLp4R0AdKQIrl8/KBzDy1qlfJVFFbO6sU=; b=mExJWpE/vtoLqLN9f8LhX0hr4rKmo4/k2DDAkab6L4vWqDDKjwUa8DCV V49W/RacBK0fC0hmG9FZ5U4DVViXH2yc9Q/AUKDA245+BfYL174ouw7C4 uEdQpE/qIvUwAjQhIMdDt+2R6zUecnhbOv2UAYSFRUbHELX+sVKjquvfb bsHvF/6asGbMZBv48ChGagU3pCc3a/6aCYbSoQHYiQurGwWndsarrW8uW p0vcRxXUvSz0AGAV+rJZHGAop/lYyyLSyxCx0XUeHS+dIynQR1elUCKD4 pIOLPmixMWNq1TFRskzL8J87WHFjPrVieGjin4bo3YelzCcwOyVQ0gzTw g==; X-CSE-ConnectionGUID: CYKVs8/HQiG+pOAtcPN3Mg== X-CSE-MsgGUID: V26GkGkzRf6mMRoi2yr/8g== X-IronPort-AV: E=McAfee;i="6700,10204,11257"; a="31690764" X-IronPort-AV: E=Sophos;i="6.12,158,1728975600"; d="scan'208";a="31690764" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 17:28:02 -0800 X-CSE-ConnectionGUID: NuJB3K22TZq13DIRPgdAnA== X-CSE-MsgGUID: ieVlVw3hSbiHo/hNRTLHcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,158,1728975600"; d="scan'208";a="93556890" Received: from gkczarna.igk.intel.com ([10.102.139.130]) by fmviesa004.fm.intel.com with ESMTP; 15 Nov 2024 17:27:59 -0800 From: Tomasz Lis To: intel-xe@lists.freedesktop.org Cc: =?UTF-8?q?Micha=C5=82=20Winiarski?= , =?UTF-8?q?Micha=C5=82=20Wajdeczko?= , =?UTF-8?q?Piotr=20Pi=C3=B3rkowski?= Subject: [PATCH v1 3/3] drm/xe/vf: Fixup CTB send buffer messages after migration Date: Sat, 16 Nov 2024 02:27:55 +0100 Message-Id: <20241116012755.2297439-4-tomasz.lis@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241116012755.2297439-1-tomasz.lis@intel.com> References: <20241116012755.2297439-1-tomasz.lis@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" During post-migration recovery of a VF, it in necessary to update GGTT references included in messages which are going to be sent to GuC. GuC will start consuming messages after VF KMD will inform it about fixups being done; before that, the VF KMD is expected to update any H2G messages which are already in send buffer but were not consumed by GuC. Only a small subset of messages allowed for VFs have GGTT references in them. This patch adds the functionality to parse the CTB send ring buffer and shift addresses contained within. While fixing the CTB content, ct->lock is not taken. This means the only barier taken remains GGTT address lock - which is ok, because only requests with GGTT addresses matter, but it also means tail changes can happen during the CTB fixups execution (which may be ignored as any new messages will not have anything to fix). The GGTT address locking will be introduced in a future series. Signed-off-by: Tomasz Lis --- drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 2 + drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h | 2 + drivers/gpu/drm/xe/xe_guc_ct.c | 144 ++++++++++++++++++++++ drivers/gpu/drm/xe/xe_guc_ct.h | 2 + drivers/gpu/drm/xe/xe_sriov_vf.c | 12 ++ 5 files changed, 162 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c index ae24c47ed8f8..604cbbf55d4f 100644 --- a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c +++ b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c @@ -920,12 +920,14 @@ static u64 drm_mm_node_end(struct drm_mm_node *node) static s64 vf_get_post_migration_ggtt_shift(struct xe_gt *gt) { struct xe_gt_sriov_vf_selfconfig *config = >->sriov.vf.self_config; + struct xe_gt_sriov_vf_runtime *runtime = >->sriov.vf.runtime; struct xe_tile *tile = gt_to_tile(gt); u64 old_base; s64 ggtt_shift; old_base = drm_mm_node_end(&tile->sriov.vf.ggtt_balloon[0]->base); ggtt_shift = config->ggtt_base - (s64)old_base; + runtime->ggtt_shift = ggtt_shift; xe_gt_sriov_info(gt, "GGTT base shifted from %#llx to %#llx\n", old_base, old_base + ggtt_shift); diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h b/drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h index a57f13b5afcd..6af219b0eb1e 100644 --- a/drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h +++ b/drivers/gpu/drm/xe/xe_gt_sriov_vf_types.h @@ -65,6 +65,8 @@ struct xe_gt_sriov_vf_runtime { /** @regs.value: register value. */ u32 value; } *regs; + /** @ggtt_shift: difference in ggtt_base on last migration */ + s64 ggtt_shift; }; /** diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c index 7eb175a0b874..7e8a8f925589 100644 --- a/drivers/gpu/drm/xe/xe_guc_ct.c +++ b/drivers/gpu/drm/xe/xe_guc_ct.c @@ -84,6 +84,8 @@ struct g2h_fence { bool done; }; +#define make_u64(hi, lo) ((u64)((u64)(u32)(hi) << 32 | (u32)(lo))) + static void g2h_fence_init(struct g2h_fence *g2h_fence, u32 *response_buffer) { g2h_fence->response_buffer = response_buffer; @@ -1620,6 +1622,148 @@ static void g2h_worker_func(struct work_struct *w) receive_g2h(ct); } +/* + * ct_update_addresses_in_message - Shift any GGTT addresses within + * a single message left within CTB from before post-migration recovery. + * @ct: pointer to CT struct of the target GuC + * @cmds: iomap buffer containing CT messages + * @head: start of the target message within the buffer + * @len: length of the target message + * @size: size of the commands buffer + * @shift: the address shift to be added to each GGTT reference + */ +static void ct_update_addresses_in_message(struct xe_guc_ct *ct, + struct iosys_map *cmds, u32 head, + u32 len, u32 size, s64 shift) +{ + struct xe_device *xe = ct_to_xe(ct); + u32 action, i, n; + u32 msg[2]; + u64 offset; + +#define read32(o, p) \ + xe_map_memcpy_from(xe, msg, cmds, (head + p) * sizeof(u32), \ + 1 * sizeof(u32)); \ + o = msg[0] +#define fixup64(p) \ + xe_map_memcpy_from(xe, msg, cmds, (head + p) * sizeof(u32), \ + 2 * sizeof(u32)); \ + offset = make_u64(msg[1], msg[0]); \ + offset += shift; \ + msg[0] = lower_32_bits(offset); \ + msg[1] = upper_32_bits(offset); \ + xe_map_memcpy_to(xe, cmds, (head + p) * sizeof(u32), msg, 2 * sizeof(u32)) + + xe_map_memcpy_from(xe, msg, cmds, head * sizeof(u32), + 1 * sizeof(u32)); + action = FIELD_GET(GUC_HXG_REQUEST_MSG_0_ACTION, msg[0]); + switch (action) + { + case XE_GUC_ACTION_REGISTER_CONTEXT: + case XE_GUC_ACTION_REGISTER_CONTEXT_MULTI_LRC: + /* field wq_desc */ + fixup64(5); + /* field wq_base */ + fixup64(7); + if (action == XE_GUC_ACTION_REGISTER_CONTEXT_MULTI_LRC) { + /* field number_children */ + read32(n, 10); + /* field hwlrca and child lrcas */ + for (i = 0; i < n; i++) { + fixup64(11 + 2 * i); + } + } else { + /* field hwlrca */ + fixup64(10); + } + break; + default: + break; + } +#undef fixup64 +#undef read32 +} + +static int ct_update_addresses_in_buffer(struct xe_guc_ct *ct, + struct guc_ctb *h2g, + s64 shift, u32 *mhead, s32 avail) +{ + struct xe_device *xe = ct_to_xe(ct); + u32 head = *mhead; + u32 size = h2g->info.size; + u32 msg[1]; + u32 len; + + /* Read header */ + xe_map_memcpy_from(xe, msg, &h2g->cmds, sizeof(u32) * head, + sizeof(u32)); + len = FIELD_GET(GUC_CTB_MSG_0_NUM_DWORDS, msg[0]) + GUC_CTB_MSG_MIN_LEN; + + if (unlikely(len > (u32)avail)) { + struct xe_gt *gt = ct_to_gt(ct); + + xe_gt_err(gt, "H2G channel broken on read, avail=%d, len=%d, fixups skipped\n", + avail, len); + return 0; + } + + head = (head + 1) % size; + ct_update_addresses_in_message(ct, &h2g->cmds, head, len - 1, size, shift); + *mhead = (head + len - 1) % size; + + return avail - len; +} + +/** + * xe_guc_ct_update_addresses - Shifts any GGTT addresses left + * within CTB from before post-migration recovery. + * @ct: pointer to CT struct of the target GuC + */ +int xe_guc_ct_update_addresses(struct xe_guc_ct *ct) +{ + struct xe_guc *guc = ct_to_guc(ct); + struct xe_gt *gt = guc_to_gt(guc); + struct xe_gt_sriov_vf_runtime *runtime = >->sriov.vf.runtime; + struct guc_ctb *h2g = &ct->ctbs.h2g; + u32 head = h2g->info.head; + u32 tail = READ_ONCE(h2g->info.tail); + u32 size = h2g->info.size; + s32 avail; + s64 ggtt_shift; + + if (unlikely(h2g->info.broken)) + return -EPIPE; + + XE_WARN_ON(head > size); + + if (unlikely(tail >= size)) { + xe_gt_err(gt, "H2G channel has Invalid tail offset (%u >= %u)\n", + tail, size); + goto corrupted; + } + + avail = tail - head; + + /* beware of buffer wrap case */ + if (unlikely(avail < 0)) + avail += size; + xe_gt_dbg(gt, "available %d (%u:%u:%u)\n", avail, head, tail, size); + XE_WARN_ON(avail < 0); + + ggtt_shift = runtime->ggtt_shift; + + while (avail > 0) + avail = ct_update_addresses_in_buffer(ct, h2g, ggtt_shift, &head, avail); + + return 0; + +corrupted: + xe_gt_err(gt, "Corrupted descriptor head=%u tail=%u\n", + head, tail); + h2g->info.broken = true; + return -EPIPE; +} + static struct xe_guc_ct_snapshot *guc_ct_snapshot_alloc(struct xe_guc_ct *ct, bool atomic, bool want_ctb) { diff --git a/drivers/gpu/drm/xe/xe_guc_ct.h b/drivers/gpu/drm/xe/xe_guc_ct.h index 82c4ae458dda..6b04fd4b1e03 100644 --- a/drivers/gpu/drm/xe/xe_guc_ct.h +++ b/drivers/gpu/drm/xe/xe_guc_ct.h @@ -22,6 +22,8 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot, struct drm_pr void xe_guc_ct_snapshot_free(struct xe_guc_ct_snapshot *snapshot); void xe_guc_ct_print(struct xe_guc_ct *ct, struct drm_printer *p, bool want_ctb); +int xe_guc_ct_update_addresses(struct xe_guc_ct *ct); + static inline bool xe_guc_ct_enabled(struct xe_guc_ct *ct) { return ct->state == XE_GUC_CT_STATE_ENABLED; diff --git a/drivers/gpu/drm/xe/xe_sriov_vf.c b/drivers/gpu/drm/xe/xe_sriov_vf.c index 1d2559343706..5bd6172815ae 100644 --- a/drivers/gpu/drm/xe/xe_sriov_vf.c +++ b/drivers/gpu/drm/xe/xe_sriov_vf.c @@ -9,6 +9,7 @@ #include "xe_device.h" #include "xe_gt_sriov_printk.h" #include "xe_gt_sriov_vf.h" +#include "xe_guc_ct.h" #include "xe_pm.h" #include "xe_sriov.h" #include "xe_sriov_printk.h" @@ -157,6 +158,15 @@ static int vf_post_migration_requery_guc(struct xe_device *xe) return ret; } +static void vf_post_migration_fixup_ctb(struct xe_device *xe) +{ + struct xe_gt *gt; + unsigned int id; + + for_each_gt(gt, xe, id) + xe_guc_ct_update_addresses(>->uc.guc.ct); +} + /* * vf_post_migration_imminent - Check if post-restore recovery is coming. * @xe: the &xe_device struct instance @@ -216,6 +226,8 @@ static void vf_post_migration_recovery(struct xe_device *xe) vf_post_migration_fixup_ggtt_nodes(xe); /* FIXME: add the recovery steps */ + vf_post_migration_fixup_ctb(xe); + vf_post_migration_notify_resfix_done(xe); xe_pm_runtime_put(xe); drm_notice(&xe->drm, "migration recovery ended\n"); -- 2.25.1