From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Subject: [PATCH v2 1/2] drm/xe: Introduce force-wake guard class
Date: Mon, 18 Nov 2024 19:45:10 +0100 [thread overview]
Message-ID: <20241118184511.258-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20241118184511.258-1-michal.wajdeczko@intel.com>
There is support for 'classes' with constructor and destructor
semantics that can be used for any scope-based resource management,
like our domain force-wake management.
Define xe_fw class that can be used for force-wake management.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
v2: aligned to new force-wake usage model (Michal)
---
drivers/gpu/drm/xe/xe_force_wake.h | 12 ++++++++++++
drivers/gpu/drm/xe/xe_force_wake_types.h | 10 ++++++++++
2 files changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_force_wake.h b/drivers/gpu/drm/xe/xe_force_wake.h
index 0e3e84bfa51c..e46e44f7eb70 100644
--- a/drivers/gpu/drm/xe/xe_force_wake.h
+++ b/drivers/gpu/drm/xe/xe_force_wake.h
@@ -6,6 +6,8 @@
#ifndef _XE_FORCE_WAKE_H_
#define _XE_FORCE_WAKE_H_
+#include <linux/cleanup.h>
+
#include "xe_assert.h"
#include "xe_force_wake_types.h"
@@ -61,4 +63,14 @@ xe_force_wake_ref_has_domain(unsigned int fw_ref, enum xe_force_wake_domains dom
return fw_ref & domain;
}
+DEFINE_CLASS(xe_fw, struct xe_force_wake_guard,
+ xe_force_wake_put(_T.fw, _T.ref),
+ ({ (struct xe_force_wake_guard){ fw, xe_force_wake_get(fw, domains) }; }),
+ struct xe_force_wake *fw, enum xe_force_wake_domains domains);
+
+static inline void *class_xe_fw_lock_ptr(class_xe_fw_t *_T)
+{
+ return _T->ref ? _T : NULL;
+}
+
#endif
diff --git a/drivers/gpu/drm/xe/xe_force_wake_types.h b/drivers/gpu/drm/xe/xe_force_wake_types.h
index 899fbbcb3ea9..15456a24f707 100644
--- a/drivers/gpu/drm/xe/xe_force_wake_types.h
+++ b/drivers/gpu/drm/xe/xe_force_wake_types.h
@@ -85,4 +85,14 @@ struct xe_force_wake {
struct xe_force_wake_domain domains[XE_FW_DOMAIN_ID_COUNT];
};
+/**
+ * struct xe_force_wake_guard - Xe force wake guard
+ */
+struct xe_force_wake_guard {
+ /** @fw: force wake manager */
+ struct xe_force_wake *fw;
+ /** @ref: opaque reference to woken domains */
+ unsigned int ref;
+};
+
#endif
--
2.43.0
next prev parent reply other threads:[~2024-11-18 18:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 18:45 [PATCH v2 0/2] New force-wake guard class Michal Wajdeczko
2024-11-18 18:45 ` Michal Wajdeczko [this message]
2024-11-19 18:47 ` [PATCH v2 1/2] drm/xe: Introduce " Rodrigo Vivi
2024-11-19 19:21 ` Raag Jadav
2024-11-19 19:59 ` Lucas De Marchi
2024-11-19 20:26 ` Michal Wajdeczko
2024-11-25 12:11 ` Rodrigo Vivi
2024-11-25 13:53 ` Raag Jadav
2024-11-18 18:45 ` [PATCH v2 2/2] drm/xe: Use new force-wake guard class in xe_mocs.c Michal Wajdeczko
2024-11-19 20:03 ` Lucas De Marchi
2024-11-19 21:05 ` Michal Wajdeczko
2024-11-21 4:55 ` Matthew Brost
2024-11-21 20:53 ` Lucas De Marchi
2024-11-18 18:54 ` ✓ CI.Patch_applied: success for New force-wake guard class Patchwork
2024-11-18 18:55 ` ✓ CI.checkpatch: " Patchwork
2024-11-18 18:57 ` ✓ CI.KUnit: " Patchwork
2024-11-18 19:20 ` ✓ CI.Build: " Patchwork
2024-11-18 19:23 ` ✓ CI.Hooks: " Patchwork
2024-11-18 19:24 ` ✓ CI.checksparse: " Patchwork
2024-11-19 1:57 ` ✗ CI.FULL: failure " Patchwork
2024-11-19 7:29 ` ✓ CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118184511.258-2-michal.wajdeczko@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox