From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D52FD65549 for ; Tue, 26 Nov 2024 18:14:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45D5D10E998; Tue, 26 Nov 2024 18:14:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PkI2QKmz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id C225B10E993 for ; Tue, 26 Nov 2024 18:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732644838; x=1764180838; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iCVKrPeG/GLuuHtd+a7Jc9v7UFAhw3CbriX6ZehsFS0=; b=PkI2QKmzUUmsVuGHnqP056HevLaslEqDtH4SQK8kuicvt8KaGfNkOSm8 fVGJDGW/8aHIKvreFVaGTeHWqwLrZgtqhosXT+nut/IoZmmArrSROajaA vNivoGVWqHaNZ7cVlm2C0AQuND6952COQSOfOpdwIKC1LQUp7Dc4nUeLq pPqWWDe3LdqBEW4LsVewXeSHhDfW8y4/HWXeQQRJbLnrL7amUwLF2357O m1CMuytxyvILxIb25rdqf6rTqU0m71Ifg4Wv1u40C4QAgJMLwJXK9kmHv QbDUUmLGwcaq2gpTRTCZsCewFuRLVVe1D1NBiquYj3FiwRuwWDYwLOjtF g==; X-CSE-ConnectionGUID: u0xI8eb3RXeRiROnyO4m+Q== X-CSE-MsgGUID: 5uZKtioMTZSF47hRXG7LpQ== X-IronPort-AV: E=McAfee;i="6700,10204,11268"; a="32197193" X-IronPort-AV: E=Sophos;i="6.12,186,1728975600"; d="scan'208";a="32197193" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2024 10:13:58 -0800 X-CSE-ConnectionGUID: 5l2ag/KvQsG5JIXF9l3tJw== X-CSE-MsgGUID: MWg4pPJIQHyTUGTyQuJCcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,186,1728975600"; d="scan'208";a="91642721" Received: from ksztyber-mobl2.ger.corp.intel.com (HELO mwauld-desk.intel.com) ([10.245.245.145]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2024 10:13:56 -0800 From: Matthew Auld To: intel-xe@lists.freedesktop.org Cc: Matthew Brost , Nirmoy Das , stable@vger.kernel.org Subject: [PATCH 2/2] drm/xe/migrate: use XE_BO_FLAG_PAGETABLE Date: Tue, 26 Nov 2024 18:13:01 +0000 Message-ID: <20241126181259.159713-4-matthew.auld@intel.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241126181259.159713-3-matthew.auld@intel.com> References: <20241126181259.159713-3-matthew.auld@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On some HW we want to avoid the host caching PTEs, since access from GPU side can be incoherent. However here the special migrate object is mapping PTEs which are written from the host and potentially cached. Use XE_BO_FLAG_PAGETABLE to ensure that non-cached mapping is used, on platforms where this matters. Fixes: 7a060d786cc1 ("drm/xe/mtl: Map PPGTT as CPU:WC") Signed-off-by: Matthew Auld Cc: Matthew Brost Cc: Nirmoy Das Cc: # v6.8+ --- drivers/gpu/drm/xe/xe_migrate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c index 48e205a40fd2..1b97d90aadda 100644 --- a/drivers/gpu/drm/xe/xe_migrate.c +++ b/drivers/gpu/drm/xe/xe_migrate.c @@ -209,7 +209,8 @@ static int xe_migrate_prepare_vm(struct xe_tile *tile, struct xe_migrate *m, num_entries * XE_PAGE_SIZE, ttm_bo_type_kernel, XE_BO_FLAG_VRAM_IF_DGFX(tile) | - XE_BO_FLAG_PINNED); + XE_BO_FLAG_PINNED | + XE_BO_FLAG_PAGETABLE); if (IS_ERR(bo)) return PTR_ERR(bo); -- 2.47.0