Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: Intel-Xe@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>
Subject: [PATCH v5 0/3] drm/xe: Add devcoredump locking and reason string
Date: Tue, 26 Nov 2024 11:18:54 -0800	[thread overview]
Message-ID: <20241126191857.2583429-1-John.C.Harrison@Intel.com> (raw)

From: John Harrison <John.C.Harrison@Intel.com>

There are now many ways to trigger a devcoredump capture. So include a
reason message to say why it happened.

Also, add locking to avoid a races with double captures and free vs read.

v2: Change to spin_lock to mutex and a few other tweaks (review
feedback from Matthew Brost).
v3: Move mutex locks and add reclaim annotation (review feedback from
Matthew Brost).
v4: Fix typo - when adding lockdep specific code it helps to actually
have CONFIG_LOCKDEP enabled!
v5: New patch to move the call to dev_coredumpm_timeout to prevent an
existing issue highlighted by the new lockdep checking.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (3):
  drm/xe: Add a reason string to the devcoredump
  drm/xe: Move the coredump registration to the worker thread
  drm/xe: Add mutex locking to devcoredump

 drivers/gpu/drm/xe/xe_devcoredump.c       | 115 +++++++++++++++-------
 drivers/gpu/drm/xe/xe_devcoredump.h       |   5 +-
 drivers/gpu/drm/xe/xe_devcoredump_types.h |   8 +-
 drivers/gpu/drm/xe/xe_guc_submit.c        |  14 ++-
 4 files changed, 102 insertions(+), 40 deletions(-)

-- 
2.47.0


             reply	other threads:[~2024-11-26 19:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26 19:18 John.C.Harrison [this message]
2024-11-26 19:18 ` [PATCH v5 1/3] drm/xe: Add a reason string to the devcoredump John.C.Harrison
2024-11-26 19:18 ` [PATCH v5 2/3] drm/xe: Move the coredump registration to the worker thread John.C.Harrison
2024-11-26 23:41   ` Matthew Brost
2024-11-27  0:55     ` John Harrison
2024-11-26 19:18 ` [PATCH v5 3/3] drm/xe: Add mutex locking to devcoredump John.C.Harrison
2024-11-26 20:13 ` ✓ CI.Patch_applied: success for drm/xe: Add devcoredump locking and reason string Patchwork
2024-11-26 20:13 ` ✓ CI.checkpatch: " Patchwork
2024-11-26 20:14 ` ✓ CI.KUnit: " Patchwork
2024-11-26 20:32 ` ✓ CI.Build: " Patchwork
2024-11-26 20:35 ` ✓ CI.Hooks: " Patchwork
2024-11-26 20:36 ` ✓ CI.checksparse: " Patchwork
2024-11-26 20:54 ` ✓ Xe.CI.BAT: " Patchwork
2024-11-26 22:23 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241126191857.2583429-1-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=Intel-Xe@Lists.FreeDesktop.Org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox