From: Mika Kahola <mika.kahola@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@linux.intel.com, Mika Kahola <mika.kahola@intel.com>,
Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Subject: [PATCH v6 2/2] drm/i915/display: Use struct intel_display instead of struct drm_i915_private
Date: Wed, 27 Nov 2024 09:32:00 +0200 [thread overview]
Message-ID: <20241127073200.124907-3-mika.kahola@intel.com> (raw)
In-Reply-To: <20241127073200.124907-1-mika.kahola@intel.com>
Let's start using struct intel_display instead of struct drm_i915_private
when introducing new code. No functional changes.
v2: Drop tc_to_intel_display() helper funtion (Jani)
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
---
drivers/gpu/drm/i915/display/intel_tc.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
index 82e82e8ec11a..33b8f2772076 100644
--- a/drivers/gpu/drm/i915/display/intel_tc.c
+++ b/drivers/gpu/drm/i915/display/intel_tc.c
@@ -1043,10 +1043,9 @@ static void xelpdp_tc_power_request_wa(struct intel_display *display, bool enabl
static void __xelpdp_tc_phy_enable_tcss_power(struct intel_tc_port *tc, bool enable)
{
- struct drm_i915_private *i915 = tc_to_i915(tc);
- struct intel_display *display = &i915->display;
+ struct intel_display *display = to_intel_display(tc->dig_port);
enum port port = tc->dig_port->base.port;
- i915_reg_t reg = XELPDP_PORT_BUF_CTL1(i915, port);
+ i915_reg_t reg = XELPDP_PORT_BUF_CTL1(display, port);
u32 val;
assert_tc_cold_blocked(tc);
@@ -1054,12 +1053,12 @@ static void __xelpdp_tc_phy_enable_tcss_power(struct intel_tc_port *tc, bool ena
if (DISPLAY_VER(display) == 30)
xelpdp_tc_power_request_wa(display, enable);
- val = intel_de_read(i915, reg);
+ val = intel_de_read(display, reg);
if (enable)
val |= XELPDP_TCSS_POWER_REQUEST;
else
val &= ~XELPDP_TCSS_POWER_REQUEST;
- intel_de_write(i915, reg, val);
+ intel_de_write(display, reg, val);
}
static bool xelpdp_tc_phy_enable_tcss_power(struct intel_tc_port *tc, bool enable)
--
2.43.0
next prev parent reply other threads:[~2024-11-27 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 7:31 [PATCH v6 0/2] drm/i915/display: Power request asserting/deasserting Mika Kahola
2024-11-27 7:31 ` [PATCH v6 1/2] drm/i915/xe3lpd: " Mika Kahola
2024-11-27 7:32 ` Mika Kahola [this message]
2024-11-27 8:01 ` ✓ CI.Patch_applied: success for drm/i915/display: " Patchwork
2024-11-27 8:01 ` ✗ CI.checkpatch: warning " Patchwork
2024-11-27 8:02 ` ✓ CI.KUnit: success " Patchwork
2024-11-27 8:20 ` ✓ CI.Build: " Patchwork
2024-11-27 8:22 ` ✓ CI.Hooks: " Patchwork
2024-11-27 8:24 ` ✗ CI.checksparse: warning " Patchwork
2024-11-27 8:42 ` ✓ Xe.CI.BAT: success " Patchwork
2024-11-27 9:53 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-04 10:59 ` [PATCH v6 0/2] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127073200.124907-3-mika.kahola@intel.com \
--to=mika.kahola@intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox