Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arun R Murthy <arun.r.murthy@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Cc: Arun R Murthy <arun.r.murthy@intel.com>
Subject: [PATCH 01/10] drm/crtc: Add histogram properties
Date: Tue,  3 Dec 2024 11:25:11 +0530	[thread overview]
Message-ID: <20241203055520.1704661-2-arun.r.murthy@intel.com> (raw)
In-Reply-To: <20241203055520.1704661-1-arun.r.murthy@intel.com>

Add variables for histogram drm_property, its corrsponding crtc_state
variables and define the structure pointed by the blob property.

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 include/drm/drm_crtc.h      | 48 +++++++++++++++++++++++++++++++++++++
 include/uapi/drm/drm_mode.h | 11 +++++++++
 2 files changed, 59 insertions(+)

diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 8b48a1974da3..3984cfa00cbf 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -274,6 +274,38 @@ struct drm_crtc_state {
 	 */
 	struct drm_property_blob *gamma_lut;
 
+	/**
+	 * @histogram_enable:
+	 *
+	 * This will be set if histogram is enabled for the CRTC.
+	 */
+	bool histogram_enable;
+
+	/**
+	 * @histogram_data:
+	 *
+	 * This will hold the pointer to the struct drm_histogram.
+	 * The element data in drm_histogram will hold the pointer to the
+	 * histogram data generated by the hardware.
+	 */
+	struct drm_property_blob *histogram_data;
+
+	/**
+	 * @histogram_-iet:
+	 *
+	 * This will hold the pointer to the struct drm_histogram.
+	 * The element data in drm_histogram will hold the pointer to the
+	 * histogram image enhancement generated by the algorithm that is to
+	 * be fed back to the hardware.
+	 */
+	struct drm_property_blob *histogram_iet;
+	/**
+	 * @histogram_iet_updates:
+	 *
+	 * Convey that the image enhanced data has been updated by the user
+	 */
+	bool histogram_iet_updated;
+
 	/**
 	 * @target_vblank:
 	 *
@@ -1088,6 +1120,22 @@ struct drm_crtc {
 	 */
 	struct drm_property *scaling_filter_property;
 
+	/**
+	 * @histogram_enable_property: Optional CRTC property for enabling or
+	 * disabling global histogram.
+	 */
+	struct drm_property *histogram_enable_property;
+	/**
+	 * @histogram_data_proeprty: Optional CRTC property for getting the
+	 * histogram blob data.
+	 */
+	struct drm_property *histogram_data_property;
+	/**
+	 * @histogram_iet_proeprty: Optional CRTC property for writing the
+	 * image enhanced blob data
+	 */
+	struct drm_property *histogram_iet_property;
+
 	/**
 	 * @state:
 	 *
diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index c082810c08a8..da4396f57ed1 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -1355,6 +1355,17 @@ struct drm_mode_closefb {
 	__u32 pad;
 };
 
+/**
+ * struct drm_histogram
+ * data_ptr: pointer to the array fo u32 data. This data can be histogram
+ * raw data or image enhanced data
+ * nr_elements: number of elements pointed by the data @data_ptr
+ */
+struct drm_histogram {
+	__u64 data_ptr;
+	__u32 nr_elements;
+};
+
 #if defined(__cplusplus)
 }
 #endif
-- 
2.25.1


  reply	other threads:[~2024-12-03  6:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  5:55 [PATCHv9 00/10] Display Global Histogram Arun R Murthy
2024-12-03  5:55 ` Arun R Murthy [this message]
2024-12-03 15:07   ` [PATCH 01/10] drm/crtc: Add histogram properties Dmitry Baryshkov
2024-12-04  5:00   ` Kandpal, Suraj
2024-12-03  5:55 ` [PATCH 02/10] drm/crtc: Expose API to create drm crtc property for histogram Arun R Murthy
2024-12-03  5:55 ` [PATCHv2 03/10] drm/i915/histogram: Define registers " Arun R Murthy
2024-12-03  5:55 ` [PATCHv5 04/10] drm/i915/histogram: Add support " Arun R Murthy
2024-12-03  5:55 ` [PATCH 05/10] drm/xe: Add histogram support to Xe builds Arun R Murthy
2024-12-03  5:55 ` [PATCHv5 06/10] drm/i915/histogram: histogram interrupt handling Arun R Murthy
2024-12-04  5:15   ` Kandpal, Suraj
2024-12-03  5:55 ` [PATCH 07/10] drm/i915/display: handle drm-crtc histogram property updates Arun R Murthy
2024-12-04  5:33   ` Kandpal, Suraj
2024-12-03  5:55 ` [PATCHv3 08/10] drm/i915/histogram: histogram delay counter doesnt reset Arun R Murthy
2024-12-04  4:53   ` Kandpal, Suraj
2024-12-03  5:55 ` [PATCHv6 09/10] drm/i915/histogram: Histogram changes for Display 20+ Arun R Murthy
2024-12-04  4:55   ` Kandpal, Suraj
2024-12-03  5:55 ` [PATCH 10/10] drm/i915/histogram: Enable pipe dithering Arun R Murthy
2024-12-03  6:11 ` ✓ CI.Patch_applied: success for Display Global Histogram (rev5) Patchwork
2024-12-03  6:12 ` ✗ CI.checkpatch: warning " Patchwork
2024-12-03  6:13 ` ✓ CI.KUnit: success " Patchwork
2024-12-03  6:20 ` ✗ CI.Build: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241203055520.1704661-2-arun.r.murthy@intel.com \
    --to=arun.r.murthy@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox