Re: [PATCH 0/3] drm/i915/display: handle hdmi connector init failures

[Sergey Senozhatsky <senozhatsky@chromium.org>]

On (24/11/15 14:00), Sergey Senozhatsky wrote:
> On (24/11/14 17:52), Jani Nikula wrote:
> > This is an attempt to resolve [1].
> > 
> > [1] https://lore.kernel.org/r/20241031105145.2140590-1-senozhatsky@chromium.org
> > 
> > Jani Nikula (3):
> >   drm/i915/hdmi: propagate errors from intel_hdmi_init_connector()
> >   drm/i915/hdmi: add error handling in g4x_hdmi_init()
> >   drm/i915/ddi: propagate errors from intel_ddi_init_hdmi_connector()
> 
> So these look reasonable and good to me, and I think landing them
> makes a lot of sense.  For that part feel free to add:
> 
> Reported-and-tested-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> and FWIW
> Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> 
> 
> 
> Now, regarding the issue in question - we are getting there, but not
> quite there yet.
> 
> I'm still seeing multiple NULL-ptr derefs, namely on
> 
>  DDI A/PHY A
>  DDI TC1/PHY TC1
>  DDI TC2/PHY TC2
>  DDI TC3/PHY TC3
>  DDI TC4/PHY TC4
> 
> The thing is, all of them are DP connectors, we only ever call
> intel_ddi_init_dp_connector() on them, so dig_port->hdmi
> is not init-ed, wheres intel_hdmi_encoder_shutdown() doesn't
> distinguish and treats everyone as HDMI connector, dereferencing
> ->hdmi.
> 
> With the small addition I don't see null-ptr derefs anymore:

Gentle ping on this.