From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Jakub Kolakowski" <jakub1.kolakowski@intel.com>,
"Piotr Piórkowski" <piotr.piorkowski@intel.com>,
"Adam Miszczak" <adam.miszczak@linux.intel.com>,
"Lukasz Laguna" <lukasz.laguna@intel.com>,
"Marcin Bernatowicz" <marcin.bernatowicz@linux.intel.com>,
"Michal Wajdeczko" <michal.wajdeczko@intel.com>,
"Michal Winiarski" <michal.winiarski@intel.com>,
"Narasimha C V" <narasimha.c.v@intel.com>,
"Satyanarayana K V P" <satyanarayana.k.v.p@intel.com>,
"Tomasz Lis" <tomasz.lis@intel.com>,
"Matt Roper" <matthew.d.roper@intel.com>
Subject: [PATCH 1/3] drm/xe/vf: Don't check has flat ccs in bios on VF
Date: Wed, 11 Dec 2024 07:42:09 +0100 [thread overview]
Message-ID: <20241211064211.781820-2-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20241211064211.781820-1-marcin.bernatowicz@linux.intel.com>
From: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Don't check for flat ccs from VF-level as VF does not have direct
access to the register.
If the BIOS disables FlatCCS support (a use-case that will nearly never
be used) and the has_flat_ccs flag is set, there shouldn't be
any functional impact. The hardware will drop writes to the CCS region,
and reads from the CCS region will always return 0.
For the native case, the flag is disabled if the BIOS disables
it to avoid unnecessary overhead in buffer object (BO) creation
and migration.
Signed-off-by: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Suggested-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Michal Winiarski <michal.winiarski@intel.com>
Cc: Narasimha C V <narasimha.c.v@intel.com>
Cc: Piotr Piorkowski <piotr.piorkowski@intel.com>
Cc: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Cc: Tomasz Lis <tomasz.lis@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 56d4ffb650da..ec0ea9c914b4 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -604,7 +604,7 @@ static int probe_has_flat_ccs(struct xe_device *xe)
u32 reg;
/* Always enabled/disabled, no runtime check to do */
- if (GRAPHICS_VER(xe) < 20 || !xe->info.has_flat_ccs)
+ if (GRAPHICS_VER(xe) < 20 || !xe->info.has_flat_ccs || IS_SRIOV_VF(xe))
return 0;
gt = xe_root_mmio_gt(xe);
--
2.31.1
next prev parent reply other threads:[~2024-12-11 6:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 6:42 [PATCH v2 0/3] VF: Avoid reading inaccessible registers Marcin Bernatowicz
2024-12-11 6:42 ` Marcin Bernatowicz [this message]
2025-01-07 23:13 ` [PATCH 1/3] drm/xe/vf: Don't check has flat ccs in bios on VF Matt Roper
2024-12-11 6:42 ` [PATCH 2/3] drm/xe/rtp: Add match helper to omit SR-IOV VF device Marcin Bernatowicz
2025-01-07 23:14 ` Matt Roper
2024-12-11 6:42 ` [PATCH 3/3] drm/xe/vf: Don't apply Wa_22019338487 for VF Marcin Bernatowicz
2025-01-07 23:21 ` Matt Roper
2024-12-11 6:47 ` ✓ CI.Patch_applied: success for VF: Avoid reading inaccessible registers (rev2) Patchwork
2024-12-11 6:48 ` ✓ CI.checkpatch: " Patchwork
2024-12-11 6:49 ` ✓ CI.KUnit: " Patchwork
2024-12-11 7:07 ` ✓ CI.Build: " Patchwork
2024-12-11 7:09 ` ✓ CI.Hooks: " Patchwork
2024-12-11 7:11 ` ✓ CI.checksparse: " Patchwork
2024-12-11 7:36 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-11 8:34 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-12 11:55 ` Bernatowicz, Marcin
2025-01-07 23:27 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211064211.781820-2-marcin.bernatowicz@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=adam.miszczak@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jakub1.kolakowski@intel.com \
--cc=lukasz.laguna@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=michal.winiarski@intel.com \
--cc=narasimha.c.v@intel.com \
--cc=piotr.piorkowski@intel.com \
--cc=satyanarayana.k.v.p@intel.com \
--cc=tomasz.lis@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox