From: Maciej Patelczyk <maciej.patelczyk@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: lucas.demarchi@intel.com, raag.jadav@intel.com,
Maciej Patelczyk <maciej.patelczyk@intel.com>
Subject: [PATCH v3 2/2] drm/xe: make change ccs_mode a synchronous action
Date: Wed, 11 Dec 2024 12:17:27 +0100 [thread overview]
Message-ID: <20241211111727.1481476-3-maciej.patelczyk@intel.com> (raw)
In-Reply-To: <20241211111727.1481476-1-maciej.patelczyk@intel.com>
If ccs_mode is being modified via
/sys/class/drm/cardX/device/tileY/gtY/ccs_mode
the asynchronous reset is triggered and the write returns immediately.
With that some test receive false information about number of CCS engines
or even fail if they proceed without delay after changing the ccs_mode.
Changing the ccs_mode change from async to sync to prevent failures in
tests.
Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/xe/xe_gt_ccs_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_gt_ccs_mode.c b/drivers/gpu/drm/xe/xe_gt_ccs_mode.c
index b6adfb9f2030..50fffc9ebf62 100644
--- a/drivers/gpu/drm/xe/xe_gt_ccs_mode.c
+++ b/drivers/gpu/drm/xe/xe_gt_ccs_mode.c
@@ -150,7 +150,7 @@ ccs_mode_store(struct device *kdev, struct device_attribute *attr,
xe_gt_info(gt, "Setting compute mode to %d\n", num_engines);
gt->ccs_mode = num_engines;
xe_gt_record_user_engines(gt);
- xe_gt_reset_async(gt);
+ xe_gt_reset(gt);
}
mutex_unlock(&xe->drm.filelist_mutex);
--
2.43.0
next prev parent reply other threads:[~2024-12-11 11:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 11:17 [PATCH v3 0/2] drm/xe: adding wait helper for gt async reset Maciej Patelczyk
2024-12-11 11:17 ` [PATCH v3 1/2] drm/xe: introduce xe_gt_reset and xe_gt_wait_for_reset Maciej Patelczyk
2024-12-11 11:39 ` Nirmoy Das
2024-12-11 11:17 ` Maciej Patelczyk [this message]
2024-12-11 11:33 ` [PATCH v3 2/2] drm/xe: make change ccs_mode a synchronous action Nirmoy Das
2024-12-11 11:59 ` ✓ CI.Patch_applied: success for drm/xe: adding wait helper for gt async reset (rev3) Patchwork
2024-12-11 11:59 ` ✓ CI.checkpatch: " Patchwork
2024-12-11 12:00 ` ✓ CI.KUnit: " Patchwork
2024-12-11 12:18 ` ✓ CI.Build: " Patchwork
2024-12-11 12:20 ` ✓ CI.Hooks: " Patchwork
2024-12-11 12:22 ` ✓ CI.checksparse: " Patchwork
2024-12-12 6:43 ` ✓ CI.BAT: " Patchwork
2024-12-17 11:25 ` ✓ CI.Patch_applied: success for drm/xe: adding wait helper for gt async reset (rev4) Patchwork
2024-12-17 11:25 ` ✓ CI.checkpatch: " Patchwork
2024-12-17 11:27 ` ✓ CI.KUnit: " Patchwork
2024-12-17 11:45 ` ✓ CI.Build: " Patchwork
2024-12-17 11:47 ` ✓ CI.Hooks: " Patchwork
2024-12-17 11:48 ` ✓ CI.checksparse: " Patchwork
2024-12-17 12:09 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-17 19:49 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-20 10:05 ` Maciej Patelczyk
2025-01-13 9:50 ` Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211111727.1481476-3-maciej.patelczyk@intel.com \
--to=maciej.patelczyk@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox